From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 12/13] gnu: Add python-rarfile. Date: Fri, 4 Mar 2016 16:29:40 -0500 Message-ID: <20160304212940.GA463@jasmine> References: <8c8f5af9405151b57f1db84e194a15723751a9f1.1457054741.git.leo@famulari.name> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abxIW-0001Qb-0R for guix-devel@gnu.org; Fri, 04 Mar 2016 16:30:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abxIS-00025V-Ob for guix-devel@gnu.org; Fri, 04 Mar 2016 16:30:07 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:39776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abxIS-0001zu-J1 for guix-devel@gnu.org; Fri, 04 Mar 2016 16:30:04 -0500 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org On Fri, Mar 04, 2016 at 01:42:11PM +0100, Ricardo Wurmus wrote: > > Leo Famulari writes: > > > * gnu/packages/python.scm (python-rarfile, python2-rarfile): New > > variables. > > * gnu/packages/patches/python-rarfile-fix-tests.patch: New file. > > * gnu-system.am (dist_patch_DATA): Add it. > > --- > > [...] > > > + (propagated-inputs > > + `(("libarchive" ,libarchive))) > > + (home-page "https://github.com/markokr/rarfile") > > + (synopsis "RAR archive reader for Python") > > + (description "This is Python module for RAR archive reading. The interface > > +is made as zipfile like as possible.") > > + (license isc))) > > Does this actually work? I assumed that our “libarchive” package has no > support for RAR archives. I don't know. The libarchive documentation in 'share/man/man5/libarchive-formats.5.gz' does list RAR as a supported format. I added python-rarfile since the beets build process fails when it can't find it. I'd be surprised if it's really necessary though. In the beets source tarball, the string "rarfile" appears as a test requirement, and in 'beets/importer.py'. The importer is what a user invokes to add music to the beets database. Rarfile is not imported as a module by importer.py, so its absence shouldn't have any effect until a user actually tries to exercise the feature, if my (weak) understanding of Python is correct. I built a beets variant without rarfile, and tested the import functionality. It works as expected on uncompressed directories. It fails on archives, but it does that even without this change. So, what should I do? Patch "rarfile" out of setup.py or package python-rarfile?