* [PATCH] po: Drop removed file 'weechat.scm'.
@ 2016-03-03 11:44 Justus Winter
2016-03-03 15:47 ` Chris Marusich
2016-03-03 16:45 ` Ludovic Courtès
0 siblings, 2 replies; 5+ messages in thread
From: Justus Winter @ 2016-03-03 11:44 UTC (permalink / raw)
To: guix-devel
weechat has been merged into 'irc.scm' in e288f007.
* po/packages/POTFILES.in: Drop removed file 'weechat.scm'.
---
po/packages/POTFILES.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/po/packages/POTFILES.in b/po/packages/POTFILES.in
index d77cb3b..60c6ab3 100644
--- a/po/packages/POTFILES.in
+++ b/po/packages/POTFILES.in
@@ -55,7 +55,6 @@ gnu/packages/textutils.scm
gnu/packages/version-control.scm
gnu/packages/webkit.scm
gnu/packages/web.scm
-gnu/packages/weechat.scm
gnu/packages/wordnet.scm
gnu/packages/xiph.scm
gnu/packages/zip.scm
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] po: Drop removed file 'weechat.scm'.
2016-03-03 11:44 [PATCH] po: Drop removed file 'weechat.scm' Justus Winter
@ 2016-03-03 15:47 ` Chris Marusich
2016-03-03 17:11 ` Justus Winter
2016-03-03 16:45 ` Ludovic Courtès
1 sibling, 1 reply; 5+ messages in thread
From: Chris Marusich @ 2016-03-03 15:47 UTC (permalink / raw)
To: Justus Winter; +Cc: guix-devel
Hi Justus,
Is it not necessary to also do something about the other files that
mention weechat's prevoius location? For example:
--8<---------------cut here---------------start------------->8---
$ grep -r gnu/packages/weechat .
./po/packages/da.po:#: gnu/packages/weechat.scm:92
./po/packages/da.po:#: gnu/packages/weechat.scm:93
./po/packages/pl.po:#: gnu/packages/weechat.scm:92
./po/packages/pl.po:#: gnu/packages/weechat.scm:93
./po/packages/POTFILES.in:gnu/packages/weechat.scm
--8<---------------cut here---------------end--------------->8---
Also, FYI I filed a bug report about this yesterday because I noticed
the problem but wasn't sure how to fix it. If you figure out how to fix
it, we can probably resolve that!
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22888
Chris
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] po: Drop removed file 'weechat.scm'.
2016-03-03 15:47 ` Chris Marusich
@ 2016-03-03 17:11 ` Justus Winter
2016-03-04 10:55 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Justus Winter @ 2016-03-03 17:11 UTC (permalink / raw)
To: Chris Marusich; +Cc: guix-devel
Hi Chris :)
Quoting Chris Marusich (2016-03-03 16:47:13)
> Is it not necessary to also do something about the other files that
> mention weechat's prevoius location? For example:
>
> --8<---------------cut here---------------start------------->8---
> $ grep -r gnu/packages/weechat .
> ./po/packages/da.po:#: gnu/packages/weechat.scm:92
> ./po/packages/da.po:#: gnu/packages/weechat.scm:93
> ./po/packages/pl.po:#: gnu/packages/weechat.scm:92
> ./po/packages/pl.po:#: gnu/packages/weechat.scm:93
> ./po/packages/POTFILES.in:gnu/packages/weechat.scm
> --8<---------------cut here---------------end--------------->8---
I guess you're right in general, but I've looked at the two files and
they don't contain localized strings for weechat, so we're not losing
translations.
I don't know who is responsible for updating the files.
> Also, FYI I filed a bug report about this yesterday because I noticed
> the problem but wasn't sure how to fix it. If you figure out how to fix
> it, we can probably resolve that!
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22888
Cool! Well, this patch is my stab at fixing it.
Cheers,
Justus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] po: Drop removed file 'weechat.scm'.
2016-03-03 17:11 ` Justus Winter
@ 2016-03-04 10:55 ` Ludovic Courtès
0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2016-03-04 10:55 UTC (permalink / raw)
To: Justus Winter; +Cc: guix-devel
Justus Winter <justus@gnupg.org> skribis:
> Quoting Chris Marusich (2016-03-03 16:47:13)
>> Is it not necessary to also do something about the other files that
>> mention weechat's prevoius location? For example:
>>
>> --8<---------------cut here---------------start------------->8---
>> $ grep -r gnu/packages/weechat .
>> ./po/packages/da.po:#: gnu/packages/weechat.scm:92
>> ./po/packages/da.po:#: gnu/packages/weechat.scm:93
>> ./po/packages/pl.po:#: gnu/packages/weechat.scm:92
>> ./po/packages/pl.po:#: gnu/packages/weechat.scm:93
>> ./po/packages/POTFILES.in:gnu/packages/weechat.scm
>> --8<---------------cut here---------------end--------------->8---
>
> I guess you're right in general, but I've looked at the two files and
> they don't contain localized strings for weechat, so we're not losing
> translations.
>
> I don't know who is responsible for updating the files.
Usually I commit them when the Translation Project sends us updates.
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] po: Drop removed file 'weechat.scm'.
2016-03-03 11:44 [PATCH] po: Drop removed file 'weechat.scm' Justus Winter
2016-03-03 15:47 ` Chris Marusich
@ 2016-03-03 16:45 ` Ludovic Courtès
1 sibling, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2016-03-03 16:45 UTC (permalink / raw)
To: Justus Winter; +Cc: guix-devel
Justus Winter <justus@gnupg.org> skribis:
> weechat has been merged into 'irc.scm' in e288f007.
>
> * po/packages/POTFILES.in: Drop removed file 'weechat.scm'.
Pushed, thanks!
Chris Marusich <cmmarusich@gmail.com> skribis:
> Is it not necessary to also do something about the other files that
> mention weechat's prevoius location? For example:
>
> $ grep -r gnu/packages/weechat .
> ./po/packages/da.po:#: gnu/packages/weechat.scm:92
This is fine, they will be regenerated (and it’s a comment so it has no
functional impact.)
> Also, FYI I filed a bug report about this yesterday because I noticed
> the problem but wasn't sure how to fix it. If you figure out how to fix
> it, we can probably resolve that!
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22888
Closed now! :-)
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-04 10:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-03 11:44 [PATCH] po: Drop removed file 'weechat.scm' Justus Winter
2016-03-03 15:47 ` Chris Marusich
2016-03-03 17:11 ` Justus Winter
2016-03-04 10:55 ` Ludovic Courtès
2016-03-03 16:45 ` Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.