From mboxrd@z Thu Jan 1 00:00:00 1970 From: Justus Winter Subject: Re: [PATCH] po: Drop removed file 'weechat.scm'. Date: Thu, 03 Mar 2016 18:11:01 +0100 Message-ID: <20160303171101.4486.75742@thinkbox.jade-hamburg.de> References: <1457005486-25235-1-git-send-email-justus@gnupg.org> <87d1rb5zsu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abWme-0001LL-J9 for guix-devel@gnu.org; Thu, 03 Mar 2016 12:11:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abWmb-0004jX-B5 for guix-devel@gnu.org; Thu, 03 Mar 2016 12:11:28 -0500 Received: from cryptobitch.de ([88.198.7.68]:52904 helo=mail.cryptobitch.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abWmb-0004XC-4L for guix-devel@gnu.org; Thu, 03 Mar 2016 12:11:25 -0500 In-Reply-To: <87d1rb5zsu.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Chris Marusich Cc: guix-devel@gnu.org Hi Chris :) Quoting Chris Marusich (2016-03-03 16:47:13) > Is it not necessary to also do something about the other files that > mention weechat's prevoius location? For example: > = > --8<---------------cut here---------------start------------->8--- > $ grep -r gnu/packages/weechat . > ./po/packages/da.po:#: gnu/packages/weechat.scm:92 > ./po/packages/da.po:#: gnu/packages/weechat.scm:93 > ./po/packages/pl.po:#: gnu/packages/weechat.scm:92 > ./po/packages/pl.po:#: gnu/packages/weechat.scm:93 > ./po/packages/POTFILES.in:gnu/packages/weechat.scm > --8<---------------cut here---------------end--------------->8--- I guess you're right in general, but I've looked at the two files and they don't contain localized strings for weechat, so we're not losing translations. I don't know who is responsible for updating the files. > Also, FYI I filed a bug report about this yesterday because I noticed > the problem but wasn't sure how to fix it. If you figure out how to fix > it, we can probably resolve that! > = > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D22888 Cool! Well, this patch is my stab at fixing it. Cheers, Justus