From: Efraim Flashner <efraim@flashner.co.il>
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add python-backports-abc.
Date: Sun, 28 Feb 2016 11:06:12 +0200 [thread overview]
Message-ID: <20160228110612.557696a1@debian-netbook> (raw)
In-Reply-To: <20160228083759.GA16526@solar>
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
On Sun, 28 Feb 2016 09:37:59 +0100
Andreas Enge <andreas@enge.fr> wrote:
> On Fri, Feb 26, 2016 at 11:11:22AM +0200, Efraim Flashner wrote:
> > + (description
> > + "A backport of recent additions to the 'collections.abc' module.")
>
> This should be a full sentence; right now it is missing a verb, at least it
> should be "foo is/constitutes/provides a backport". "recent additions" is
> a bit vague; maybe add that it backports features of Python 3.5?
>
> Otherwise it looks good; and then there is nothing to say about the
> python-tornado update.
>
> Andreas
>
fixed! I also corrected the indentation around (source
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-28 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 9:11 [PATCH 0/2] python-tornado-4.3 Efraim Flashner
2016-02-26 9:11 ` [PATCH 1/2] gnu: Add python-backports-abc Efraim Flashner
2016-02-28 8:37 ` Andreas Enge
2016-02-28 9:06 ` Efraim Flashner [this message]
2016-02-26 9:11 ` [PATCH 2/2] gnu: python-tornado: Update to 4.3 Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160228110612.557696a1@debian-netbook \
--to=efraim@flashner.co.il \
--cc=andreas@enge.fr \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.