From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add libBigWig.
Date: Thu, 25 Feb 2016 14:38:40 -0500
Message-ID: <20160225193840.GD18435@jasmine>
References: <idjio1e2i5g.fsf@bimsb-sys02.mdc-berlin.net>
	<20160225014702.GE31607@jasmine>
	<idja8mp2hzh.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37748)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aZ1kP-0002Z0-VK
	for guix-devel@gnu.org; Thu, 25 Feb 2016 14:38:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aZ1kL-0001xm-Q2
	for guix-devel@gnu.org; Thu, 25 Feb 2016 14:38:49 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:45453)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aZ1kL-0001xa-MX
	for guix-devel@gnu.org; Thu, 25 Feb 2016 14:38:45 -0500
Content-Disposition: inline
In-Reply-To: <idja8mp2hzh.fsf@bimsb-sys02.mdc-berlin.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

On Thu, Feb 25, 2016 at 11:37:38AM +0100, Ricardo Wurmus wrote:
> 
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Wed, Feb 24, 2016 at 05:21:47PM +0100, Ricardo Wurmus wrote:
> >> Hi Guix,
> >> 
> >> the description is a little short.  Basically, this is a cleaner
> >> reimplementation of a popular tool/library that is released under a
> >> non-commercial license.  There is little more I can say about it and the
> >> original description just references that other tool.
> >> 
> >> Any ideas how to improve this?
> >
> > If you think it will be clear to the intended audience, I'd say it's
> > fine.
> 
> Okay.
> 
> > If "Kent's library" is well-known in the field, would it make sense to
> > refer to it?
> 
> I don’t know.  They refer to the kentUtils, but I don’t really want to
> mention them.  They are a grab bag with many different features (only
> one of which is reading bigwig files), so I don’t think it would clarify
> much.
> 
> >> +         (add-before 'install 'create-target-dirs
> >> +           (lambda* (#:key outputs #:allow-other-keys)
> >> +             (let ((out (assoc-ref outputs "out")))
> >> +               (mkdir-p (string-append out "/lib"))
> >> +               (mkdir-p (string-append out "/include"))
> >> +               #t))))))
> >
> > Does it make sense to upstream this? I understand if it's not worth your
> > time...
> 
> Done:
> 
>   https://github.com/dpryan79/libBigWig/issues/6
> 
> A new commit has already been made but there’s no release with that
> change yet.  I’ll add a comment to this phase.

That's awesome, thank you!

> 
> Thanks for taking the time to review this patch!
> 
> ~~ Ricardo