[PATCH 0/1] Fix telepathy-logger build failure

[PATCH 0/1] Fix telepathy-logger build failure

[Leo Famulari]

Telepathy-logger hasn't been building on x86_64 and i686:
http://hydra.gnu.org/job/gnu/master/telepathy-logger-0.8.2.x86_64-linux
http://hydra.gnu.org/job/gnu/master/telepathy-logger-0.8.2.i686-linux

Disabling parallel tests fixes it for me on x86_64, and when building
for i686.

Leo Famulari (1):
  gnu: telepathy-logger: Disable parallel tests.

 gnu/packages/freedesktop.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.7.1

[PATCH 1/1] gnu: telepathy-logger: Disable parallel tests.

[Leo Famulari]

* gnu/packages/freedesktop.scm (telepathy-logger)[arguments]: Disable parallel
tests.
---
 gnu/packages/freedesktop.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index e23cc97..bff709c 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -547,7 +547,8 @@ modems and setup connections with them.")
                 "1bjx85k7jyfi5pvl765fzc7q2iz9va51anrc2djv7caksqsdbjlg"))))
     (build-system gnu-build-system)
     (arguments
-     '(#:phases
+     '(#:parallel-tests? #f
+       #:phases
        (modify-phases %standard-phases
          (add-before 'check 'pre-check
           (lambda _
-- 
2.7.1

Re: [PATCH 1/1] gnu: telepathy-logger: Disable parallel tests.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

On Tue, 23 Feb 2016 03:44:50 -0500
Leo Famulari <leo@famulari.name> wrote:

> * gnu/packages/freedesktop.scm (telepathy-logger)[arguments]: Disable parallel
> tests.
> ---
>  gnu/packages/freedesktop.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index e23cc97..bff709c 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -547,7 +547,8 @@ modems and setup connections with them.")
>                  "1bjx85k7jyfi5pvl765fzc7q2iz9va51anrc2djv7caksqsdbjlg"))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(#:phases
> +     '(#:parallel-tests? #f
> +       #:phases
>         (modify-phases %standard-phases
>           (add-before 'check 'pre-check
>            (lambda _

this looks fine for pushing

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 1/1] gnu: telepathy-logger: Disable parallel tests.

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> * gnu/packages/freedesktop.scm (telepathy-logger)[arguments]: Disable parallel
> tests.
> ---
>  gnu/packages/freedesktop.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index e23cc97..bff709c 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -547,7 +547,8 @@ modems and setup connections with them.")
>                  "1bjx85k7jyfi5pvl765fzc7q2iz9va51anrc2djv7caksqsdbjlg"))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(#:phases
> +     '(#:parallel-tests? #f

Thanks for fixing it!

In the future it’s even better to add a comment with hints as to why
tests aren’t parallel-safe, if possible.

Ludo’.