* [PATCH 1/18] gnu: Add python-mako.
@ 2016-02-15 23:23 Christopher Allan Webber
2016-02-16 1:34 ` Leo Famulari
0 siblings, 1 reply; 6+ messages in thread
From: Christopher Allan Webber @ 2016-02-15 23:23 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 51 bytes --]
First in a series of towards-MediaGoblin patches.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-python-mako.patch --]
[-- Type: text/x-patch, Size: 1736 bytes --]
From ad76816977e98e0230ccde7475598e6e85de4d29 Mon Sep 17 00:00:00 2001
From: Christopher Allan Webber <cwebber@dustycloud.org>
Date: Fri, 12 Feb 2016 13:23:46 -0800
Subject: [PATCH 01/18] gnu: Add python-mako.
* gnu/packages/python.scm (python-mako, python2-mako): New variables.
---
gnu/packages/python.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 805c4a2..5b7e4ac 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -7532,3 +7532,34 @@ available in Django, but is a standalone package.")
(inherit (package-with-python2
(strip-python2-variant python-wtforms)))
(inputs `(("python2-setuptools" ,python2-setuptools)))))
+
+(define-public python-mako
+ (package
+ (name "python-mako")
+ (version "1.0.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "Mako" version))
+ (sha256
+ (base32
+ "136kcjbs0s98qkx8a418b05dfblqp0kiiqyx8vhx4rarwc7bqi3n"))))
+ (build-system python-build-system)
+ (inputs
+ `(("python-markupsafe" ,python-markupsafe)
+ ("python-mock" ,python-mock)
+ ("python-nose" ,python-nose)))
+ (home-page "http://www.makotemplates.org/")
+ (synopsis
+ "Fast templating language")
+ (description
+ "Mako is a Python string templating library. Used frequently for
+generating HTML.")
+ (license license:expat)
+ (properties `((python2-variant . ,(delay python2-mako))))))
+
+(define-public python2-mako
+ (package
+ (inherit (package-with-python2
+ (strip-python2-variant python-mako)))
+ (inputs `(("python2-setuptools" ,python2-setuptools)))))
--
2.6.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/18] gnu: Add python-mako.
2016-02-15 23:23 [PATCH 1/18] gnu: Add python-mako Christopher Allan Webber
@ 2016-02-16 1:34 ` Leo Famulari
2016-02-20 2:40 ` On the MediaGoblin dependency patch updates Christopher Allan Webber
0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2016-02-16 1:34 UTC (permalink / raw)
To: Christopher Allan Webber; +Cc: guix-devel
On Mon, Feb 15, 2016 at 03:23:45PM -0800, Christopher Allan Webber wrote:
> First in a series of towards-MediaGoblin patches.
Awesome!
I'm reviewing these on the assumption that you've tested they all build.
> From ad76816977e98e0230ccde7475598e6e85de4d29 Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Fri, 12 Feb 2016 13:23:46 -0800
> Subject: [PATCH 01/18] gnu: Add python-mako.
>
> * gnu/packages/python.scm (python-mako, python2-mako): New variables.
> ---
> gnu/packages/python.scm | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 805c4a2..5b7e4ac 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -7532,3 +7532,34 @@ available in Django, but is a standalone package.")
> (inherit (package-with-python2
> (strip-python2-variant python-wtforms)))
> (inputs `(("python2-setuptools" ,python2-setuptools)))))
> +
> +(define-public python-mako
> + (package
> + (name "python-mako")
> + (version "1.0.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "Mako" version))
> + (sha256
> + (base32
> + "136kcjbs0s98qkx8a418b05dfblqp0kiiqyx8vhx4rarwc7bqi3n"))))
> + (build-system python-build-system)
> + (inputs
> + `(("python-markupsafe" ,python-markupsafe)
> + ("python-mock" ,python-mock)
> + ("python-nose" ,python-nose)))
Are mock and nose required after build-time? If not, they should be
native-inputs.
As for markupsafe, the latest version of the manual has this to say
about propagated-inputs:
Another example where propagated-inputs is useful is for languages that
lack a facility to record the run-time search path akin to ELF’s
RUNPATH; this includes Guile, Python, Perl, GHC, and more. To ensure
that libraries written in those languages can find library code they
depend on at run time, run-time dependencies must be listed in
propagated-inputs rather than inputs.
I won't mention these potential issues in my reviews of the rest of the
patches.
> + (home-page "http://www.makotemplates.org/")
> + (synopsis
> + "Fast templating language")
> + (description
> + "Mako is a Python string templating library. Used frequently for
> +generating HTML.")
> + (license license:expat)
> + (properties `((python2-variant . ,(delay python2-mako))))))
> +
> +(define-public python2-mako
> + (package
> + (inherit (package-with-python2
> + (strip-python2-variant python-mako)))
> + (inputs `(("python2-setuptools" ,python2-setuptools)))))
Setuptools is a native-input.
> --
> 2.6.3
>
^ permalink raw reply [flat|nested] 6+ messages in thread* On the MediaGoblin dependency patch updates
2016-02-16 1:34 ` Leo Famulari
@ 2016-02-20 2:40 ` Christopher Allan Webber
2016-02-20 4:58 ` Leo Famulari
0 siblings, 1 reply; 6+ messages in thread
From: Christopher Allan Webber @ 2016-02-20 2:40 UTC (permalink / raw)
To: Leo Famulari; +Cc: guix-devel
Leo Famulari writes:
> On Mon, Feb 15, 2016 at 03:23:45PM -0800, Christopher Allan Webber wrote:
>> First in a series of towards-MediaGoblin patches.
>
> Awesome!
>
> I'm reviewing these on the assumption that you've tested they all build.
I have, if I forgot to say that previously.
> Are mock and nose required after build-time? If not, they should be
> native-inputs.
>
> As for markupsafe, the latest version of the manual has this to say
> about propagated-inputs:
>
> Another example where propagated-inputs is useful is for languages that
> lack a facility to record the run-time search path akin to ELF’s
> RUNPATH; this includes Guile, Python, Perl, GHC, and more. To ensure
> that libraries written in those languages can find library code they
> depend on at run time, run-time dependencies must be listed in
> propagated-inputs rather than inputs.
>
> I won't mention these potential issues in my reviews of the rest of the
> patches.
I sent a whole new batch of patches for all these, and updated
wip-mediagoblin. The only one not updated was python-mako, which I
removed, since Dave got that into master anyway. It's all rebased,
and Leo's suggestions are all included (with the exception of one
comment where an indentation change was suggested, and I stuck with the
way emacs does it).
So, unless there's any more feedback, the whole lot of these can be
merged into master, and then we can work on MediaGoblin itself.
- Chris
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: On the MediaGoblin dependency patch updates
2016-02-20 2:40 ` On the MediaGoblin dependency patch updates Christopher Allan Webber
@ 2016-02-20 4:58 ` Leo Famulari
2016-02-22 3:05 ` Christopher Allan Webber
0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2016-02-20 4:58 UTC (permalink / raw)
To: Christopher Allan Webber; +Cc: guix-devel
On Fri, Feb 19, 2016 at 06:40:14PM -0800, Christopher Allan Webber wrote:
> Leo Famulari writes:
>
> > On Mon, Feb 15, 2016 at 03:23:45PM -0800, Christopher Allan Webber wrote:
> >> First in a series of towards-MediaGoblin patches.
> >
> > Awesome!
> >
> > I'm reviewing these on the assumption that you've tested they all build.
>
> I have, if I forgot to say that previously.
>
> > Are mock and nose required after build-time? If not, they should be
> > native-inputs.
> >
> > As for markupsafe, the latest version of the manual has this to say
> > about propagated-inputs:
> >
> > Another example where propagated-inputs is useful is for languages that
> > lack a facility to record the run-time search path akin to ELF’s
> > RUNPATH; this includes Guile, Python, Perl, GHC, and more. To ensure
> > that libraries written in those languages can find library code they
> > depend on at run time, run-time dependencies must be listed in
> > propagated-inputs rather than inputs.
> >
> > I won't mention these potential issues in my reviews of the rest of the
> > patches.
>
> I sent a whole new batch of patches for all these, and updated
> wip-mediagoblin. The only one not updated was python-mako, which I
> removed, since Dave got that into master anyway. It's all rebased,
> and Leo's suggestions are all included (with the exception of one
> comment where an indentation change was suggested, and I stuck with the
> way emacs does it).
That's fine — my sense of style isn't very strong and my tools are
relatively poor compared to Emacs ;)
>
> So, unless there's any more feedback, the whole lot of these can be
> merged into master, and then we can work on MediaGoblin itself.
I've read them all and sent my comments. Any patches I didn't reply to
LGTM.
Thanks for doing this work! It's very exciting!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: On the MediaGoblin dependency patch updates
2016-02-20 4:58 ` Leo Famulari
@ 2016-02-22 3:05 ` Christopher Allan Webber
2016-02-22 3:49 ` Leo Famulari
0 siblings, 1 reply; 6+ messages in thread
From: Christopher Allan Webber @ 2016-02-22 3:05 UTC (permalink / raw)
To: Leo Famulari; +Cc: guix-devel
Leo Famulari writes:
> I've read them all and sent my comments. Any patches I didn't reply to
> LGTM.
>
> Thanks for doing this work! It's very exciting!
Great, I've made all adjustments you've asked for and finally pushed all
python dependencies for MediaGoblin to Guix's master branch. Exciting
times! :)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: On the MediaGoblin dependency patch updates
2016-02-22 3:05 ` Christopher Allan Webber
@ 2016-02-22 3:49 ` Leo Famulari
0 siblings, 0 replies; 6+ messages in thread
From: Leo Famulari @ 2016-02-22 3:49 UTC (permalink / raw)
To: Christopher Allan Webber; +Cc: guix-devel
On Sun, Feb 21, 2016 at 07:05:10PM -0800, Christopher Allan Webber wrote:
> Leo Famulari writes:
>
> > I've read them all and sent my comments. Any patches I didn't reply to
> > LGTM.
> >
> > Thanks for doing this work! It's very exciting!
>
> Great, I've made all adjustments you've asked for and finally pushed all
> python dependencies for MediaGoblin to Guix's master branch. Exciting
> times! :)
Cool!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-22 3:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-15 23:23 [PATCH 1/18] gnu: Add python-mako Christopher Allan Webber
2016-02-16 1:34 ` Leo Famulari
2016-02-20 2:40 ` On the MediaGoblin dependency patch updates Christopher Allan Webber
2016-02-20 4:58 ` Leo Famulari
2016-02-22 3:05 ` Christopher Allan Webber
2016-02-22 3:49 ` Leo Famulari
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.