From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH 1/7] gnu: Add mate-polkit.
Date: Sun, 21 Feb 2016 16:26:19 +0100
Message-ID: <20160221152619.GA25181@solar>
References: <1455912381-25148-1-git-send-email-fhmgufs@web.de>
	<20160220134117.GA6934@solar> <20160220181728.1378d9a7@alarmpi>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56507)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1aXVu1-0003WZ-Gc
	for guix-devel@gnu.org; Sun, 21 Feb 2016 10:26:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1aXVtw-0002c1-CQ
	for guix-devel@gnu.org; Sun, 21 Feb 2016 10:26:29 -0500
Received: from mailrelay2.public.one.com ([91.198.169.125]:43398)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1aXVtw-0002ZH-1W
	for guix-devel@gnu.org; Sun, 21 Feb 2016 10:26:24 -0500
Content-Disposition: inline
In-Reply-To: <20160220181728.1378d9a7@alarmpi>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Fabian Harfert <fhmgufs@web.de>
Cc: guix-devel@gnu.org

Hello,

On Sat, Feb 20, 2016 at 06:17:28PM +0100, Fabian Harfert wrote:
> I carefully checked all the library source dependencies and so on. I
> think all these propagated inputs are needed.

okay, excellent.

> If that is necessary, I'll add these comments, but I think it's not too
> difficult to look into the .pc files. Some of the packages have
> comments, but the most don't.

Well, it would be useful in the future, as some kind of proof that you had
a look at it, and also to keep track if people wonder why it has been
done like this. If there is a change in the future and something is not
needed any more, this would then become clear simply by looking at the
referenced .pc file.

> But actually I don't really know. I'll recheck all the .pc files and
> headers (not too much).

I think there is no need to check the headers; the example I gave was
already treated correctly. If a header is needed, most of the time the
library will also be mentioned in the .pc file.

I will let you have a look at the glib-or-gtk-build-system question,
and give us notice again when the next patches are ready. On the other
hand, if there are mistakes, that would not be a big problem; when you
notice in the end that something does not work, it will still be time
to add (propagated or other) inputs.

Thanks for all this work!

Andreas