From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 1/7] gnu: Add mate-polkit. Date: Sat, 20 Feb 2016 12:30:17 -0500 Message-ID: <20160220173017.GA19011@jasmine> References: <1455912381-25148-1-git-send-email-fhmgufs@web.de> <20160220134117.GA6934@solar> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXBMO-0007ci-Pk for guix-devel@gnu.org; Sat, 20 Feb 2016 12:30:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXBML-0006FA-Js for guix-devel@gnu.org; Sat, 20 Feb 2016 12:30:24 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:46840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXBML-0006F5-DJ for guix-devel@gnu.org; Sat, 20 Feb 2016 12:30:21 -0500 Content-Disposition: inline In-Reply-To: <20160220134117.GA6934@solar> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org On Sat, Feb 20, 2016 at 02:41:17PM +0100, Andreas Enge wrote: > Hello, > > before considering more mate packages, I would like to get back to discussing > the existing ones; as I am not knowledgeable about desktop packages, I must > admit I did not look at them too closely before. So maybe my comments can > also be disregarded, but it would be good if someone more expert could > chime in. I feel similarly about all these desktop packages. It would be very useful if submitters could include some kind of minimal example of a system declaration that would demonstrate the DE. > > First of all, the build system. Since usually there are inputs glib and gtk+, > would it not be more appropriate to use glib-or-gtk-build-system? > > Second, there are lots of propagated inputs. Are these really needed? > It is a bit strange that a library like libmateweather should need such a > propagation; normally our runpath magic should have rewritten all references > to input libraries. > > If propagations are necessary, the reason should be added as a comment, for > instance as for gnome-desktop: > (propagated-inputs > ;; Required by gnome-desktop-3.0.pc. > `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas) > ("gtk+" ,gtk+))) > The .pc file of libmateweather indeed has the following lines: > Requires: glib-2.0 gobject-2.0 gdk-pixbuf-2.0 gtk+-2.0 gio-2.0 > Requires.private: libxml-2.0 libsoup-2.4 > Also, weather.h contains > #include > So it looks as if propagation is needed here. > > What do you think? > > Andreas > >