* [PATCH 2/7] gnu: Add libmatekbd.
2016-02-19 20:06 [PATCH 1/7] gnu: Add mate-polkit Fabian Harfert
@ 2016-02-19 20:06 ` Fabian Harfert
2016-02-19 20:06 ` [PATCH 3/7] gnu: Add libmatemixer Fabian Harfert
` (5 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Fabian Harfert @ 2016-02-19 20:06 UTC (permalink / raw)
To: guix-devel
* gnu/packages/mate.scm (libmatekbd): New variable.
---
gnu/packages/mate.scm | 34 +++++++++++++++++++++++++++++++++-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm
index 7eb83de..ebe99cb 100644
--- a/gnu/packages/mate.scm
+++ b/gnu/packages/mate.scm
@@ -33,7 +33,8 @@
#:use-module (gnu packages xml)
#:use-module (gnu packages python)
#:use-module (gnu packages freedesktop)
- #:use-module (gnu packages polkit))
+ #:use-module (gnu packages polkit)
+ #:use-module (gnu packages iso-codes))
(define-public mate-icon-theme
(package
@@ -239,3 +240,34 @@ assorted menu related utility programs.")
"This package contains extensions for PolicyKit used by the MATE desktop
environment.")
(license license:lgpl2.0+)))
+
+(define-public libmatekbd
+ (package
+ (name "libmatekbd")
+ (version "1.12.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "http://pub.mate-desktop.org/releases/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "18jfnrxpdhpqish8a0fzcgndbqb8a0z5p8vahd3spl1zn97lk82q"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("intltool" ,intltool)
+ ("pkg-config" ,pkg-config)
+ ("glib:bin" ,glib "bin")))
+ (inputs
+ `(("dconf" ,dconf)
+ ("iso-codes" ,iso-codes)))
+ (propagated-inputs
+ `(("gtk+" ,gtk+-2)
+ ("glib" ,glib)
+ ("libxklavier" ,libxklavier)))
+ (home-page "http://mate-desktop.org/")
+ (synopsis "MATE library to manage keyboard configuration")
+ (description
+ "Libmatekbd offers an API to manage the keyboard in MATE applications and
+the GUI elements to display its operations.")
+ (license license:lgpl2.0+)))
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 3/7] gnu: Add libmatemixer.
2016-02-19 20:06 [PATCH 1/7] gnu: Add mate-polkit Fabian Harfert
2016-02-19 20:06 ` [PATCH 2/7] gnu: Add libmatekbd Fabian Harfert
@ 2016-02-19 20:06 ` Fabian Harfert
2016-02-19 20:06 ` [PATCH 4/7] gnu: Add mate-settings-daemon Fabian Harfert
` (4 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Fabian Harfert @ 2016-02-19 20:06 UTC (permalink / raw)
To: guix-devel
* gnu/packages/mate.scm (libmatemixer): New variable.
---
gnu/packages/mate.scm | 32 +++++++++++++++++++++++++++++++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm
index ebe99cb..c88db14 100644
--- a/gnu/packages/mate.scm
+++ b/gnu/packages/mate.scm
@@ -34,7 +34,9 @@
#:use-module (gnu packages python)
#:use-module (gnu packages freedesktop)
#:use-module (gnu packages polkit)
- #:use-module (gnu packages iso-codes))
+ #:use-module (gnu packages iso-codes)
+ #:use-module (gnu packages linux)
+ #:use-module (gnu packages pulseaudio))
(define-public mate-icon-theme
(package
@@ -271,3 +273,31 @@ environment.")
"Libmatekbd offers an API to manage the keyboard in MATE applications and
the GUI elements to display its operations.")
(license license:lgpl2.0+)))
+
+(define-public libmatemixer
+ (package
+ (name "libmatemixer")
+ (version "1.12.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "http://pub.mate-desktop.org/releases/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "1w0grrhlmwajw6d92cs4gfwck6nq23i30alj50243dygycaxvkfy"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("intltool" ,intltool)
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("alsa-lib" ,alsa-lib)
+ ("pulseaudio" ,pulseaudio)))
+ (propagated-inputs
+ `(("glib" ,glib)))
+ (home-page "http://mate-desktop.org/")
+ (synopsis "Sound mixer library for MATE Desktop")
+ (description
+ "Libmatemixer provides an abstract API allowing access to mixer
+functionality available in the PulseAudio, ALSA and OSS sound systems.")
+ (license license:lgpl2.0+)))
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 4/7] gnu: Add mate-settings-daemon.
2016-02-19 20:06 [PATCH 1/7] gnu: Add mate-polkit Fabian Harfert
2016-02-19 20:06 ` [PATCH 2/7] gnu: Add libmatekbd Fabian Harfert
2016-02-19 20:06 ` [PATCH 3/7] gnu: Add libmatemixer Fabian Harfert
@ 2016-02-19 20:06 ` Fabian Harfert
2016-02-19 20:06 ` [PATCH 5/7] gnu: Add mate-session-manager Fabian Harfert
` (3 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Fabian Harfert @ 2016-02-19 20:06 UTC (permalink / raw)
To: guix-devel
* gnu/packages/mate.scm (mate-settings-daemon): New variable.
---
gnu/packages/mate.scm | 45 ++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 44 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm
index c88db14..aa2dc44 100644
--- a/gnu/packages/mate.scm
+++ b/gnu/packages/mate.scm
@@ -36,7 +36,10 @@
#:use-module (gnu packages polkit)
#:use-module (gnu packages iso-codes)
#:use-module (gnu packages linux)
- #:use-module (gnu packages pulseaudio))
+ #:use-module (gnu packages pulseaudio)
+ #:use-module (gnu packages fontutils)
+ #:use-module (gnu packages libcanberra)
+ #:use-module (gnu packages gnuzilla))
(define-public mate-icon-theme
(package
@@ -301,3 +304,43 @@ the GUI elements to display its operations.")
"Libmatemixer provides an abstract API allowing access to mixer
functionality available in the PulseAudio, ALSA and OSS sound systems.")
(license license:lgpl2.0+)))
+
+(define-public mate-settings-daemon
+ (package
+ (name "mate-settings-daemon")
+ (version "1.12.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "http://pub.mate-desktop.org/releases/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "1279f7mz026407bsj6wc46imyr5f3mvnrzryhw750a2qp9aymnd0"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("intltool" ,intltool)
+ ("pkg-config" ,pkg-config)
+ ("glib:bin" ,glib "bin")))
+ (inputs
+ `(("dbus-glib" ,dbus-glib)
+ ("dconf" ,dconf)
+ ("fontconfig" ,fontconfig)
+ ("gtk+" ,gtk+-2)
+ ("libcanberra-gtk2" ,libcanberra/gtk+-2)
+ ("libmatekbd" ,libmatekbd)
+ ("libmatemixer" ,libmatemixer)
+ ("libnotify" ,libnotify)
+ ("libxt" ,libxt)
+ ("mate-desktop" ,mate-desktop)
+ ("nss" ,nss)
+ ("polkit" ,polkit)
+ ("libxi" ,libxi)))
+ (home-page "http://mate-desktop.org/")
+ (synopsis "Daemon handling the MATE session settings")
+ (description
+ "This package contains the daemon which is responsible for setting the
+various parameters of a MATE session and the applications that run under it,
+for example keyboard, mouse or theming.")
+ (license (list license:gpl2+ license:gpl3+ license:lgpl2.0+
+ license:lgpl2.1+))))
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 5/7] gnu: Add mate-session-manager.
2016-02-19 20:06 [PATCH 1/7] gnu: Add mate-polkit Fabian Harfert
` (2 preceding siblings ...)
2016-02-19 20:06 ` [PATCH 4/7] gnu: Add mate-settings-daemon Fabian Harfert
@ 2016-02-19 20:06 ` Fabian Harfert
2016-02-19 20:06 ` [PATCH 6/7] gnu: Add marco Fabian Harfert
` (2 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Fabian Harfert @ 2016-02-19 20:06 UTC (permalink / raw)
To: guix-devel
* gnu/packages/mate.scm (mate-session-manager): New variable.
---
gnu/packages/mate.scm | 40 +++++++++++++++++++++++++++++++++++++++-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm
index aa2dc44..0ff8b95 100644
--- a/gnu/packages/mate.scm
+++ b/gnu/packages/mate.scm
@@ -39,7 +39,8 @@
#:use-module (gnu packages pulseaudio)
#:use-module (gnu packages fontutils)
#:use-module (gnu packages libcanberra)
- #:use-module (gnu packages gnuzilla))
+ #:use-module (gnu packages gnuzilla)
+ #:use-module (gnu packages docbook))
(define-public mate-icon-theme
(package
@@ -344,3 +345,40 @@ various parameters of a MATE session and the applications that run under it,
for example keyboard, mouse or theming.")
(license (list license:gpl2+ license:gpl3+ license:lgpl2.0+
license:lgpl2.1+))))
+
+(define-public mate-session-manager
+ (package
+ (name "mate-session-manager")
+ (version "1.12.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "http://pub.mate-desktop.org/releases/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "1qp776s7m568sj9j5vpdms0dixf9qy01bfkv6izq1rn0glnmkb9b"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("intltool" ,intltool)
+ ("xsltproc" ,libxslt)
+ ("libxml2" ,libxml2)
+ ("docbook-xml" ,docbook-xml-4.2)
+ ("docbook-xsl" ,docbook-xsl)
+ ("glib:bin" ,glib "bin")))
+ (inputs
+ `(("dbus-glib" ,dbus-glib)
+ ("gtk+" ,gtk+-2)
+ ("libsm" ,libsm)
+ ("libxtst" ,libxtst)
+ ("mate-desktop" ,mate-desktop)
+ ("mate-settings-daemon" ,mate-settings-daemon)
+ ("mate-polkit" ,mate-polkit)))
+ (home-page "http://mate-desktop.org/")
+ (synopsis "Session manager of the MATE desktop environment")
+ (description
+ "This package contains a session that can be started from a display
+manager. It will load all necessary applications for a full-featured
+MATE desktop environment user session.")
+ (license (list license:gpl2+ license:lgpl2.0+))))
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 6/7] gnu: Add marco.
2016-02-19 20:06 [PATCH 1/7] gnu: Add mate-polkit Fabian Harfert
` (3 preceding siblings ...)
2016-02-19 20:06 ` [PATCH 5/7] gnu: Add mate-session-manager Fabian Harfert
@ 2016-02-19 20:06 ` Fabian Harfert
2016-02-19 20:06 ` [PATCH 7/7] gnu: Add mate-panel Fabian Harfert
2016-02-20 13:41 ` [PATCH 1/7] gnu: Add mate-polkit Andreas Enge
6 siblings, 0 replies; 11+ messages in thread
From: Fabian Harfert @ 2016-02-19 20:06 UTC (permalink / raw)
To: guix-devel
* gnu/packages/mate.scm (marco): New variable.
---
gnu/packages/mate.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm
index 0ff8b95..de4ce21 100644
--- a/gnu/packages/mate.scm
+++ b/gnu/packages/mate.scm
@@ -382,3 +382,45 @@ for example keyboard, mouse or theming.")
manager. It will load all necessary applications for a full-featured
MATE desktop environment user session.")
(license (list license:gpl2+ license:lgpl2.0+))))
+
+(define-public marco
+ (package
+ (name "marco")
+ (version "1.12.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "http://pub.mate-desktop.org/releases/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "116hmm3cwkdg4qv7i9qccc747bqb3pb8igg5cd89w81ajlar2ybz"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("yelp-tools" ,yelp-tools)
+ ("intltool" ,intltool)
+ ("pkg-config" ,pkg-config)
+ ("glib:bin" ,glib "bin")))
+ (inputs
+ `(("pango" ,pango)
+ ("libxft" ,libxft)
+ ("libxcomposite" ,libxcomposite)
+ ("libxdamage" ,libxdamage)
+ ("gdk-pixbuf" ,gdk-pixbuf)
+ ("gtk+" ,gtk+-2)
+ ("libcanberra-gtk2" ,libcanberra/gtk+-2)
+ ("libgtop" ,libgtop)
+ ("libice" ,libice)
+ ("libsm" ,libsm)
+ ("libxt" ,libxt)
+ ("mate-desktop" ,mate-desktop)
+ ("startup-notification" ,startup-notification)
+ ("zenity" ,zenity)))
+ (propagated-inputs
+ `(("gtk+" ,gtk+-2)))
+ (home-page "http://mate-desktop.org/")
+ (synopsis "Window manager for the MATE desktop")
+ (description
+ "Marco is a simple Gtk+ based window manager used in the MATE desktop
+environment.")
+ (license (list license:gpl2+ license:lgpl2.0+))))
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 7/7] gnu: Add mate-panel.
2016-02-19 20:06 [PATCH 1/7] gnu: Add mate-polkit Fabian Harfert
` (4 preceding siblings ...)
2016-02-19 20:06 ` [PATCH 6/7] gnu: Add marco Fabian Harfert
@ 2016-02-19 20:06 ` Fabian Harfert
2016-02-20 13:41 ` [PATCH 1/7] gnu: Add mate-polkit Andreas Enge
6 siblings, 0 replies; 11+ messages in thread
From: Fabian Harfert @ 2016-02-19 20:06 UTC (permalink / raw)
To: guix-devel
* gnu/packages/mate.scm (mate-panel): New variable.
---
gnu/packages/mate.scm | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 58 insertions(+)
diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm
index de4ce21..d61cea9 100644
--- a/gnu/packages/mate.scm
+++ b/gnu/packages/mate.scm
@@ -424,3 +424,61 @@ MATE desktop environment user session.")
"Marco is a simple Gtk+ based window manager used in the MATE desktop
environment.")
(license (list license:gpl2+ license:lgpl2.0+))))
+
+(define-public mate-panel
+ (package
+ (name "mate-panel")
+ (version "1.12.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "http://pub.mate-desktop.org/releases/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0i79k9apah79b53jmmk42cgq2a0qv6vwdl7pb1mhdznn0y7hg40d"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'fix-introspection-install-dir
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out")))
+ (substitute* '("configure")
+ (("`\\$PKG_CONFIG --variable=girdir gobject-introspection-1.0`")
+ (string-append out "\"/share/gir-1.0/\""))
+ (("\\$\\(\\$PKG_CONFIG --variable=typelibdir gobject-introspection-1.0\\)")
+ (string-append out "/lib/girepository-1.0/")))))))))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("intltool" ,intltool)
+ ("gobject-introspection" ,gobject-introspection)
+ ("yelp-tools" ,yelp-tools)
+ ("glib:bin" ,glib "bin")))
+ (inputs
+ `(("dbus-glib" ,dbus-glib)
+ ("dconf" ,dconf)
+ ("libwnck" ,libwnck-1)
+ ("libcanberra-gtk2" ,libcanberra/gtk+-2)
+ ("libice" ,libice)
+ ("libmateweather" ,libmateweather)
+ ("libsm" ,libsm)
+ ("libsoup" ,libsoup)
+ ("libxau" ,libxau)
+ ("libxrandr" ,libxrandr)
+ ("libxi" ,libxi)
+ ("mate-menus" ,mate-menus)
+ ("mate-desktop" ,mate-desktop)
+ ("python" ,python-2)))
+ (propagated-inputs
+ `(("gtk+" ,gtk+-2)))
+ (home-page "https://mate-desktop.org/")
+ (synopsis "Launcher and docking facility for MATE")
+ (description
+ " The MATE Panel is an essential part of the MATE Desktop, providing
+toolbar-like panels which can be attached to the sides of your desktop. They
+are used to launch applications and embed a number of other functions, such as
+quick launch icons, the clock, the notification area, volume controls and the
+battery charge indicator, and utilities ranging from weather forecast to system
+monitoring.")
+ (license (list license:gpl2+ license:lgpl2.0+ license:fdl1.1+))))
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 1/7] gnu: Add mate-polkit.
2016-02-19 20:06 [PATCH 1/7] gnu: Add mate-polkit Fabian Harfert
` (5 preceding siblings ...)
2016-02-19 20:06 ` [PATCH 7/7] gnu: Add mate-panel Fabian Harfert
@ 2016-02-20 13:41 ` Andreas Enge
2016-02-20 17:17 ` Fabian Harfert
2016-02-20 17:30 ` Leo Famulari
6 siblings, 2 replies; 11+ messages in thread
From: Andreas Enge @ 2016-02-20 13:41 UTC (permalink / raw)
To: Fabian Harfert; +Cc: guix-devel
Hello,
before considering more mate packages, I would like to get back to discussing
the existing ones; as I am not knowledgeable about desktop packages, I must
admit I did not look at them too closely before. So maybe my comments can
also be disregarded, but it would be good if someone more expert could
chime in.
First of all, the build system. Since usually there are inputs glib and gtk+,
would it not be more appropriate to use glib-or-gtk-build-system?
Second, there are lots of propagated inputs. Are these really needed?
It is a bit strange that a library like libmateweather should need such a
propagation; normally our runpath magic should have rewritten all references
to input libraries.
If propagations are necessary, the reason should be added as a comment, for
instance as for gnome-desktop:
(propagated-inputs
;; Required by gnome-desktop-3.0.pc.
`(("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
("gtk+" ,gtk+)))
The .pc file of libmateweather indeed has the following lines:
Requires: glib-2.0 gobject-2.0 gdk-pixbuf-2.0 gtk+-2.0 gio-2.0
Requires.private: libxml-2.0 libsoup-2.4
Also, weather.h contains
#include <gdk-pixbuf/gdk-pixbuf.h>
So it looks as if propagation is needed here.
What do you think?
Andreas
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 1/7] gnu: Add mate-polkit.
2016-02-20 13:41 ` [PATCH 1/7] gnu: Add mate-polkit Andreas Enge
@ 2016-02-20 17:17 ` Fabian Harfert
2016-02-21 15:26 ` Andreas Enge
2016-02-20 17:30 ` Leo Famulari
1 sibling, 1 reply; 11+ messages in thread
From: Fabian Harfert @ 2016-02-20 17:17 UTC (permalink / raw)
To: guix-devel
Hello,
thanks for your reply.
On Sat, 20 Feb 2016 14:41:17 +0100
Andreas Enge <andreas@enge.fr> wrote:
> Hello,
>
> before considering more mate packages, I would like to get back to
> discussing the existing ones; as I am not knowledgeable about desktop
> packages, I must admit I did not look at them too closely before. So
> maybe my comments can also be disregarded, but it would be good if
> someone more expert could chime in.
>
> First of all, the build system. Since usually there are inputs glib
> and gtk+, would it not be more appropriate to use
> glib-or-gtk-build-system?
I thought, as the normal GNU build system is used here, I'll use that.
But reading the documentation again, I've found out, that what you
mentioned is a good idea. I'll change this.
> Second, there are lots of propagated inputs. Are these really needed?
I carefully checked all the library source dependencies and so on. I
think all these propagated inputs are needed.
> It is a bit strange that a library like libmateweather should need
> such a propagation; normally our runpath magic should have rewritten
> all references to input libraries.
>
> If propagations are necessary, the reason should be added as a
> comment, for instance as for gnome-desktop:
> (propagated-inputs
> ;; Required by gnome-desktop-3.0.pc.
> `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
> ("gtk+" ,gtk+)))
If that is necessary, I'll add these comments, but I think it's not too
difficult to look into the .pc files. Some of the packages have
comments, but the most don't.
> The .pc file of libmateweather indeed has the following lines:
> Requires: glib-2.0 gobject-2.0 gdk-pixbuf-2.0 gtk+-2.0 gio-2.0
> Requires.private: libxml-2.0 libsoup-2.4
> Also, weather.h contains
> #include <gdk-pixbuf/gdk-pixbuf.h>
> So it looks as if propagation is needed here.
I also saw that, but I thought, if the .pc file isn't referring to
something, it doesn't make sense to add it, because pkg-config
won't add the necessary compiler flags and libraries, so that gcc isn't
finding it.
But actually I don't really know. I'll recheck all the .pc files and
headers (not too much).
>
> What do you think?
>
> Andreas
>
In general I think you should wait until I've ready the rest of MATE
(caja, mate-control-center and stuff like documentation or wallpapers),
so that it can be tested by me first. The patches I've sent were more
for corrections and review.
So thanks for the hints!
Fabian
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 1/7] gnu: Add mate-polkit.
2016-02-20 17:17 ` Fabian Harfert
@ 2016-02-21 15:26 ` Andreas Enge
0 siblings, 0 replies; 11+ messages in thread
From: Andreas Enge @ 2016-02-21 15:26 UTC (permalink / raw)
To: Fabian Harfert; +Cc: guix-devel
Hello,
On Sat, Feb 20, 2016 at 06:17:28PM +0100, Fabian Harfert wrote:
> I carefully checked all the library source dependencies and so on. I
> think all these propagated inputs are needed.
okay, excellent.
> If that is necessary, I'll add these comments, but I think it's not too
> difficult to look into the .pc files. Some of the packages have
> comments, but the most don't.
Well, it would be useful in the future, as some kind of proof that you had
a look at it, and also to keep track if people wonder why it has been
done like this. If there is a change in the future and something is not
needed any more, this would then become clear simply by looking at the
referenced .pc file.
> But actually I don't really know. I'll recheck all the .pc files and
> headers (not too much).
I think there is no need to check the headers; the example I gave was
already treated correctly. If a header is needed, most of the time the
library will also be mentioned in the .pc file.
I will let you have a look at the glib-or-gtk-build-system question,
and give us notice again when the next patches are ready. On the other
hand, if there are mistakes, that would not be a big problem; when you
notice in the end that something does not work, it will still be time
to add (propagated or other) inputs.
Thanks for all this work!
Andreas
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/7] gnu: Add mate-polkit.
2016-02-20 13:41 ` [PATCH 1/7] gnu: Add mate-polkit Andreas Enge
2016-02-20 17:17 ` Fabian Harfert
@ 2016-02-20 17:30 ` Leo Famulari
1 sibling, 0 replies; 11+ messages in thread
From: Leo Famulari @ 2016-02-20 17:30 UTC (permalink / raw)
To: Andreas Enge; +Cc: guix-devel
On Sat, Feb 20, 2016 at 02:41:17PM +0100, Andreas Enge wrote:
> Hello,
>
> before considering more mate packages, I would like to get back to discussing
> the existing ones; as I am not knowledgeable about desktop packages, I must
> admit I did not look at them too closely before. So maybe my comments can
> also be disregarded, but it would be good if someone more expert could
> chime in.
I feel similarly about all these desktop packages. It would be very
useful if submitters could include some kind of minimal example of a
system declaration that would demonstrate the DE.
>
> First of all, the build system. Since usually there are inputs glib and gtk+,
> would it not be more appropriate to use glib-or-gtk-build-system?
>
> Second, there are lots of propagated inputs. Are these really needed?
> It is a bit strange that a library like libmateweather should need such a
> propagation; normally our runpath magic should have rewritten all references
> to input libraries.
>
> If propagations are necessary, the reason should be added as a comment, for
> instance as for gnome-desktop:
> (propagated-inputs
> ;; Required by gnome-desktop-3.0.pc.
> `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
> ("gtk+" ,gtk+)))
> The .pc file of libmateweather indeed has the following lines:
> Requires: glib-2.0 gobject-2.0 gdk-pixbuf-2.0 gtk+-2.0 gio-2.0
> Requires.private: libxml-2.0 libsoup-2.4
> Also, weather.h contains
> #include <gdk-pixbuf/gdk-pixbuf.h>
> So it looks as if propagation is needed here.
>
> What do you think?
>
> Andreas
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread