From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH 1/7] gnu: Add mate-polkit. Date: Sat, 20 Feb 2016 14:41:17 +0100 Message-ID: <20160220134117.GA6934@solar> References: <1455912381-25148-1-git-send-email-fhmgufs@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aX7mp-0007W9-7b for guix-devel@gnu.org; Sat, 20 Feb 2016 08:41:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aX7mk-0005ie-4o for guix-devel@gnu.org; Sat, 20 Feb 2016 08:41:27 -0500 Received: from mailrelay7.public.one.com ([91.198.169.215]:53035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aX7mj-0005iK-Oe for guix-devel@gnu.org; Sat, 20 Feb 2016 08:41:22 -0500 Content-Disposition: inline In-Reply-To: <1455912381-25148-1-git-send-email-fhmgufs@web.de> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Fabian Harfert Cc: guix-devel@gnu.org Hello, before considering more mate packages, I would like to get back to discussing the existing ones; as I am not knowledgeable about desktop packages, I must admit I did not look at them too closely before. So maybe my comments can also be disregarded, but it would be good if someone more expert could chime in. First of all, the build system. Since usually there are inputs glib and gtk+, would it not be more appropriate to use glib-or-gtk-build-system? Second, there are lots of propagated inputs. Are these really needed? It is a bit strange that a library like libmateweather should need such a propagation; normally our runpath magic should have rewritten all references to input libraries. If propagations are necessary, the reason should be added as a comment, for instance as for gnome-desktop: (propagated-inputs ;; Required by gnome-desktop-3.0.pc. `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas) ("gtk+" ,gtk+))) The .pc file of libmateweather indeed has the following lines: Requires: glib-2.0 gobject-2.0 gdk-pixbuf-2.0 gtk+-2.0 gio-2.0 Requires.private: libxml-2.0 libsoup-2.4 Also, weather.h contains #include So it looks as if propagation is needed here. What do you think? Andreas