Re: [PATCH 1/7] gnu: Add mate-polkit.

[Andreas Enge <andreas@enge.fr>]

Hello,

before considering more mate packages, I would like to get back to discussing
the existing ones; as I am not knowledgeable about desktop packages, I must
admit I did not look at them too closely before. So maybe my comments can
also be disregarded, but it would be good if someone more expert could
chime in.

First of all, the build system. Since usually there are inputs glib and gtk+,
would it not be more appropriate to use glib-or-gtk-build-system?

Second, there are lots of propagated inputs. Are these really needed?
It is a bit strange that a library like libmateweather should need such a
propagation; normally our runpath magic should have rewritten all references
to input libraries.

If propagations are necessary, the reason should be added as a comment, for
instance as for gnome-desktop:
    (propagated-inputs
     ;; Required by gnome-desktop-3.0.pc.
     `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
       ("gtk+" ,gtk+)))
The .pc file of libmateweather indeed has the following lines:
   Requires: glib-2.0 gobject-2.0 gdk-pixbuf-2.0 gtk+-2.0 gio-2.0
   Requires.private: libxml-2.0 libsoup-2.4
Also, weather.h contains
   #include <gdk-pixbuf/gdk-pixbuf.h>
So it looks as if propagation is needed here.

What do you think?

Andreas