From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 3/3] gnu: Add paprefs Date: Sat, 20 Feb 2016 00:39:31 -0500 Message-ID: <20160220053931.GC10772@jasmine> References: <1455721361-14591-1-git-send-email-mail@cbaines.net> <1455721361-14591-4-git-send-email-mail@cbaines.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aX0Ga-0006Tg-CL for guix-devel@gnu.org; Sat, 20 Feb 2016 00:39:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aX0GW-0007qr-B1 for guix-devel@gnu.org; Sat, 20 Feb 2016 00:39:40 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:42643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aX0GW-0007qn-70 for guix-devel@gnu.org; Sat, 20 Feb 2016 00:39:36 -0500 Content-Disposition: inline In-Reply-To: <1455721361-14591-4-git-send-email-mail@cbaines.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Christopher Baines Cc: guix-devel@gnu.org On Wed, Feb 17, 2016 at 03:02:41PM +0000, Christopher Baines wrote: > * gnu/packages/pulseaudio.scm (paprefs): New variable Cool, thanks for the patches! This review is rather superficial since I don't have a GuixSD desktop system, so I can't really test the functionality of the software provided by this patch series. I assume it works for you. Did you test it on GuixSD or on a foreign distro? > --- > gnu/packages/pulseaudio.scm | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) [...] > +(define-public paprefs > + (package > + (name "paprefs") > + (version "0.9.10") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://freedesktop.org/software/pulseaudio/paprefs/paprefs-" > + version > + ".tar.xz")) I'd prefer if the URL started directly after string-append, and then used the minimum number of lines, while staying within the 80 character limit. I can correct this sort of thing when applying patches, but I must say it out loud once in a while ;) > + (sha256 > + (base32 > + "1c5b3sb881szavly220q31g7rvpn94wr7ywlk00hqb9zaikml716")))) > + (build-system gnu-build-system) > + (arguments > + '(#:configure-flags '("CXXFLAGS=-std=c++11"))) ; required by gtkmm > + (inputs > + `(("pulseaudio" ,pulseaudio) > + ("gconfmm" ,gconfmm) > + ("lynx" ,lynx) ; used for documentation generation If it's only used to generate the docs, can we make it a native-input, so it's only available while building? > + ("libglademm" ,libglademm) > + ("dbus-glib" ,dbus-glib))) > + (native-inputs > + `(("intltool" ,intltool) > + ("pkg-config" ,pkg-config))) > + (home-page "https://freedesktop.org/software/pulseaudio/paprefs/") > + (synopsis "simple configuration dialog for PulseAudio") The linter whines that the synopsis does not start with a capital letter. What, you don't like the linter? ;) > + (description > + "PulseAudio Preferences (paprefs) is a simple GTK+ based configuration > +dialog for the PulseAudio sound server.") > + (license l:gpl2+))) > -- > 2.7.0 > >