[PATCH] Add paprefs and dependencies

[PATCH] Add paprefs and dependencies

[Christopher Baines]

I have used paprefs on Debian for a while to get network audio setup, I have
not got a similar setup working yet on GuixSD, but it seems like a good start
would be to get paprefs in to Guix.

[PATCH 1/3] gnu: Add gconfmm.

[Christopher Baines]

* gnu/packages/gnome.scm (gconfmm): New variable.
---
 gnu/packages/gnome.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 49e6197..d04bc4a 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1068,6 +1068,35 @@ is intended for user preferences; not arbitrary data storage.")
     (license license:lgpl2.0+)))
 
 
+(define-public gconfmm
+  (package
+    (name "gconfmm")
+    (version "2.28.3")
+    (source (origin
+              (method url-fetch)
+              (uri
+               (let ((upstream-name "gconfmm"))
+                 (string-append "mirror://gnome/sources/" upstream-name "/"
+                                (version-major+minor version) "/"
+                                upstream-name "-" version ".tar.xz")))
+              (sha256
+               (base32 "0a4jq0j2w03m4waq56b9c1798bd5xjh2kys7jlr8ayx8q4ljvgfp"))))
+    (build-system gnu-build-system)
+    (propagated-inputs `(("gconf" ,gconf)))
+    (arguments
+     '(#:configure-flags '("CXXFLAGS=-std=c++11")))
+    (native-inputs
+     `(("intltool" ,intltool)
+       ("pkg-config" ,pkg-config)
+       ("glib" ,glib)
+       ("glibmm" ,glibmm)))
+    (home-page "http://www.gtkmm.org/")
+    (synopsis "C++ interface for the GConf client API")
+    (description "gconfmm is the official C++ interface for the GConf client
+API for storing and retrieving configuration data.")
+    (license license:lgpl2.0+)))
+
+
 (define-public gnome-mime-data
   (package
     (name "gnome-mime-data")
-- 
2.7.0

Re: [PATCH 1/3] gnu: Add gconfmm.

[Leo Famulari]

On Wed, Feb 17, 2016 at 03:02:39PM +0000, Christopher Baines wrote:
> * gnu/packages/gnome.scm (gconfmm): New variable.
> ---
>  gnu/packages/gnome.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 49e6197..d04bc4a 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -1068,6 +1068,35 @@ is intended for user preferences; not arbitrary data storage.")
>      (license license:lgpl2.0+)))
>  
>  
> +(define-public gconfmm
> +  (package
> +    (name "gconfmm")
> +    (version "2.28.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri
> +               (let ((upstream-name "gconfmm"))
> +                 (string-append "mirror://gnome/sources/" upstream-name "/"
> +                                (version-major+minor version) "/"
> +                                upstream-name "-" version ".tar.xz")))
> +              (sha256
> +               (base32 "0a4jq0j2w03m4waq56b9c1798bd5xjh2kys7jlr8ayx8q4ljvgfp"))))

This line is too long. The hash can drop one line, indented. I can do
this when pushing.

> +    (build-system gnu-build-system)
> +    (propagated-inputs `(("gconf" ,gconf)))

Does this need to be propagated (installed in the user's profile)? Can't
gconfmm link to it, as an input?

> +    (arguments
> +     '(#:configure-flags '("CXXFLAGS=-std=c++11")))
> +    (native-inputs
> +     `(("intltool" ,intltool)
> +       ("pkg-config" ,pkg-config)
> +       ("glib" ,glib)
> +       ("glibmm" ,glibmm)))
> +    (home-page "http://www.gtkmm.org/")
> +    (synopsis "C++ interface for the GConf client API")
> +    (description "gconfmm is the official C++ interface for the GConf client
> +API for storing and retrieving configuration data.")
> +    (license license:lgpl2.0+)))
> +
> +
>  (define-public gnome-mime-data
>    (package
>      (name "gnome-mime-data")
> -- 
> 2.7.0
> 
> 

Re: [PATCH 1/3] gnu: Add gconfmm.

[Alex Kost]

Christopher Baines (2016-02-17 18:02 +0300) wrote:

[...]
> +(define-public gconfmm
> +  (package
> +    (name "gconfmm")
> +    (version "2.28.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri
> +               (let ((upstream-name "gconfmm"))
> +                 (string-append "mirror://gnome/sources/" upstream-name "/"
> +                                (version-major+minor version) "/"
> +                                upstream-name "-" version ".tar.xz")))

I don't see a need in this 'upstream-name' variable since it is the same
as the package name.

-- 
Alex

[PATCH 2/3] gnu: Add libglademm

[Christopher Baines]

* gnu/packages/gnome.scm (libglademm): New variable.
---
 gnu/packages/gnome.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d04bc4a..2388e5c 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1347,6 +1347,33 @@ graphical interfaces described in glade files and for accessing the
 widgets built in the loading process.")
     (license license:gpl2+))) ; This is correct.  GPL not LGPL
 
+(define-public libglademm
+  (package
+    (name "libglademm")
+    (version "2.6.7")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://gnome/sources/" name "/"
+                                  (version-major+minor version)  "/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "1hrbg9l5qb7w0xvr7013qamkckyj0fqc426c851l69zpmhakqm1q"))))
+    (build-system gnu-build-system)
+    (propagated-inputs
+     `(("gtkmm-2" ,gtkmm-2)
+       ("libglade" ,libglade))) ; required by libglade-2.0.pc
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (arguments
+     '(#:configure-flags '("CXXFLAGS=-std=c++11")))
+    (home-page "http://www.gtkmm.org/")
+    (synopsis "C++ wrappers for libglade2")
+    (description "libglademm is the C++ wrapper for libglade, a library for
+ building graphical interfaces. New code should use GtkBuilder (part of Gtk 3),
+ or its C++ wrapper in gtkmm.")
+    (license license:lgpl2.1+)))
+
 (define-public libgnomeprint
   ;; This library has been deprecated since 2006; see
   ;; <https://mail.gnome.org/archives/devel-announce-list/2006-August/msg00005.html>.
-- 
2.7.0

Re: [PATCH 2/3] gnu: Add libglademm

[Leo Famulari]

On Wed, Feb 17, 2016 at 03:02:40PM +0000, Christopher Baines wrote:
> * gnu/packages/gnome.scm (libglademm): New variable.
> ---
>  gnu/packages/gnome.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index d04bc4a..2388e5c 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -1347,6 +1347,33 @@ graphical interfaces described in glade files and for accessing the
>  widgets built in the loading process.")
>      (license license:gpl2+))) ; This is correct.  GPL not LGPL
>  
> +(define-public libglademm
> +  (package
> +    (name "libglademm")
> +    (version "2.6.7")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnome/sources/" name "/"
> +                                  (version-major+minor version)  "/"
> +                                  name "-" version ".tar.bz2"))
> +              (sha256
> +               (base32
> +                "1hrbg9l5qb7w0xvr7013qamkckyj0fqc426c851l69zpmhakqm1q"))))
> +    (build-system gnu-build-system)
> +    (propagated-inputs
> +     `(("gtkmm-2" ,gtkmm-2)
> +       ("libglade" ,libglade))) ; required by libglade-2.0.pc

Do these need to be propagated?

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (arguments
> +     '(#:configure-flags '("CXXFLAGS=-std=c++11")))
> +    (home-page "http://www.gtkmm.org/")
> +    (synopsis "C++ wrappers for libglade2")
> +    (description "libglademm is the C++ wrapper for libglade, a library for
> + building graphical interfaces. New code should use GtkBuilder (part of Gtk 3),
> + or its C++ wrapper in gtkmm.")
> +    (license license:lgpl2.1+)))
> +
>  (define-public libgnomeprint
>    ;; This library has been deprecated since 2006; see
>    ;; <https://mail.gnome.org/archives/devel-announce-list/2006-August/msg00005.html>.
> -- 
> 2.7.0
> 
> 

Re: [PATCH 2/3] gnu: Add libglademm

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> On Wed, Feb 17, 2016 at 03:02:40PM +0000, Christopher Baines wrote:
>> * gnu/packages/gnome.scm (libglademm): New variable.

[...]

>> +    (propagated-inputs
>> +     `(("gtkmm-2" ,gtkmm-2)
>> +       ("libglade" ,libglade))) ; required by libglade-2.0.pc
>
> Do these need to be propagated?

To complement: propagated inputs are usually considered a last resort
because they clutter user profiles, so uses of ‘propagated-inputs’ must
be justified in a comment.

Ludo’.

[PATCH 3/3] gnu: Add paprefs

[Christopher Baines]

* gnu/packages/pulseaudio.scm (paprefs): New variable
---
 gnu/packages/pulseaudio.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/pulseaudio.scm b/gnu/packages/pulseaudio.scm
index fe976a9..9e807a8 100644
--- a/gnu/packages/pulseaudio.scm
+++ b/gnu/packages/pulseaudio.scm
@@ -30,6 +30,8 @@
   #:use-module (gnu packages databases)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gtk)
+  #:use-module (gnu packages lynx)
+  #:use-module (gnu packages gnome)
   #:use-module (gnu packages libcanberra)
   #:use-module (gnu packages web)
   #:use-module (gnu packages linux)
@@ -221,3 +223,35 @@ sound server.")
 graphical user interface to connect to a PulseAudio server and
 easily control the volume of all clients, sinks, etc.")
     (license l:gpl2+)))
+
+(define-public paprefs
+  (package
+    (name "paprefs")
+    (version "0.9.10")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append
+                   "https://freedesktop.org/software/pulseaudio/paprefs/paprefs-"
+                   version
+                   ".tar.xz"))
+             (sha256
+              (base32
+               "1c5b3sb881szavly220q31g7rvpn94wr7ywlk00hqb9zaikml716"))))
+    (build-system gnu-build-system)
+    (arguments
+      '(#:configure-flags '("CXXFLAGS=-std=c++11"))) ; required by gtkmm
+    (inputs
+     `(("pulseaudio" ,pulseaudio)
+       ("gconfmm" ,gconfmm)
+       ("lynx" ,lynx) ; used for documentation generation
+       ("libglademm" ,libglademm)
+       ("dbus-glib" ,dbus-glib)))
+    (native-inputs
+     `(("intltool" ,intltool)
+       ("pkg-config" ,pkg-config)))
+    (home-page "https://freedesktop.org/software/pulseaudio/paprefs/")
+    (synopsis "simple configuration dialog for PulseAudio")
+    (description
+     "PulseAudio Preferences (paprefs) is a simple GTK+ based configuration
+dialog for the PulseAudio sound server.")
+    (license l:gpl2+)))
-- 
2.7.0

Re: [PATCH 3/3] gnu: Add paprefs

[Leo Famulari]

On Wed, Feb 17, 2016 at 03:02:41PM +0000, Christopher Baines wrote:
> * gnu/packages/pulseaudio.scm (paprefs): New variable

Cool, thanks for the patches! This review is rather superficial since I
don't have a GuixSD desktop system, so I can't really test the
functionality of the software provided by this patch series. I assume it
works for you. Did you test it on GuixSD or on a foreign distro?

> ---
>  gnu/packages/pulseaudio.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)

[...]

> +(define-public paprefs
> +  (package
> +    (name "paprefs")
> +    (version "0.9.10")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "https://freedesktop.org/software/pulseaudio/paprefs/paprefs-"
> +                   version
> +                   ".tar.xz"))

I'd prefer if the URL started directly after string-append, and then
used the minimum number of lines, while staying within the 80 character
limit. I can correct this sort of thing when applying patches, but I
must say it out loud once in a while ;)

> +             (sha256
> +              (base32
> +               "1c5b3sb881szavly220q31g7rvpn94wr7ywlk00hqb9zaikml716"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +      '(#:configure-flags '("CXXFLAGS=-std=c++11"))) ; required by gtkmm
> +    (inputs
> +     `(("pulseaudio" ,pulseaudio)
> +       ("gconfmm" ,gconfmm)
> +       ("lynx" ,lynx) ; used for documentation generation

If it's only used to generate the docs, can we make it a native-input,
so it's only available while building?

> +       ("libglademm" ,libglademm)
> +       ("dbus-glib" ,dbus-glib)))
> +    (native-inputs
> +     `(("intltool" ,intltool)
> +       ("pkg-config" ,pkg-config)))
> +    (home-page "https://freedesktop.org/software/pulseaudio/paprefs/")
> +    (synopsis "simple configuration dialog for PulseAudio")

The linter whines that the synopsis does not start with a capital
letter. What, you don't like the linter? ;)

> +    (description
> +     "PulseAudio Preferences (paprefs) is a simple GTK+ based configuration
> +dialog for the PulseAudio sound server.")
> +    (license l:gpl2+)))
> -- 
> 2.7.0
> 
> 

Re: [PATCH 3/3] gnu: Add paprefs

[ng0]

I found neither paprefs nor gconfmm in our package database as I was
about to move this to my 'done' tag, out of sight.
Can someone (Christopher? Leo?) finish this?

Thanks.
Leo Famulari <leo@famulari.name> writes:

> On Wed, Feb 17, 2016 at 03:02:41PM +0000, Christopher Baines wrote:
>> * gnu/packages/pulseaudio.scm (paprefs): New variable
>
> Cool, thanks for the patches! This review is rather superficial since I
> don't have a GuixSD desktop system, so I can't really test the
> functionality of the software provided by this patch series. I assume it
> works for you. Did you test it on GuixSD or on a foreign distro?
>
>> ---
>>  gnu/packages/pulseaudio.scm | 34 ++++++++++++++++++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>
> [...]
>
>> +(define-public paprefs
>> +  (package
>> +    (name "paprefs")
>> +    (version "0.9.10")
>> +    (source (origin
>> +             (method url-fetch)
>> +             (uri (string-append
>> +                   "https://freedesktop.org/software/pulseaudio/paprefs/paprefs-"
>> +                   version
>> +                   ".tar.xz"))
>
> I'd prefer if the URL started directly after string-append, and then
> used the minimum number of lines, while staying within the 80 character
> limit. I can correct this sort of thing when applying patches, but I
> must say it out loud once in a while ;)
>
>> +             (sha256
>> +              (base32
>> +               "1c5b3sb881szavly220q31g7rvpn94wr7ywlk00hqb9zaikml716"))))
>> +    (build-system gnu-build-system)
>> +    (arguments
>> +      '(#:configure-flags '("CXXFLAGS=-std=c++11"))) ; required by gtkmm
>> +    (inputs
>> +     `(("pulseaudio" ,pulseaudio)
>> +       ("gconfmm" ,gconfmm)
>> +       ("lynx" ,lynx) ; used for documentation generation
>
> If it's only used to generate the docs, can we make it a native-input,
> so it's only available while building?
>
>> +       ("libglademm" ,libglademm)
>> +       ("dbus-glib" ,dbus-glib)))
>> +    (native-inputs
>> +     `(("intltool" ,intltool)
>> +       ("pkg-config" ,pkg-config)))
>> +    (home-page "https://freedesktop.org/software/pulseaudio/paprefs/")
>> +    (synopsis "simple configuration dialog for PulseAudio")
>
> The linter whines that the synopsis does not start with a capital
> letter. What, you don't like the linter? ;)
>
>> +    (description
>> +     "PulseAudio Preferences (paprefs) is a simple GTK+ based configuration
>> +dialog for the PulseAudio sound server.")
>> +    (license l:gpl2+)))
>> -- 
>> 2.7.0
>> 
>> 
>

-- 
              ng0

Re: [PATCH 3/3] gnu: Add paprefs

[ng0]

ng0 <niasterisk@grrlz.net> writes:

> I found neither paprefs nor gconfmm in our package database as I was
> about to move this to my 'done' tag, out of sight.
> Can someone (Christopher? Leo?) finish this?

As I got no reply after my initial question, I will fix both of
these packages up next month.

> Thanks.
> Leo Famulari <leo@famulari.name> writes:
>
>> On Wed, Feb 17, 2016 at 03:02:41PM +0000, Christopher Baines wrote:
>>> * gnu/packages/pulseaudio.scm (paprefs): New variable
>>
>> Cool, thanks for the patches! This review is rather superficial since I
>> don't have a GuixSD desktop system, so I can't really test the
>> functionality of the software provided by this patch series. I assume it
>> works for you. Did you test it on GuixSD or on a foreign distro?
>>
>>> ---
>>>  gnu/packages/pulseaudio.scm | 34 ++++++++++++++++++++++++++++++++++
>>>  1 file changed, 34 insertions(+)
>>
>> [...]
>>
>>> +(define-public paprefs
>>> +  (package
>>> +    (name "paprefs")
>>> +    (version "0.9.10")
>>> +    (source (origin
>>> +             (method url-fetch)
>>> +             (uri (string-append
>>> +                   "https://freedesktop.org/software/pulseaudio/paprefs/paprefs-"
>>> +                   version
>>> +                   ".tar.xz"))
>>
>> I'd prefer if the URL started directly after string-append, and then
>> used the minimum number of lines, while staying within the 80 character
>> limit. I can correct this sort of thing when applying patches, but I
>> must say it out loud once in a while ;)
>>
>>> +             (sha256
>>> +              (base32
>>> +               "1c5b3sb881szavly220q31g7rvpn94wr7ywlk00hqb9zaikml716"))))
>>> +    (build-system gnu-build-system)
>>> +    (arguments
>>> +      '(#:configure-flags '("CXXFLAGS=-std=c++11"))) ; required by gtkmm
>>> +    (inputs
>>> +     `(("pulseaudio" ,pulseaudio)
>>> +       ("gconfmm" ,gconfmm)
>>> +       ("lynx" ,lynx) ; used for documentation generation
>>
>> If it's only used to generate the docs, can we make it a native-input,
>> so it's only available while building?
>>
>>> +       ("libglademm" ,libglademm)
>>> +       ("dbus-glib" ,dbus-glib)))
>>> +    (native-inputs
>>> +     `(("intltool" ,intltool)
>>> +       ("pkg-config" ,pkg-config)))
>>> +    (home-page "https://freedesktop.org/software/pulseaudio/paprefs/")
>>> +    (synopsis "simple configuration dialog for PulseAudio")
>>
>> The linter whines that the synopsis does not start with a capital
>> letter. What, you don't like the linter? ;)
>>
>>> +    (description
>>> +     "PulseAudio Preferences (paprefs) is a simple GTK+ based configuration
>>> +dialog for the PulseAudio sound server.")
>>> +    (license l:gpl2+)))
>>> -- 
>>> 2.7.0
>>> 
>>> 
>>
>
> -- 
>               ng0
>
>

-- 
♥Ⓐ  ng0  | PGP keys and more: https://n0is.noblogs.org/
         |                    http://ng0.chaosnet.org