From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/3] gnu: Add gconfmm.
Date: Sat, 20 Feb 2016 00:32:51 -0500
Message-ID: <20160220053251.GA10772@jasmine>
References: <1455721361-14591-1-git-send-email-mail@cbaines.net>
	<1455721361-14591-2-git-send-email-mail@cbaines.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56854)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aX0A7-0002oq-JK
	for guix-devel@gnu.org; Sat, 20 Feb 2016 00:33:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aX0A2-0006Rb-Hp
	for guix-devel@gnu.org; Sat, 20 Feb 2016 00:32:59 -0500
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54385)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aX0A2-0006RX-EF
	for guix-devel@gnu.org; Sat, 20 Feb 2016 00:32:54 -0500
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
	by mailout.nyi.internal (Postfix) with ESMTP id 496022036D
	for <guix-devel@gnu.org>; Sat, 20 Feb 2016 00:32:54 -0500 (EST)
Content-Disposition: inline
In-Reply-To: <1455721361-14591-2-git-send-email-mail@cbaines.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Christopher Baines <mail@cbaines.net>
Cc: guix-devel@gnu.org

On Wed, Feb 17, 2016 at 03:02:39PM +0000, Christopher Baines wrote:
> * gnu/packages/gnome.scm (gconfmm): New variable.
> ---
>  gnu/packages/gnome.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 49e6197..d04bc4a 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -1068,6 +1068,35 @@ is intended for user preferences; not arbitrary data storage.")
>      (license license:lgpl2.0+)))
>  
>  
> +(define-public gconfmm
> +  (package
> +    (name "gconfmm")
> +    (version "2.28.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri
> +               (let ((upstream-name "gconfmm"))
> +                 (string-append "mirror://gnome/sources/" upstream-name "/"
> +                                (version-major+minor version) "/"
> +                                upstream-name "-" version ".tar.xz")))
> +              (sha256
> +               (base32 "0a4jq0j2w03m4waq56b9c1798bd5xjh2kys7jlr8ayx8q4ljvgfp"))))

This line is too long. The hash can drop one line, indented. I can do
this when pushing.

> +    (build-system gnu-build-system)
> +    (propagated-inputs `(("gconf" ,gconf)))

Does this need to be propagated (installed in the user's profile)? Can't
gconfmm link to it, as an input?

> +    (arguments
> +     '(#:configure-flags '("CXXFLAGS=-std=c++11")))
> +    (native-inputs
> +     `(("intltool" ,intltool)
> +       ("pkg-config" ,pkg-config)
> +       ("glib" ,glib)
> +       ("glibmm" ,glibmm)))
> +    (home-page "http://www.gtkmm.org/")
> +    (synopsis "C++ interface for the GConf client API")
> +    (description "gconfmm is the official C++ interface for the GConf client
> +API for storing and retrieving configuration data.")
> +    (license license:lgpl2.0+)))
> +
> +
>  (define-public gnome-mime-data
>    (package
>      (name "gnome-mime-data")
> -- 
> 2.7.0
> 
>