From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: On the MediaGoblin dependency patch updates Date: Fri, 19 Feb 2016 23:58:46 -0500 Message-ID: <20160220045846.GE14995@jasmine> References: <87povxsgla.fsf@dustycloud.org> <20160216013418.GC3984@jasmine> <87wpq0m7b1.fsf@dustycloud.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWzd8-0004Ik-Cx for guix-devel@gnu.org; Fri, 19 Feb 2016 23:58:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWzd3-0006TU-Dn for guix-devel@gnu.org; Fri, 19 Feb 2016 23:58:54 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:35317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWzd3-0006TP-AQ for guix-devel@gnu.org; Fri, 19 Feb 2016 23:58:49 -0500 Content-Disposition: inline In-Reply-To: <87wpq0m7b1.fsf@dustycloud.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Christopher Allan Webber Cc: guix-devel@gnu.org On Fri, Feb 19, 2016 at 06:40:14PM -0800, Christopher Allan Webber wrote: > Leo Famulari writes: > > > On Mon, Feb 15, 2016 at 03:23:45PM -0800, Christopher Allan Webber wrote: > >> First in a series of towards-MediaGoblin patches. > > > > Awesome! > > > > I'm reviewing these on the assumption that you've tested they all build. > > I have, if I forgot to say that previously. > > > Are mock and nose required after build-time? If not, they should be > > native-inputs. > > > > As for markupsafe, the latest version of the manual has this to say > > about propagated-inputs: > > > > Another example where propagated-inputs is useful is for languages that > > lack a facility to record the run-time search path akin to ELF’s > > RUNPATH; this includes Guile, Python, Perl, GHC, and more. To ensure > > that libraries written in those languages can find library code they > > depend on at run time, run-time dependencies must be listed in > > propagated-inputs rather than inputs. > > > > I won't mention these potential issues in my reviews of the rest of the > > patches. > > I sent a whole new batch of patches for all these, and updated > wip-mediagoblin. The only one not updated was python-mako, which I > removed, since Dave got that into master anyway. It's all rebased, > and Leo's suggestions are all included (with the exception of one > comment where an indentation change was suggested, and I stuck with the > way emacs does it). That's fine — my sense of style isn't very strong and my tools are relatively poor compared to Emacs ;) > > So, unless there's any more feedback, the whole lot of these can be > merged into master, and then we can work on MediaGoblin itself. I've read them all and sent my comments. Any patches I didn't reply to LGTM. Thanks for doing this work! It's very exciting!