Re: [PATCH] fluxbox window manager

[Eric Bavier <ericbavier@openmailbox.org>]

On Thu, 18 Feb 2016 23:17:12 +0100
Danny Milosavljevic <dannym@scratchpost.org> wrote:

> Then a new file "gnu/packages/fluxbox.scm":

This new package should rather go in gnu/packages/wm.scm.

> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright © 2014 Julien Lepiller <julien@lepiller.eu>
> ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> ;;; GNU Guix is free software; you can redistribute it and/or modify it
> ;;; under the terms of the GNU General Public License as published by
> ;;; the Free Software Foundation; either version 3 of the License, or (at
> ;;; your option) any later version.
> ;;;
> ;;; GNU Guix is distributed in the hope that it will be useful, but
> ;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> ;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> ;;; GNU General Public License for more details.
> ;;;
> ;;; You should have received a copy of the GNU General Public License
> ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> 
> (define-module (gnu packages fluxbox)
>   #:use-module ((guix licenses) #:select (gpl2+))
>   #:use-module (guix packages)
>   #:use-module (guix download)
>   #:use-module (guix build-system gnu)
>   #:use-module (gnu packages image)
>   #:use-module (gnu packages fontutils)
>   #:use-module (gnu packages fribidi)
>   #:use-module (gnu packages pkg-config)
>   #:use-module (gnu packages xorg))
> 
> (define fluxbox.desktop
>   (origin
>     (method url-fetch)
>     (uri (string-append "http://pkgs.fedoraproject.org/cgit/rpms/fluxbox.git/plain/fluxbox-xsessions.desktop?id=5f2e758b9eb0223d1baff07a339bcb6e0fbf765d"))
>     (file-name "fluxbox.desktop")
>     (sha256
>       (base32
>        "116kf72w3p8jr9l1mxd5qvxwh2rl8c2szyy6cgka667y693m89cy"))))

This file download is trivial.  I think we should do something like
what's done for xmonad currently.  Namely, generating our own .desktop
file.  Please see that package.

> 
> (define-public fluxbox
>   (package
>     (name "fluxbox")
>     (version "1.3.7")
>     (source (origin
>               (method url-fetch)
>               (uri (string-append
>                     "mirror://sourceforge/fluxbox/" 
>                     version 
>                     "/fluxbox-" 
>                     version 
>                     ".tar.xz"))

Many of these lines could be merged together for better vertical
unity.  See examples in gnu/packages/wm.scm.

>               (sha256
>                (base32
>                 "1h1f70y40qd225dqx937vzb4k2cz219agm1zvnjxakn5jkz7b37w"))))
>     (build-system gnu-build-system)
>     (arguments 
>      '(#:phases
>        (modify-phases %standard-phases
>          (add-after 'install 'install-xsession
>                     (lambda* (#:key inputs outputs #:allow-other-keys)
>                       (let ((fbd "fluxbox.desktop")
>                             (dst (string-append (assoc-ref outputs "out")
>                                                 "/share/xsessions/")))
>                         (mkdir-p dst) 
>                         (copy-file (assoc-ref inputs fbd)
>                                    (string-append dst fbd))))))))
>     (native-inputs `(("pkg-config" ,pkg-config)
>                      ("fluxbox.desktop" ,fluxbox.desktop)))
>     (inputs `(("imlib2" ,imlib2)
>               ("libx11" ,libx11)
>               ("libxinerama" ,libxinerama)
>               ("libxrandr" ,libxrandr)
>               ("libxext" ,libxext)
>               ("libxrender" ,libxrender)
>               ("libxft" ,libxft)
>               ("freetype" ,freetype)
>               ("fribidi" ,fribidi)
>               ("libxpm"  ,libxpm)))
>     (synopsis "Window manager with tabs")
>     (description "Fluxbox is a window manager. 
> The *box visual style is well known for its minimalistic appearance.")
      ^
Is the '*' necessary here?

Could you send an updated patch?

Thanks,
`~Eric

>     (home-page "http://fluxbox.org/")
>     (license gpl2+))) ; FIXME
> 
> ;;; fluxbox.scm ends here
>