From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 4/4] gnu: python-enum34: Remove python-setuptools from
	inputs.
Date: Thu, 18 Feb 2016 13:13:22 -0500
Message-ID: <20160218181322.GB32505@jasmine>
References: <cover.1455500661.git.leo@famulari.name>
	<087e04d656c5cf999858265b109c807c685625ab.1455500661.git.leo@famulari.name>
	<20160218100332.465c67f2@debian-netbook>
	<20160218175605.GD29070@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53758)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aWT4z-0007Sb-D0
	for guix-devel@gnu.org; Thu, 18 Feb 2016 13:13:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aWT4w-0000rW-6u
	for guix-devel@gnu.org; Thu, 18 Feb 2016 13:13:29 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:52601)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aWT4w-0000rR-31
	for guix-devel@gnu.org; Thu, 18 Feb 2016 13:13:26 -0500
Content-Disposition: inline
In-Reply-To: <20160218175605.GD29070@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

On Thu, Feb 18, 2016 at 12:56:05PM -0500, Leo Famulari wrote:
> On Thu, Feb 18, 2016 at 10:03:32AM +0200, Efraim Flashner wrote:
> > On Sun, 14 Feb 2016 20:44:52 -0500
> > Leo Famulari <leo@famulari.name> wrote:
> > 
> > > * gnu/packages/python.scm (python-enum34)[inputs]: Remove
> > > python-setuptools.
> > > ---
> > >  gnu/packages/python.scm | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> > > index 9296cdf..66f911d 100644
> > > --- a/gnu/packages/python.scm
> > > +++ b/gnu/packages/python.scm
> > > @@ -1320,8 +1320,6 @@ bug tracker.")
> > >         (base32
> > >          "0yx1m4564wxgbm4glb3457hi16xihd9w63rv13y2przkdir9dfgp"))))
> > >      (build-system python-build-system)
> > > -    (inputs
> > > -     `(("python-setuptools" ,python-setuptools)))
> > >      (arguments
> > >       `(#:phases
> > >         (alist-replace
> > 
> > Does this break python2-enum34?
> 
> I don't think so. python2-cryptography still builds, passes it's tests,
> and seems to work in "downstream" applications.
> 
> I've noticed that the PyPi importer seems to unconditionally add
> setuptools as an input (I didn't check the code yet). So, perhaps that
> explains it's presence.
> 
> Or perhaps the version of python-2 we used at the time (2.7.6) did not
> include some setuptools feature that has since been added to the
> standard library.

Also, python-enum34 still builds with this change.