From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 2/4] gnu: Add python2-enum34.
Date: Thu, 18 Feb 2016 13:03:12 -0500
Message-ID: <20160218180312.GE29070@jasmine>
References: <cover.1455500661.git.leo@famulari.name>
	<7f5566f69c9f2184bebf647937630c869a3a60ad.1455500661.git.leo@famulari.name>
	<20160218100352.6969cb55@debian-netbook>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47692)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aWSv8-0001lA-Tm
	for guix-devel@gnu.org; Thu, 18 Feb 2016 13:03:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aWSv5-0003eI-OJ
	for guix-devel@gnu.org; Thu, 18 Feb 2016 13:03:18 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:40755)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aWSv5-0003dp-Gr
	for guix-devel@gnu.org; Thu, 18 Feb 2016 13:03:15 -0500
Content-Disposition: inline
In-Reply-To: <20160218100352.6969cb55@debian-netbook>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

On Thu, Feb 18, 2016 at 10:03:52AM +0200, Efraim Flashner wrote:
> On Sun, 14 Feb 2016 20:44:50 -0500
> Leo Famulari <leo@famulari.name> wrote:
> 
> > * gnu/packages/python.scm (python2-enum34): New variable.
> > (python2-cryptography)[propagated-inputs]: Add python2-enum34.
> > (python-cryptography)[propagated-inputs]: Remove python-enum34.
> > ---
> >  gnu/packages/python.scm | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> > index 3e712fc..6e1c716 100644
> > --- a/gnu/packages/python.scm
> > +++ b/gnu/packages/python.scm
> > @@ -1335,6 +1335,9 @@ bug tracker.")
> >  backported for previous versions of Python from 2.4 to 3.3.")
> >      (license bsd-3)))
> >  
> > +(define-public python2-enum34
> > +  (package-with-python2 python-enum34))
> > +
> >  (define-public python-parse-type
> >    (package
> >      (name "python-parse-type")
> > @@ -5792,7 +5795,6 @@ responses, rather than doing any computation.")
> >       `(("python-cffi" ,python-cffi)
> >         ("python-six" ,python-six)
> >         ("python-pyasn1" ,python-pyasn1)
> > -       ("python-enum34" ,python-enum34)
> >         ("python-idna" ,python-idna)
> >         ("python-iso8601" ,python-iso8601)))
> >      (native-inputs
> > @@ -5823,6 +5825,7 @@ message digests and key derivation functions.")
> >         `(("python2-ipaddress" ,python2-ipaddress)
> >           ("python2-backport-ssl-match-hostname"
> >            ,python2-backport-ssl-match-hostname)
> > +         ("python2-enum34" ,python2-enum34)
> >           ,@(package-propagated-inputs crypto))))))
> >  
> >  (define-public python-pyopenssl
> 
> I'd move the cryptography change to the next patch, it seems more in line

Good point, I did find the structure of the commits to be awkward.

> 
> -- 
> Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted