all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/4] gnu: python-enum34: Remove python-setuptools from inputs.
Date: Thu, 18 Feb 2016 12:56:05 -0500	[thread overview]
Message-ID: <20160218175605.GD29070@jasmine> (raw)
In-Reply-To: <20160218100332.465c67f2@debian-netbook>

On Thu, Feb 18, 2016 at 10:03:32AM +0200, Efraim Flashner wrote:
> On Sun, 14 Feb 2016 20:44:52 -0500
> Leo Famulari <leo@famulari.name> wrote:
> 
> > * gnu/packages/python.scm (python-enum34)[inputs]: Remove
> > python-setuptools.
> > ---
> >  gnu/packages/python.scm | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> > index 9296cdf..66f911d 100644
> > --- a/gnu/packages/python.scm
> > +++ b/gnu/packages/python.scm
> > @@ -1320,8 +1320,6 @@ bug tracker.")
> >         (base32
> >          "0yx1m4564wxgbm4glb3457hi16xihd9w63rv13y2przkdir9dfgp"))))
> >      (build-system python-build-system)
> > -    (inputs
> > -     `(("python-setuptools" ,python-setuptools)))
> >      (arguments
> >       `(#:phases
> >         (alist-replace
> 
> Does this break python2-enum34?

I don't think so. python2-cryptography still builds, passes it's tests,
and seems to work in "downstream" applications.

I've noticed that the PyPi importer seems to unconditionally add
setuptools as an input (I didn't check the code yet). So, perhaps that
explains it's presence.

Or perhaps the version of python-2 we used at the time (2.7.6) did not
include some setuptools feature that has since been added to the
standard library.

  reply	other threads:[~2016-02-18 17:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-15  1:44 [PATCH 0/4] Update use of python-enum34 Leo Famulari
2016-02-15  1:44 ` [PATCH 1/4] gnu: python-enum34: Update to 1.1.0 Leo Famulari
2016-02-15  1:44 ` [PATCH 2/4] gnu: Add python2-enum34 Leo Famulari
2016-02-18  8:03   ` Efraim Flashner
2016-02-18 18:03     ` Leo Famulari
2016-02-15  1:44 ` [PATCH 3/4] gnu: Don't use python-enum34 when building with python-3.4 Leo Famulari
2016-02-15  1:44 ` [PATCH 4/4] gnu: python-enum34: Remove python-setuptools from inputs Leo Famulari
2016-02-18  8:03   ` Efraim Flashner
2016-02-18 17:56     ` Leo Famulari [this message]
2016-02-18 18:13       ` Leo Famulari
2016-02-21  5:49     ` Leo Famulari
2016-02-21  6:38       ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160218175605.GD29070@jasmine \
    --to=leo@famulari.name \
    --cc=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.