From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH 3/3] gnu: Add vcsh
Date: Wed, 17 Feb 2016 19:11:07 +0100
Message-ID: <20160217181107.GA31074@solar>
References: <1455379675-27516-1-git-send-email-mail@cbaines.net>
	<1455379675-27516-4-git-send-email-mail@cbaines.net>
	<20160213224108.GC1176@jasmine> <56C0E530.9010604@cbaines.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50967)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1aW6ZI-0006mS-Co
	for guix-devel@gnu.org; Wed, 17 Feb 2016 13:11:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1aW6ZF-0006ua-7f
	for guix-devel@gnu.org; Wed, 17 Feb 2016 13:11:16 -0500
Received: from mailrelay6.public.one.com ([91.198.169.200]:59905)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1aW6ZE-0006uD-Rm
	for guix-devel@gnu.org; Wed, 17 Feb 2016 13:11:13 -0500
Content-Disposition: inline
In-Reply-To: <56C0E530.9010604@cbaines.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Christopher Baines <mail@cbaines.net>
Cc: guix-devel@gnu.org

Hello,

this looks good. I also added a copyright line for you.

On Sun, Feb 14, 2016 at 08:36:00PM +0000, Christopher Baines wrote:
> +     "vcsh provides the @code{vcsh} command, which allows you to maintain

I would shorten to "vcsh allows ..."; that vcsh provides the vcsh command
is close to a tautology.

> +the separation of the files in to different repositories, for example you

"in to" -> "into".

The build depends on perl-shell-command, which is not yet in the distribution;
so it looks like another patch should go in first. Leo, I think you handled
these? Could you have another look? Concerning one of your questions, I think
that removing "guix build utils" from the imported modules is fine (actually,
it was me who recommended it...).

Andreas