From: Andreas Enge <andreas@enge.fr>
To: Christopher Baines <mail@cbaines.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/3] gnu: Add vcsh
Date: Wed, 17 Feb 2016 19:11:07 +0100 [thread overview]
Message-ID: <20160217181107.GA31074@solar> (raw)
In-Reply-To: <56C0E530.9010604@cbaines.net>
Hello,
this looks good. I also added a copyright line for you.
On Sun, Feb 14, 2016 at 08:36:00PM +0000, Christopher Baines wrote:
> + "vcsh provides the @code{vcsh} command, which allows you to maintain
I would shorten to "vcsh allows ..."; that vcsh provides the vcsh command
is close to a tautology.
> +the separation of the files in to different repositories, for example you
"in to" -> "into".
The build depends on perl-shell-command, which is not yet in the distribution;
so it looks like another patch should go in first. Leo, I think you handled
these? Could you have another look? Concerning one of your questions, I think
that removing "guix build utils" from the imported modules is fine (actually,
it was me who recommended it...).
Andreas
next prev parent reply other threads:[~2016-02-17 18:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 16:07 [PATCH] gnu: Add vcsh and perl-shell-command Christopher Baines
2016-02-13 16:07 ` [PATCH 1/3] gnu: Add perl-shell-command Christopher Baines
2016-02-13 22:42 ` Leo Famulari
2016-02-13 16:07 ` [PATCH 2/3] gnu: Don't use guix build utils Christopher Baines
2016-02-13 22:39 ` Leo Famulari
2016-02-17 18:28 ` Christopher Baines
2016-02-18 0:15 ` Leo Famulari
2016-02-18 19:55 ` Andreas Enge
2016-02-18 19:59 ` Christopher Baines
2016-02-18 20:16 ` Andreas Enge
2016-02-18 21:13 ` Christopher Baines
2016-02-18 21:37 ` Andreas Enge
2016-02-13 16:07 ` [PATCH 3/3] gnu: Add vcsh Christopher Baines
2016-02-13 22:41 ` Leo Famulari
2016-02-14 20:36 ` Christopher Baines
2016-02-17 18:11 ` Andreas Enge [this message]
2016-02-17 18:59 ` Christopher Baines
2016-02-18 0:11 ` Leo Famulari
2016-02-18 0:27 ` Christopher Baines
2016-02-18 20:01 ` Andreas Enge
2016-02-18 21:04 ` Christopher Baines
2016-02-18 21:26 ` Leo Famulari
2016-02-18 21:32 ` Christopher Baines
2016-02-18 21:39 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217181107.GA31074@solar \
--to=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.