all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/18] gnu: Add python-mako.
Date: Mon, 15 Feb 2016 20:34:18 -0500	[thread overview]
Message-ID: <20160216013418.GC3984@jasmine> (raw)
In-Reply-To: <87povxsgla.fsf@dustycloud.org>

On Mon, Feb 15, 2016 at 03:23:45PM -0800, Christopher Allan Webber wrote:
> First in a series of towards-MediaGoblin patches.

Awesome!

I'm reviewing these on the assumption that you've tested they all build.

> From ad76816977e98e0230ccde7475598e6e85de4d29 Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Fri, 12 Feb 2016 13:23:46 -0800
> Subject: [PATCH 01/18] gnu: Add python-mako.
> 
> * gnu/packages/python.scm (python-mako, python2-mako): New variables.
> ---
>  gnu/packages/python.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 805c4a2..5b7e4ac 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -7532,3 +7532,34 @@ available in Django, but is a standalone package.")
>      (inherit (package-with-python2
>                (strip-python2-variant python-wtforms)))
>      (inputs `(("python2-setuptools" ,python2-setuptools)))))
> +
> +(define-public python-mako
> +  (package
> +    (name "python-mako")
> +    (version "1.0.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "Mako" version))
> +       (sha256
> +        (base32
> +         "136kcjbs0s98qkx8a418b05dfblqp0kiiqyx8vhx4rarwc7bqi3n"))))
> +    (build-system python-build-system)
> +    (inputs
> +     `(("python-markupsafe" ,python-markupsafe)
> +       ("python-mock" ,python-mock)
> +       ("python-nose" ,python-nose)))

Are mock and nose required after build-time? If not, they should be
native-inputs.

As for markupsafe, the latest version of the manual has this to say
about propagated-inputs:

Another example where propagated-inputs is useful is for languages that
lack a facility to record the run-time search path akin to ELF’s
RUNPATH; this includes Guile, Python, Perl, GHC, and more. To ensure
that libraries written in those languages can find library code they
depend on at run time, run-time dependencies must be listed in
propagated-inputs rather than inputs. 

I won't mention these potential issues in my reviews of the rest of the
patches.

> +    (home-page "http://www.makotemplates.org/")
> +    (synopsis
> +     "Fast templating language")
> +    (description
> +     "Mako is a Python string templating library.  Used frequently for
> +generating HTML.")
> +    (license license:expat)
> +    (properties `((python2-variant . ,(delay python2-mako))))))
> +
> +(define-public python2-mako
> +  (package
> +    (inherit (package-with-python2
> +              (strip-python2-variant python-mako)))
> +    (inputs `(("python2-setuptools" ,python2-setuptools)))))

Setuptools is a native-input.

> -- 
> 2.6.3
> 

  reply	other threads:[~2016-02-16  1:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-15 23:23 [PATCH 1/18] gnu: Add python-mako Christopher Allan Webber
2016-02-16  1:34 ` Leo Famulari [this message]
2016-02-20  2:40   ` On the MediaGoblin dependency patch updates Christopher Allan Webber
2016-02-20  4:58     ` Leo Famulari
2016-02-22  3:05       ` Christopher Allan Webber
2016-02-22  3:49         ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160216013418.GC3984@jasmine \
    --to=leo@famulari.name \
    --cc=cwebber@dustycloud.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.