[PATCH] wxwidgets: enable extended regexps

[PATCH] wxwidgets: enable extended regexps

[Danny Milosavljevic]

Hi,

the following patch enables "extended" regexps as required by kicad.
It could conceivably inadvertedly change behaviour of other wxwidgets apps. 
What do you think? Is this the right way?

diff --git a/gnu/packages/wxwidgets.scm b/gnu/packages/wxwidgets.scm
index b49fb2f..65adfc1 100644
--- a/gnu/packages/wxwidgets.scm
+++ b/gnu/packages/wxwidgets.scm
@@ -61,7 +61,7 @@
      `(("pkg-config" ,pkg-config)))
     (arguments
      '(#:configure-flags
-       '("--with-regex=sys" "--with-libmspack" "--with-sdl")
+       '("--with-regex" "--with-libmspack" "--with-sdl")
        #:make-flags
        (list (string-append "LDFLAGS=-Wl,-rpath="
                             (assoc-ref %outputs "out") "/lib"))

Re: [PATCH] wxwidgets: enable extended regexps

[Leo Famulari]

On Mon, Feb 15, 2016 at 05:28:39PM +0100, Danny Milosavljevic wrote:
> Hi,
> 
> the following patch enables "extended" regexps as required by kicad.
> It could conceivably inadvertedly change behaviour of other wxwidgets apps. 
> What do you think? Is this the right way?

Can you test that some of these other apps still work with this change?

> 
> diff --git a/gnu/packages/wxwidgets.scm b/gnu/packages/wxwidgets.scm
> index b49fb2f..65adfc1 100644
> --- a/gnu/packages/wxwidgets.scm
> +++ b/gnu/packages/wxwidgets.scm
> @@ -61,7 +61,7 @@
>       `(("pkg-config" ,pkg-config)))
>      (arguments
>       '(#:configure-flags
> -       '("--with-regex=sys" "--with-libmspack" "--with-sdl")
> +       '("--with-regex" "--with-libmspack" "--with-sdl")
>         #:make-flags
>         (list (string-append "LDFLAGS=-Wl,-rpath="
>                              (assoc-ref %outputs "out") "/lib"))
> 

Re: [PATCH] wxwidgets: enable extended regexps

[Andreas Enge]

On Mon, Feb 15, 2016 at 05:04:09PM -0500, Leo Famulari wrote:
> Can you test that some of these other apps still work with this change?

$ guix refresh -l wxwidgets
A single dependent package: wxmaxima-15.04.0

Andreas

Re: [PATCH] wxwidgets: enable extended regexps

[Thompson, David]

On Mon, Feb 15, 2016 at 5:07 PM, Andreas Enge <andreas@enge.fr> wrote:
> On Mon, Feb 15, 2016 at 05:04:09PM -0500, Leo Famulari wrote:
>> Can you test that some of these other apps still work with this change?
>
> $ guix refresh -l wxwidgets
> A single dependent package: wxmaxima-15.04.0

Additionally, the wxwidgets-2 package, which inherits from wxwidgets,
is used by Audacity.

- Dave

Re: [PATCH] wxwidgets: enable extended regexps

[Danny Milosavljevic]

Hi,

On Mon, 15 Feb 2016 17:47:36 -0500
"Thompson, David" <dthompson2@worcester.edu> wrote:

> On Mon, Feb 15, 2016 at 5:07 PM, Andreas Enge <andreas@enge.fr> wrote:
> > On Mon, Feb 15, 2016 at 05:04:09PM -0500, Leo Famulari wrote:  
> >> Can you test that some of these other apps still work with this change?  
> >
> > $ guix refresh -l wxwidgets
> > A single dependent package: wxmaxima-15.04.0  
> 
> Additionally, the wxwidgets-2 package, which inherits from wxwidgets,
> is used by Audacity.

Thanks.

For the record (since it will take some time for this to be able to be tested), the only place wxRegEx is used in in audacity is in the Help, which I'm currently trying to get to work at all (see bug# 22705).

It's mangling the pagename of the page it's supposed to open like this:

- Replace pattern-matched "%.." => "_"
- Replace all non-alphanumeric which aren't space or "." by "_"
- Replace space => "+"
- Replace multiple underscores by single underscore (__+ => _)
- Non-regex-Replace "_." by "."
- concatenate the result and ReleaseSuffix and anchor in order to yield a filename and an URL to look up.