From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add slurm. Date: Sun, 14 Feb 2016 14:08:30 -0500 Message-ID: <20160214190830.GA18708@jasmine> References: <20160212125719.GA14615@thebird.nl> <20160213085940.GA18223@thebird.nl> <20160213102825.GA19194@debian> <20160213164257.GA19241@thebird.nl> <20160213170119.GA19344@thebird.nl> <20160213172001.GA3956@debian> <20160213201337.GA9218@jasmine> <20160213203422.GA13890@debian> <20160213204055.GA10236@jasmine> <20160214142256.GB6684@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aV223-0007k1-1V for guix-devel@gnu.org; Sun, 14 Feb 2016 14:08:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aV21y-0007wT-2e for guix-devel@gnu.org; Sun, 14 Feb 2016 14:08:30 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:56191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aV21x-0007wJ-SR for guix-devel@gnu.org; Sun, 14 Feb 2016 14:08:25 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3D2F02046E for ; Sun, 14 Feb 2016 14:08:25 -0500 (EST) Content-Disposition: inline In-Reply-To: <20160214142256.GB6684@debian> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org On Sun, Feb 14, 2016 at 03:22:56PM +0100, Andreas Enge wrote: > On Sat, Feb 13, 2016 at 03:40:55PM -0500, Leo Famulari wrote: > > If that is it, then I believe git should "do the right thing" when > > generating patches. I've noticed that it progressively sets the encoding > > based on the minimum required to encode the characters in the patch. > > The last line of your diffoscope shows that Pjotr's patch was encoded > in iso-8559-1, while all the scheme files in guix are in utf-8. It seems > quite clear to me that this is the reason for our problems. And apparently, > the git version plays a role in this. I think the old version of git must play a role, or every patch with a copyright attribution line would fail to apply.