From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 3/3] gnu: Add vcsh Date: Sat, 13 Feb 2016 17:41:08 -0500 Message-ID: <20160213224108.GC1176@jasmine> References: <1455379675-27516-1-git-send-email-mail@cbaines.net> <1455379675-27516-4-git-send-email-mail@cbaines.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUisF-0008MK-0B for guix-devel@gnu.org; Sat, 13 Feb 2016 17:41:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUisB-0008Uk-Ft for guix-devel@gnu.org; Sat, 13 Feb 2016 17:41:06 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42349) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUisB-0008Ua-Da for guix-devel@gnu.org; Sat, 13 Feb 2016 17:41:03 -0500 Content-Disposition: inline In-Reply-To: <1455379675-27516-4-git-send-email-mail@cbaines.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Christopher Baines Cc: guix-devel@gnu.org On Sat, Feb 13, 2016 at 04:07:55PM +0000, Christopher Baines wrote: > * gnu/packages/version-control.scm (vcsh): New variable. [...] > + (arguments > + `(#:phases (modify-phases %standard-phases > + (delete 'configure) > + (delete 'check) > + (delete 'build)) Can you add comments explaining why the check and build phases are deleted? For the former, it can be as simple as "no test suite". I assume the build phase is replaced by the install phase; the comment can say something like that if it's the case. > + #:make-flags (list (string-append "PREFIX=" %output)))) > + (native-inputs > + `(("which" ,which))) > + (inputs > + `(("perl-shell-command" ,perl-shell-command) > + ("perl-test-most" ,perl-test-most))) > + (propagated-inputs > + `(("git" ,git))) > + (home-page "https://github.com/RichiH/vcsh") > + (synopsis "Version control system for $HOME") > + (description > + "vcsh provides the @code{vcsh} command, which allows you to maintain > +several Git repositories in one single directory. This can be useful when > +using version control for files in your home directory, as it allows for > +the separation of the files in to different repositories, for example you > +may keep your bash configuration in a separate Git repository from your > +emacs configuration.") > + (license gpl2+))) > -- > 2.7.0 > >