From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add slurm. Date: Sat, 13 Feb 2016 16:43:38 -0500 Message-ID: <20160213214338.GA10825@jasmine> References: <20160212123141.GB14324@thebird.nl> <20160212125719.GA14615@thebird.nl> <20160213085940.GA18223@thebird.nl> <20160213102825.GA19194@debian> <20160213164257.GA19241@thebird.nl> <20160213170119.GA19344@thebird.nl> <20160213172001.GA3956@debian> <20160213201337.GA9218@jasmine> <20160213203846.GA9644@jasmine> <20160213213201.GA20467@thebird.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUhya-0007IJ-U9 for guix-devel@gnu.org; Sat, 13 Feb 2016 16:43:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUhyX-00034w-Ok for guix-devel@gnu.org; Sat, 13 Feb 2016 16:43:36 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:40948) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUhyX-00034o-7z for guix-devel@gnu.org; Sat, 13 Feb 2016 16:43:33 -0500 Content-Disposition: inline In-Reply-To: <20160213213201.GA20467@thebird.nl> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Pjotr Prins Cc: guix-devel@gnu.org On Sat, Feb 13, 2016 at 10:32:01PM +0100, Pjotr Prins wrote: > On Sat, Feb 13, 2016 at 03:38:46PM -0500, Leo Famulari wrote: > > I wonder if the version of git is a factor? 2.1.4 vs 2.6.3. Jan was also > > using 2.1.4, and his patches also failed *only* on the attribution line. > > Thank you Leo and Andreas for restoring my sanity! > > I'll upgrade git. I was using the newer version in my build > environment but generating the patch in an older version. Also locales > I need to settle on. I tend to have en_GB on Debian, but in a guix > shell it may act strange if I don't specify locales. > > And I won't add attribution again ;). I.e., the combination of being > an old git, having wrong locales and injecting self-attribution, was > lethal. Does this mean the old version of git doesn't generate patches with the correct locale? I wonder... where is everyone getting git 2.1.4 from? It's 2 years old ;) > > Pj.