From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add slurm. Date: Sat, 13 Feb 2016 15:40:55 -0500 Message-ID: <20160213204055.GA10236@jasmine> References: <20160212123010.GA6019@debian.eduroam.u-bordeaux.fr> <20160212123141.GB14324@thebird.nl> <20160212125719.GA14615@thebird.nl> <20160213085940.GA18223@thebird.nl> <20160213102825.GA19194@debian> <20160213164257.GA19241@thebird.nl> <20160213170119.GA19344@thebird.nl> <20160213172001.GA3956@debian> <20160213201337.GA9218@jasmine> <20160213203422.GA13890@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUgzu-0001b1-4K for guix-devel@gnu.org; Sat, 13 Feb 2016 15:40:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUgzq-0003t3-Rd for guix-devel@gnu.org; Sat, 13 Feb 2016 15:40:54 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:49640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUgzq-0003st-FT for guix-devel@gnu.org; Sat, 13 Feb 2016 15:40:50 -0500 Content-Disposition: inline In-Reply-To: <20160213203422.GA13890@debian> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org On Sat, Feb 13, 2016 at 09:34:22PM +0100, Andreas Enge wrote: > On Sat, Feb 13, 2016 at 03:13:37PM -0500, Leo Famulari wrote: > > I used diffoscope to compare the non-working patch and a "should-be" > > identical patch that I generated locally. The only differences were in > > the patch headers and the encoding of the file (UTF-8 vs ISO-8859-1). > > I think that explains it: The non-working part of the patch was the copyright > line, which contains the copyright symbol! > > So let us all move to utf-8! If that is it, then I believe git should "do the right thing" when generating patches. I've noticed that it progressively sets the encoding based on the minimum required to encode the characters in the patch. For example, if all characters can be encoded in ASCII, it uses ASCII, otherwise I think it uses UTF-8.