From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH] gnu: Add laby.
Date: Sat, 13 Feb 2016 09:43:29 +0100
Message-ID: <20160213084329.GA10278@debian>
References: <87egcleiig.fsf@gnu.org> <87fux1y0vg.fsf@dustycloud.org>
	<20160211221839.73cf23b5@debian-netbook> <87k2madh1x.fsf@gnu.org>
	<20160212180905.GA8954@debian> <87pow19gii.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1aUVnl-0004jR-HX
	for guix-devel@gnu.org; Sat, 13 Feb 2016 03:43:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1aUVni-0004iH-BO
	for guix-devel@gnu.org; Sat, 13 Feb 2016 03:43:37 -0500
Received: from mailrelay1.public.one.com ([91.198.169.124]:48180)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1aUVnh-0004i7-UY
	for guix-devel@gnu.org; Sat, 13 Feb 2016 03:43:34 -0500
Content-Disposition: inline
In-Reply-To: <87pow19gii.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guix-devel@gnu.org

On Sat, Feb 13, 2016 at 09:11:17AM +0100, Jan Nieuwenhuizen wrote:
> Nice!  New patch set attached.

Very good, I pushed the first two. Concerning the commit message, it should
read "gnu: ocaml: ..." in case a package is modified.

> Subject: [PATCH 3/3] gnu: Add laby.
> * gnu/packages/patches/laby-make-install.patch: New file.
> * gnu/packages/patches/laby-make-png.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add them.
> * gnu/packages/games.scm (laby): New variable.

Here I would not use a patch. The policy is not totally clear (and not
written up), but if an additional phase for installation is needed, I
would do it in a custom phase on the scheme side instead of patching the
makefile. See, for instance, the tinyxml package in xml.scm.

Maybe it would also warrant an upstream bug report?

Similarly for the make-png patch. Is this an upstream bug?

Andreas

PS: The game starts and shows the maze, it looks quite nice!
PPS: You do not happen to use unison? I think your previous patches would
     allow to build it with gtk support, and unlike me, you seem to know
     what you are doing...