From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add erlang.
Date: Fri, 12 Feb 2016 19:44:46 -0500
Message-ID: <20160213004446.GB13163@jasmine>
References: <CA+xn8YDemiCuOf569TUfP3XAMKpDhF-JqeymgCU0ntHRorPZsQ@mail.gmail.com>
	<20160104043952.GA29303@jasmine>
	<CA+xn8YCU5_WizeVShKQ_2LaF-uDAY4H57o_nYjxDRuEv-TkJyQ@mail.gmail.com>
	<877fjpzi07.fsf@igalia.com> <87wprmg088.fsf@gnu.org>
	<87y4c1ww4y.fsf@igalia.com>
	<CA+xn8YCBfR9nQ+CcfvQrGBy3Wamb3=kTqVik8xu_LA3jC7xfJQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42430)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aUOKO-0005Gl-1F
	for guix-devel@gnu.org; Fri, 12 Feb 2016 19:44:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aUOKJ-0003qs-DH
	for guix-devel@gnu.org; Fri, 12 Feb 2016 19:44:47 -0500
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47091)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aUOKI-0003ql-T4
	for guix-devel@gnu.org; Fri, 12 Feb 2016 19:44:43 -0500
Content-Disposition: inline
In-Reply-To: <CA+xn8YCBfR9nQ+CcfvQrGBy3Wamb3=kTqVik8xu_LA3jC7xfJQ@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Steve Sprang <steve.sprang@gmail.com>
Cc: guix-devel@gnu.org

On Sat, Feb 06, 2016 at 12:45:39PM -0800, Steve Sprang wrote:
> It looks like downloading the tarball from erlang.org works now.
> Here's an improved patch.

I wonder, do you happen to have any Erlang programs packaged that I can
test this with? Or, would they require the creation of a full
erlang-build-system?

Otherwise, the patch LGTM with a couple minor stylistic changes.

> From 0a1a045ef67e5e70d003c230c72b78a13e38b69b Mon Sep 17 00:00:00 2001
> From: Steve Sprang <scs@stevesprang.com>
> Date: Sat, 6 Feb 2016 12:40:53 -0800
> Subject: [PATCH] gnu: Add erlang.
> 
> * gnu/packages/erlang.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

Awesome, there is some Erlang software I'd like to package :) Thanks for
working on this.

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +	 (add-after
> +	     'patch-source-shebangs 'patch-source-env

I would put these phase names on the same line as 'add-after' or
directly below the first character of 'add-after'

> +	   (lambda* _
> +	     (let ((escripts
> +		    (append
> +		     (find-files "." "\\.escript")
> +		     (find-files "lib/stdlib/test/escript_SUITE_data/")
> +		     '("erts/lib_src/utils/make_atomics_api"
> +		       "erts/preloaded/src/add_abstract_code"
> +		       "lib/diameter/bin/diameterc"
> +		       "lib/reltool/examples/display_args"
> +		       "lib/reltool/examples/mnesia_core_dump_viewer"
> +		       "lib/snmp/src/compile/snmpc.src"
> +		       "make/verify_runtime_dependencies"
> +		       "make/emd2exml.in"))))
> +	       (substitute* escripts
> +		 (("/usr/bin/env") (which "env"))))))
> +         (add-before
> +             'configure 'set-erl-top
> +           (lambda* _
> +             (setenv "ERL_TOP" (getcwd)))))

I _think_ that 'lambda _' would be appropriate here. I need a real
Schemer to weigh in ;)