Re: [PATCH] gnu: Add erlang.

[Leo Famulari <leo@famulari.name>]

On Sat, Feb 06, 2016 at 12:45:39PM -0800, Steve Sprang wrote:
> It looks like downloading the tarball from erlang.org works now.
> Here's an improved patch.

I wonder, do you happen to have any Erlang programs packaged that I can
test this with? Or, would they require the creation of a full
erlang-build-system?

Otherwise, the patch LGTM with a couple minor stylistic changes.

> From 0a1a045ef67e5e70d003c230c72b78a13e38b69b Mon Sep 17 00:00:00 2001
> From: Steve Sprang <scs@stevesprang.com>
> Date: Sat, 6 Feb 2016 12:40:53 -0800
> Subject: [PATCH] gnu: Add erlang.
> 
> * gnu/packages/erlang.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

Awesome, there is some Erlang software I'd like to package :) Thanks for
working on this.

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +	 (add-after
> +	     'patch-source-shebangs 'patch-source-env

I would put these phase names on the same line as 'add-after' or
directly below the first character of 'add-after'

> +	   (lambda* _
> +	     (let ((escripts
> +		    (append
> +		     (find-files "." "\\.escript")
> +		     (find-files "lib/stdlib/test/escript_SUITE_data/")
> +		     '("erts/lib_src/utils/make_atomics_api"
> +		       "erts/preloaded/src/add_abstract_code"
> +		       "lib/diameter/bin/diameterc"
> +		       "lib/reltool/examples/display_args"
> +		       "lib/reltool/examples/mnesia_core_dump_viewer"
> +		       "lib/snmp/src/compile/snmpc.src"
> +		       "make/verify_runtime_dependencies"
> +		       "make/emd2exml.in"))))
> +	       (substitute* escripts
> +		 (("/usr/bin/env") (which "env"))))))
> +         (add-before
> +             'configure 'set-erl-top
> +           (lambda* _
> +             (setenv "ERL_TOP" (getcwd)))))

I _think_ that 'lambda _' would be appropriate here. I need a real
Schemer to weigh in ;)