Gnupg 2.1.11

Gnupg 2.1.11

[Andreas Enge]

Hello,

since my update to 2.1.11, gnupg fails to build on hydra:
   http://hydra.gnu.org/build/990803
with a failure of one of the tests.

The package builds without problems on my machine. Could someone else
try it out, please?

Andreas

Re: Gnupg 2.1.11

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> since my update to 2.1.11, gnupg fails to build on hydra:
>    http://hydra.gnu.org/build/990803
> with a failure of one of the tests.
>
> The package builds without problems on my machine. Could someone else
> try it out, please?

We discussed it on IRC and I can tell that a --rounds=3 build succeeded
here on x86_64, yielding:

  /gnu/store/lk82n0sxjm9z2wciiadvd32nnkr2a404-gnupg-2.1.11
  SHA256: 029qvi1k26rw6agx39gxaz12dx2shgzmm81f9bbagzvh9m2vfh2w

Mark was suspecting a hardware issue on the build machine, so we’re
running memtester on the presumed build machine.

Ludo’.

Re: Gnupg 2.1.11

[Andreas Enge]

On Thu, Feb 04, 2016 at 05:58:12PM +0100, Ludovic Courtès wrote:
> We discussed it on IRC

We continued discussion there. It fails on hydra.gnunet.org and
guix.sdj.se and succeeded on chapters.gnu.org.

There is a dependency chain gnupg -> openldap -> openssl, so it may be
related to the openssl update; that the failures are not uniform is
worrying, however.

Andreas

bug#22558: gnupg-2.1.11 on x86_64 failed its tests many times on Hydra

[Mark H Weaver]

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

gnupg-2.1.11 on x86_64 failed its tests many times on Hydra:

  http://hydra.gnu.org:3000/build/990803#tabs-buildsteps

On all other architectures (i686, armhf, mips64el) it succeeded on the
first try.  So far, we've heard no reports of it failing for anyone else
on x86_64.  Ludovic built it 3 times on his x86_64 machine and it never
failed.

It failed in at least two different ways:

* With only 1 test failure: gpgtar.test.  This happened on at least two
  different build slaves.

* With 14 test failures.  This happened at least twice, on
  hydra.gnunet.org.

I've attached 4 of the failure logs retrieved from Hydra.  There are two
logs of each of the two failure modes described above.

It would be good to understand what happened here.

     Mark



[-- Attachment #2: hydra gnupg-x86_64 failure logs --]
[-- Type: application/octet-stream, Size: 30788 bytes --]

bug#22558: gnupg-2.1.11 on x86_64 failed its tests many times on Hydra

[Mark H Weaver]

Mark H Weaver <mhw@netris.org> writes:

> gnupg-2.1.11 on x86_64 failed its tests many times on Hydra:
>
>   http://hydra.gnu.org:3000/build/990803#tabs-buildsteps
>
> On all other architectures (i686, armhf, mips64el) it succeeded on the
> first try.  So far, we've heard no reports of it failing for anyone else
> on x86_64.  Ludovic built it 3 times on his x86_64 machine and it never
> failed.
>
> It failed in at least two different ways:
>
> * With only 1 test failure: gpgtar.test.  This happened on at least two
>   different build slaves.
>
> * With 14 test failures.  This happened at least twice, on
>   hydra.gnunet.org.

Eric Bavier reported on #guix that it failed to build on his machine
twice in a row, with 14 test failures.

       Mark

bug#22558: gnupg-2.1.11 on x86_64 failed its tests many times on Hydra

[Mark H Weaver]

Eric Bavier found this:

  https://bugs.gnupg.org/gnupg/issue2229

Title: "make check 14 0f 35 tests failed"

     Mark


PS: It doesn't load in our IceCat with the error "Cannot communicate
    securely with peer: no common encryption algorithm(s). (Error code:
    ssl_error_no_cypher_overlap)", but it works in Epiphany.

Re: Gnupg 2.1.11

[Mark H Weaver]

It eventually built successfully, and we've learned more recently.
See https://bugs.gnu.org/22558 for further discussion on this issue.

     Thanks,
       Mark

bug#22558: gnupg-2.1.11 on x86_64 failed its tests many times on Hydra

[Eric Bavier]

> > * With 14 test failures.  This happened at least twice, on
> >   hydra.gnunet.org.
> 
> Eric Bavier reported on #guix that it failed to build on his machine
> twice in a row, with 14 test failures.

I used 'git bisect' on the gnupg repository to narrow the failures down. 
  Commit ee87c653bf is the commit that introduces the failures.

Knowing this however doesn't explain why Ludo was not able to reproduce 
on his machine or why Hydra was eventually able to build it 
successfully.

-- 
`~Eric

bug#22558: gnupg-2.1.11 on x86_64 failed its tests many times on Hydra

[Leo Famulari]

On Fri, Feb 05, 2016 at 09:25:10AM -0600, Eric Bavier wrote:
> >> * With 14 test failures.  This happened at least twice, on
> >>   hydra.gnunet.org.
> >
> >Eric Bavier reported on #guix that it failed to build on his machine
> >twice in a row, with 14 test failures.
> 
> I used 'git bisect' on the gnupg repository to narrow the failures down.
> Commit ee87c653bf is the commit that introduces the failures.
> 
> Knowing this however doesn't explain why Ludo was not able to reproduce on
> his machine or why Hydra was eventually able to build it successfully.

It fails on my x86_64 machine as well, also with those 14 test failures.
Will somebody for whom it builds successfully see if it builds
reproducibly on their machine?

> 
> -- 
> `~Eric
> 
> 
> 

Re: Gnupg 2.1.11

[Alex Vong]

Hi people,

On 05/02/2016, Mark H Weaver <mhw@netris.org> wrote:
> It eventually built successfully, and we've learned more recently.
> See https://bugs.gnu.org/22558 for further discussion on this issue.

When I try to follow the link, I get the following:

    Your connection is not secure

    The owner of bugs.gnu.org has configured their website improperly.
To protect your information from being stolen, Iceweasel has not
connected to this website.

The browser used is iceweasel 44.0 in Debian unstable.
Clicking the "Advanced tab" gives the following:

    bugs.gnu.org uses an invalid security certificate. The certificate
is only valid for the following names: debbugs.gnu.org,
www.debbugs.gnu.org (Error code: ssl_error_bad_cert_domain)

>
>      Thanks,
>        Mark
>
>

Re: Gnupg 2.1.11

[Mark H Weaver]

Alex Vong <alexvong1995@gmail.com> writes:

> Hi people,
>
> On 05/02/2016, Mark H Weaver <mhw@netris.org> wrote:
>> It eventually built successfully, and we've learned more recently.
>> See https://bugs.gnu.org/22558 for further discussion on this issue.
>
> When I try to follow the link, I get the following:
>
>     Your connection is not secure
>
>     The owner of bugs.gnu.org has configured their website improperly.
> To protect your information from being stolen, Iceweasel has not
> connected to this website.
>
> The browser used is iceweasel 44.0 in Debian unstable.
> Clicking the "Advanced tab" gives the following:
>
>     bugs.gnu.org uses an invalid security certificate. The certificate
> is only valid for the following names: debbugs.gnu.org,
> www.debbugs.gnu.org (Error code: ssl_error_bad_cert_domain)

Thanks for letting me know.  I guess we should post bug links in the
form https://debbugs.gnu.org/22558 until the certificate is updated to
include bugs.gnu.org.

     Thanks,
       Mark

bug#22558: gnupg-2.1.11 on x86_64 failed its tests many times on Hydra

[Ludovic Courtès]

Eric Bavier <ericbavier@openmailbox.org> skribis:

>> > * With 14 test failures.  This happened at least twice, on
>> >   hydra.gnunet.org.
>>
>> Eric Bavier reported on #guix that it failed to build on his machine
>> twice in a row, with 14 test failures.
>
> I used 'git bisect' on the gnupg repository to narrow the failures
> down. Commit ee87c653bf is the commit that introduces the failures.

Thanks for digging!  Could you report it upstream?

> Knowing this however doesn't explain why Ludo was not able to
> reproduce on his machine or why Hydra was eventually able to build it
> successfully.

This could be due to assembly using instructions available on one
machine and not the other.

Ludo’.

bug#22558: gnupg-2.1.11 on x86_64 failed its tests many times on Hydra

[Mark H Weaver]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

ludo@gnu.org (Ludovic Courtès) writes:

> Eric Bavier <ericbavier@openmailbox.org> skribis:
>
>>> > * With 14 test failures.  This happened at least twice, on
>>> >   hydra.gnunet.org.
>>>
>>> Eric Bavier reported on #guix that it failed to build on his machine
>>> twice in a row, with 14 test failures.
>>
>> I used 'git bisect' on the gnupg repository to narrow the failures
>> down. Commit ee87c653bf is the commit that introduces the failures.
>
> Thanks for digging!  Could you report it upstream?

I reported it upstream, and now they have a fix in their repo.
I've attached a patch to Guix which adds this upstream patch.

Eric, would you be willing to test it and see if it fixes the problem
for you?

      Mark


[-- Attachment #2: [PATCH] gnu: gnupg: Add upstream fix for test failures on x86_64 --]
[-- Type: text/x-patch, Size: 7514 bytes --]

From bd025179efca777678f39a782f851e07719db05f Mon Sep 17 00:00:00 2001
From: Mark H Weaver <mhw@netris.org>
Date: Fri, 12 Feb 2016 18:19:05 -0500
Subject: [PATCH] gnu: gnupg: Add upstream fix for test failures on x86_64.

Fixes <https://debbugs.gnu.org/22558>.

* gnu/packages/patches/gnupg-simple-query-ignore-status-messages.patch: New
  file.
* gnu-system.am (dist_patch_DATA): Add it.
* gnu/packages/gnupg.scm (gnupg)[source]: Add patch.
---
 gnu-system.am                                      |   1 +
 gnu/packages/gnupg.scm                             |   7 +-
 ...gnupg-simple-query-ignore-status-messages.patch | 142 +++++++++++++++++++++
 3 files changed, 148 insertions(+), 2 deletions(-)
 create mode 100644 gnu/packages/patches/gnupg-simple-query-ignore-status-messages.patch

diff --git a/gnu-system.am b/gnu-system.am
index 9a2988c..3a47e00 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -506,6 +506,7 @@ dist_patch_DATA =						\
   gnu/packages/patches/gmp-arm-asm-nothumb.patch		\
   gnu/packages/patches/gmp-faulty-test.patch			\
   gnu/packages/patches/gnucash-price-quotes-perl.patch		\
+  gnu/packages/patches/gnupg-simple-query-ignore-status-messages.patch \
   gnu/packages/patches/gobject-introspection-absolute-shlib-path.patch \
   gnu/packages/patches/gobject-introspection-cc.patch		\
   gnu/packages/patches/gobject-introspection-girepository.patch	\
diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
index a35e8fc..6cd37bc 100644
--- a/gnu/packages/gnupg.scm
+++ b/gnu/packages/gnupg.scm
@@ -2,7 +2,7 @@
 ;;; Copyright © 2012, 2013, 2014, 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2013, 2015 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
-;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2014, 2015, 2016 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
 ;;; Copyright © 2015, 2016 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016 Christopher Allan Webber <cwebber@dustycloud.org>
@@ -206,7 +206,10 @@ compatible to GNU Pth.")
                                   ".tar.bz2"))
               (sha256
                (base32
-                "06mn2viiwsyq991arh5i5fhr9jyxq2bi0jkdj7ndfisxihngpc5p"))))
+                "06mn2viiwsyq991arh5i5fhr9jyxq2bi0jkdj7ndfisxihngpc5p"))
+              (patches
+               (list (search-patch
+                      "gnupg-simple-query-ignore-status-messages.patch")))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)))
diff --git a/gnu/packages/patches/gnupg-simple-query-ignore-status-messages.patch b/gnu/packages/patches/gnupg-simple-query-ignore-status-messages.patch
new file mode 100644
index 0000000..153f71c
--- /dev/null
+++ b/gnu/packages/patches/gnupg-simple-query-ignore-status-messages.patch
@@ -0,0 +1,142 @@
+Copied from upstream:
+http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=commitdiff;h=acac103ba5772ae738ce5409d17feab80596cde6
+
+Fixes: https://debbugs.gnu.org/22558
+Upstream bug: https://bugs.gnupg.org/gnupg/issue2229
+
+From acac103ba5772ae738ce5409d17feab80596cde6 Mon Sep 17 00:00:00 2001
+From: "Neal H. Walfield" <neal@g10code.com>
+Date: Fri, 12 Feb 2016 22:12:21 +0100
+Subject: [PATCH] common: Change simple_query to ignore status messages.
+
+* common/simple-pwquery.c (simple_query): Ignore status messages.
+
+--
+Signed-off-by: Neal H. Walfield <neal@g10code.com>
+GnuPG-bug-id: 2229
+---
+ common/simple-pwquery.c | 95 ++++++++++++++++++++++++++++++++++---------------
+ 1 file changed, 67 insertions(+), 28 deletions(-)
+
+diff --git a/common/simple-pwquery.c b/common/simple-pwquery.c
+index 90d04c0..b2d666c 100644
+--- a/common/simple-pwquery.c
++++ b/common/simple-pwquery.c
+@@ -618,6 +618,7 @@ simple_query (const char *query)
+   int fd = -1;
+   int nread;
+   char response[500];
++  int have = 0;
+   int rc;
+ 
+   rc = agent_open (&fd);
+@@ -628,40 +629,78 @@ simple_query (const char *query)
+   if (rc)
+     goto leave;
+ 
+-  /* get response */
+-  nread = readline (fd, response, 499);
+-  if (nread < 0)
+-    {
+-      rc = -nread;
+-      goto leave;
+-    }
+-  if (nread < 3)
++  while (1)
+     {
+-      rc = SPWQ_PROTOCOL_ERROR;
+-      goto leave;
+-    }
++      if (! have || ! strchr (response, '\n'))
++        /* get response */
++        {
++          nread = readline (fd, &response[have],
++                            sizeof (response) - 1 /* NUL */ - have);
++          if (nread < 0)
++            {
++              rc = -nread;
++              goto leave;
++            }
++          have += nread;
++          if (have < 3)
++            {
++              rc = SPWQ_PROTOCOL_ERROR;
++              goto leave;
++            }
++          response[have] = 0;
++        }
+ 
+-  if (response[0] == 'O' && response[1] == 'K')
+-    /* OK, do nothing.  */;
+-  else if ((nread > 7 && !memcmp (response, "ERR 111", 7)
+-            && (response[7] == ' ' || response[7] == '\n') )
+-           || ((nread > 4 && !memcmp (response, "ERR ", 4)
+-                && (strtoul (response+4, NULL, 0) & 0xffff) == 99)) )
+-    {
+-      /* 111 is the old Assuan code for canceled which might still
+-         be in use by old installations. 99 is GPG_ERR_CANCELED as
+-         used by modern gpg-agents; 0xffff is used to mask out the
+-         error source.  */
++      if (response[0] == 'O' && response[1] == 'K')
++        /* OK, do nothing.  */;
++      else if ((nread > 7 && !memcmp (response, "ERR 111", 7)
++                && (response[7] == ' ' || response[7] == '\n') )
++               || ((nread > 4 && !memcmp (response, "ERR ", 4)
++                    && (strtoul (response+4, NULL, 0) & 0xffff) == 99)) )
++        {
++          /* 111 is the old Assuan code for canceled which might still
++             be in use by old installations. 99 is GPG_ERR_CANCELED as
++             used by modern gpg-agents; 0xffff is used to mask out the
++             error source.  */
+ #ifdef SPWQ_USE_LOGGING
+-      log_info (_("canceled by user\n") );
++          log_info (_("canceled by user\n") );
+ #endif
+-    }
+-  else
+-    {
++        }
++      else if (response[0] == 'S' && response[1] == ' ')
++        {
++          char *nextline;
++          int consumed;
++
++          nextline = strchr (response, '\n');
++          if (! nextline)
++            /* Point to the NUL.  */
++            nextline = &response[have];
++          else
++            /* Move past the \n.  */
++            nextline ++;
++
++          consumed = (size_t) nextline - (size_t) response;
++
++          /* Skip any additional newlines.  */
++          while (consumed < have && response[consumed] == '\n')
++            consumed ++;
++
++          have -= consumed;
++
++          if (have)
++            memmove (response, &response[consumed], have + 1);
++
++          continue;
++        }
++      else
++        {
+ #ifdef SPWQ_USE_LOGGING
+-      log_error (_("problem with the agent\n"));
++          log_error (_("problem with the agent (unexpected response \"%s\"\n"),
++                     response);
+ #endif
+-      rc = SPWQ_ERR_RESPONSE;
++          rc = SPWQ_ERR_RESPONSE;
++        }
++
++      break;
+     }
+ 
+  leave:
+-- 
+2.6.3
+
-- 
2.6.3

bug#22558: gnupg-2.1.11 on x86_64 failed its tests many times on Hydra

[Leo Famulari]

On Fri, Feb 12, 2016 at 06:22:46PM -0500, Mark H Weaver wrote:
> ludo@gnu.org (Ludovic Courtès) writes:
> 
> > Eric Bavier <ericbavier@openmailbox.org> skribis:
> >
> >>> > * With 14 test failures.  This happened at least twice, on
> >>> >   hydra.gnunet.org.
> >>>
> >>> Eric Bavier reported on #guix that it failed to build on his machine
> >>> twice in a row, with 14 test failures.
> >>
> >> I used 'git bisect' on the gnupg repository to narrow the failures
> >> down. Commit ee87c653bf is the commit that introduces the failures.
> >
> > Thanks for digging!  Could you report it upstream?
> 
> I reported it upstream, and now they have a fix in their repo.
> I've attached a patch to Guix which adds this upstream patch.
> 
> Eric, would you be willing to test it and see if it fixes the problem
> for you?

I'm not Eric, but with this patch, I can successfully build on the
machine that was previously exhibiting the failures.

> 
>       Mark
> 

> From bd025179efca777678f39a782f851e07719db05f Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Fri, 12 Feb 2016 18:19:05 -0500
> Subject: [PATCH] gnu: gnupg: Add upstream fix for test failures on x86_64.
> 
> Fixes <https://debbugs.gnu.org/22558>.
> 
> * gnu/packages/patches/gnupg-simple-query-ignore-status-messages.patch: New
>   file.
> * gnu-system.am (dist_patch_DATA): Add it.
> * gnu/packages/gnupg.scm (gnupg)[source]: Add patch.
> ---
>  gnu-system.am                                      |   1 +
>  gnu/packages/gnupg.scm                             |   7 +-
>  ...gnupg-simple-query-ignore-status-messages.patch | 142 +++++++++++++++++++++
>  3 files changed, 148 insertions(+), 2 deletions(-)
>  create mode 100644 gnu/packages/patches/gnupg-simple-query-ignore-status-messages.patch
> 
> diff --git a/gnu-system.am b/gnu-system.am
> index 9a2988c..3a47e00 100644
> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -506,6 +506,7 @@ dist_patch_DATA =						\
>    gnu/packages/patches/gmp-arm-asm-nothumb.patch		\
>    gnu/packages/patches/gmp-faulty-test.patch			\
>    gnu/packages/patches/gnucash-price-quotes-perl.patch		\
> +  gnu/packages/patches/gnupg-simple-query-ignore-status-messages.patch \
>    gnu/packages/patches/gobject-introspection-absolute-shlib-path.patch \
>    gnu/packages/patches/gobject-introspection-cc.patch		\
>    gnu/packages/patches/gobject-introspection-girepository.patch	\
> diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
> index a35e8fc..6cd37bc 100644
> --- a/gnu/packages/gnupg.scm
> +++ b/gnu/packages/gnupg.scm
> @@ -2,7 +2,7 @@
>  ;;; Copyright © 2012, 2013, 2014, 2015 Ludovic Courtès <ludo@gnu.org>
>  ;;; Copyright © 2013, 2015 Andreas Enge <andreas@enge.fr>
>  ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
> -;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
> +;;; Copyright © 2014, 2015, 2016 Mark H Weaver <mhw@netris.org>
>  ;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
>  ;;; Copyright © 2015, 2016 Efraim Flashner <efraim@flashner.co.il>
>  ;;; Copyright © 2016 Christopher Allan Webber <cwebber@dustycloud.org>
> @@ -206,7 +206,10 @@ compatible to GNU Pth.")
>                                    ".tar.bz2"))
>                (sha256
>                 (base32
> -                "06mn2viiwsyq991arh5i5fhr9jyxq2bi0jkdj7ndfisxihngpc5p"))))
> +                "06mn2viiwsyq991arh5i5fhr9jyxq2bi0jkdj7ndfisxihngpc5p"))
> +              (patches
> +               (list (search-patch
> +                      "gnupg-simple-query-ignore-status-messages.patch")))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)))
> diff --git a/gnu/packages/patches/gnupg-simple-query-ignore-status-messages.patch b/gnu/packages/patches/gnupg-simple-query-ignore-status-messages.patch
> new file mode 100644
> index 0000000..153f71c
> --- /dev/null
> +++ b/gnu/packages/patches/gnupg-simple-query-ignore-status-messages.patch
> @@ -0,0 +1,142 @@
> +Copied from upstream:
> +http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=commitdiff;h=acac103ba5772ae738ce5409d17feab80596cde6
> +
> +Fixes: https://debbugs.gnu.org/22558
> +Upstream bug: https://bugs.gnupg.org/gnupg/issue2229
> +
> +From acac103ba5772ae738ce5409d17feab80596cde6 Mon Sep 17 00:00:00 2001
> +From: "Neal H. Walfield" <neal@g10code.com>
> +Date: Fri, 12 Feb 2016 22:12:21 +0100
> +Subject: [PATCH] common: Change simple_query to ignore status messages.
> +
> +* common/simple-pwquery.c (simple_query): Ignore status messages.
> +
> +--
> +Signed-off-by: Neal H. Walfield <neal@g10code.com>
> +GnuPG-bug-id: 2229
> +---
> + common/simple-pwquery.c | 95 ++++++++++++++++++++++++++++++++++---------------
> + 1 file changed, 67 insertions(+), 28 deletions(-)
> +
> +diff --git a/common/simple-pwquery.c b/common/simple-pwquery.c
> +index 90d04c0..b2d666c 100644
> +--- a/common/simple-pwquery.c
> ++++ b/common/simple-pwquery.c
> +@@ -618,6 +618,7 @@ simple_query (const char *query)
> +   int fd = -1;
> +   int nread;
> +   char response[500];
> ++  int have = 0;
> +   int rc;
> + 
> +   rc = agent_open (&fd);
> +@@ -628,40 +629,78 @@ simple_query (const char *query)
> +   if (rc)
> +     goto leave;
> + 
> +-  /* get response */
> +-  nread = readline (fd, response, 499);
> +-  if (nread < 0)
> +-    {
> +-      rc = -nread;
> +-      goto leave;
> +-    }
> +-  if (nread < 3)
> ++  while (1)
> +     {
> +-      rc = SPWQ_PROTOCOL_ERROR;
> +-      goto leave;
> +-    }
> ++      if (! have || ! strchr (response, '\n'))
> ++        /* get response */
> ++        {
> ++          nread = readline (fd, &response[have],
> ++                            sizeof (response) - 1 /* NUL */ - have);
> ++          if (nread < 0)
> ++            {
> ++              rc = -nread;
> ++              goto leave;
> ++            }
> ++          have += nread;
> ++          if (have < 3)
> ++            {
> ++              rc = SPWQ_PROTOCOL_ERROR;
> ++              goto leave;
> ++            }
> ++          response[have] = 0;
> ++        }
> + 
> +-  if (response[0] == 'O' && response[1] == 'K')
> +-    /* OK, do nothing.  */;
> +-  else if ((nread > 7 && !memcmp (response, "ERR 111", 7)
> +-            && (response[7] == ' ' || response[7] == '\n') )
> +-           || ((nread > 4 && !memcmp (response, "ERR ", 4)
> +-                && (strtoul (response+4, NULL, 0) & 0xffff) == 99)) )
> +-    {
> +-      /* 111 is the old Assuan code for canceled which might still
> +-         be in use by old installations. 99 is GPG_ERR_CANCELED as
> +-         used by modern gpg-agents; 0xffff is used to mask out the
> +-         error source.  */
> ++      if (response[0] == 'O' && response[1] == 'K')
> ++        /* OK, do nothing.  */;
> ++      else if ((nread > 7 && !memcmp (response, "ERR 111", 7)
> ++                && (response[7] == ' ' || response[7] == '\n') )
> ++               || ((nread > 4 && !memcmp (response, "ERR ", 4)
> ++                    && (strtoul (response+4, NULL, 0) & 0xffff) == 99)) )
> ++        {
> ++          /* 111 is the old Assuan code for canceled which might still
> ++             be in use by old installations. 99 is GPG_ERR_CANCELED as
> ++             used by modern gpg-agents; 0xffff is used to mask out the
> ++             error source.  */
> + #ifdef SPWQ_USE_LOGGING
> +-      log_info (_("canceled by user\n") );
> ++          log_info (_("canceled by user\n") );
> + #endif
> +-    }
> +-  else
> +-    {
> ++        }
> ++      else if (response[0] == 'S' && response[1] == ' ')
> ++        {
> ++          char *nextline;
> ++          int consumed;
> ++
> ++          nextline = strchr (response, '\n');
> ++          if (! nextline)
> ++            /* Point to the NUL.  */
> ++            nextline = &response[have];
> ++          else
> ++            /* Move past the \n.  */
> ++            nextline ++;
> ++
> ++          consumed = (size_t) nextline - (size_t) response;
> ++
> ++          /* Skip any additional newlines.  */
> ++          while (consumed < have && response[consumed] == '\n')
> ++            consumed ++;
> ++
> ++          have -= consumed;
> ++
> ++          if (have)
> ++            memmove (response, &response[consumed], have + 1);
> ++
> ++          continue;
> ++        }
> ++      else
> ++        {
> + #ifdef SPWQ_USE_LOGGING
> +-      log_error (_("problem with the agent\n"));
> ++          log_error (_("problem with the agent (unexpected response \"%s\"\n"),
> ++                     response);
> + #endif
> +-      rc = SPWQ_ERR_RESPONSE;
> ++          rc = SPWQ_ERR_RESPONSE;
> ++        }
> ++
> ++      break;
> +     }
> + 
> +  leave:
> +-- 
> +2.6.3
> +
> -- 
> 2.6.3
> 

bug#22558: gnupg-2.1.11 on x86_64 failed its tests many times on Hydra

[Mark H Weaver]

Leo Famulari <leo@famulari.name> writes:

> On Fri, Feb 12, 2016 at 06:22:46PM -0500, Mark H Weaver wrote:
>> ludo@gnu.org (Ludovic Courtès) writes:
>> 
>> > Eric Bavier <ericbavier@openmailbox.org> skribis:
>> >
>> >>> > * With 14 test failures.  This happened at least twice, on
>> >>> >   hydra.gnunet.org.
>> >>>
>> >>> Eric Bavier reported on #guix that it failed to build on his machine
>> >>> twice in a row, with 14 test failures.
>> >>
>> >> I used 'git bisect' on the gnupg repository to narrow the failures
>> >> down. Commit ee87c653bf is the commit that introduces the failures.
>> >
>> > Thanks for digging!  Could you report it upstream?
>> 
>> I reported it upstream, and now they have a fix in their repo.
>> I've attached a patch to Guix which adds this upstream patch.
>> 
>> Eric, would you be willing to test it and see if it fixes the problem
>> for you?
>
> I'm not Eric, but with this patch, I can successfully build on the
> machine that was previously exhibiting the failures.

Thanks!  I went ahead and pushed this to master, commit 3a7261bf96.
I'm closing this bug now.

      Mark

bug#22558: gnupg-2.1.11 on x86_64 failed its tests many times on Hydra

[Eric Bavier]

On Fri, 12 Feb 2016 21:13:55 -0500
Mark H Weaver <mhw@netris.org> wrote:

> Leo Famulari <leo@famulari.name> writes:
> 
> > On Fri, Feb 12, 2016 at 06:22:46PM -0500, Mark H Weaver wrote:
> >> ludo@gnu.org (Ludovic Courtès) writes:
> >> 
> >> > Eric Bavier <ericbavier@openmailbox.org> skribis:
> >> >
> >> >>> > * With 14 test failures.  This happened at least twice, on
> >> >>> >   hydra.gnunet.org.
> >> >>>
> >> >>> Eric Bavier reported on #guix that it failed to build on his machine
> >> >>> twice in a row, with 14 test failures.
> >> >>
> >> >> I used 'git bisect' on the gnupg repository to narrow the failures
> >> >> down. Commit ee87c653bf is the commit that introduces the failures.
> >> >
> >> > Thanks for digging!  Could you report it upstream?
> >> 
> >> I reported it upstream, and now they have a fix in their repo.
> >> I've attached a patch to Guix which adds this upstream patch.
> >> 
> >> Eric, would you be willing to test it and see if it fixes the problem
> >> for you?
> >
> > I'm not Eric, but with this patch, I can successfully build on the
> > machine that was previously exhibiting the failures.
> 
> Thanks!  I went ahead and pushed this to master, commit 3a7261bf96.
> I'm closing this bug now.

I realize I'm a bit late, but I just wanted to let you know that this
appears to fix the gnupg-2.1.11 build for me too:

@ build-succeeded /gnu/store/qyjrqxnrka55p5g5vh1p80ac1rxn5nfm-gnupg-2.1.11.drv -
/gnu/store/w6fbikpwzpjkwvy6z1hwbszq0x83yspv-gnupg-2.1.11

But I had to add "#:use-module (gnu packages)" to the
gnu/packages/gnupg.scm before it would build, otherwise "could not
find symbol search-path".

Cheers,
`~Eric

bug#22558: gnupg-2.1.11 on x86_64 failed its tests many times on Hydra

[Leo Famulari]

On Fri, Feb 12, 2016 at 10:02:32PM -0600, Eric Bavier wrote:
> On Fri, 12 Feb 2016 21:13:55 -0500
> Mark H Weaver <mhw@netris.org> wrote:
> 
> > Leo Famulari <leo@famulari.name> writes:
> > 
> > > On Fri, Feb 12, 2016 at 06:22:46PM -0500, Mark H Weaver wrote:
> > >> ludo@gnu.org (Ludovic Courtès) writes:
> > >> 
> > >> > Eric Bavier <ericbavier@openmailbox.org> skribis:
> > >> >
> > >> >>> > * With 14 test failures.  This happened at least twice, on
> > >> >>> >   hydra.gnunet.org.
> > >> >>>
> > >> >>> Eric Bavier reported on #guix that it failed to build on his machine
> > >> >>> twice in a row, with 14 test failures.
> > >> >>
> > >> >> I used 'git bisect' on the gnupg repository to narrow the failures
> > >> >> down. Commit ee87c653bf is the commit that introduces the failures.
> > >> >
> > >> > Thanks for digging!  Could you report it upstream?
> > >> 
> > >> I reported it upstream, and now they have a fix in their repo.
> > >> I've attached a patch to Guix which adds this upstream patch.
> > >> 
> > >> Eric, would you be willing to test it and see if it fixes the problem
> > >> for you?
> > >
> > > I'm not Eric, but with this patch, I can successfully build on the
> > > machine that was previously exhibiting the failures.
> > 
> > Thanks!  I went ahead and pushed this to master, commit 3a7261bf96.
> > I'm closing this bug now.
> 
> I realize I'm a bit late, but I just wanted to let you know that this
> appears to fix the gnupg-2.1.11 build for me too:
> 
> @ build-succeeded /gnu/store/qyjrqxnrka55p5g5vh1p80ac1rxn5nfm-gnupg-2.1.11.drv -
> /gnu/store/w6fbikpwzpjkwvy6z1hwbszq0x83yspv-gnupg-2.1.11
> 
> But I had to add "#:use-module (gnu packages)" to the
> gnu/packages/gnupg.scm before it would build, otherwise "could not
> find symbol search-path".

Weird, that did not happen to me when building from 3a7261bf96b2 on
x86_64 with a recent guix-daemon.

bug#22558: gnupg-2.1.11 on x86_64 failed its tests many times on Hydra

[Leo Famulari]

On Sat, Feb 13, 2016 at 02:41:18AM -0500, Leo Famulari wrote:
> On Fri, Feb 12, 2016 at 10:02:32PM -0600, Eric Bavier wrote:
> > On Fri, 12 Feb 2016 21:13:55 -0500
> > Mark H Weaver <mhw@netris.org> wrote:
> > 
> > > Leo Famulari <leo@famulari.name> writes:
> > > 
> > > > On Fri, Feb 12, 2016 at 06:22:46PM -0500, Mark H Weaver wrote:
> > > >> ludo@gnu.org (Ludovic Courtès) writes:
> > > >> 
> > > >> > Eric Bavier <ericbavier@openmailbox.org> skribis:
> > > >> >
> > > >> >>> > * With 14 test failures.  This happened at least twice, on
> > > >> >>> >   hydra.gnunet.org.
> > > >> >>>
> > > >> >>> Eric Bavier reported on #guix that it failed to build on his machine
> > > >> >>> twice in a row, with 14 test failures.
> > > >> >>
> > > >> >> I used 'git bisect' on the gnupg repository to narrow the failures
> > > >> >> down. Commit ee87c653bf is the commit that introduces the failures.
> > > >> >
> > > >> > Thanks for digging!  Could you report it upstream?
> > > >> 
> > > >> I reported it upstream, and now they have a fix in their repo.
> > > >> I've attached a patch to Guix which adds this upstream patch.
> > > >> 
> > > >> Eric, would you be willing to test it and see if it fixes the problem
> > > >> for you?
> > > >
> > > > I'm not Eric, but with this patch, I can successfully build on the
> > > > machine that was previously exhibiting the failures.
> > > 
> > > Thanks!  I went ahead and pushed this to master, commit 3a7261bf96.
> > > I'm closing this bug now.
> > 
> > I realize I'm a bit late, but I just wanted to let you know that this
> > appears to fix the gnupg-2.1.11 build for me too:
> > 
> > @ build-succeeded /gnu/store/qyjrqxnrka55p5g5vh1p80ac1rxn5nfm-gnupg-2.1.11.drv -
> > /gnu/store/w6fbikpwzpjkwvy6z1hwbszq0x83yspv-gnupg-2.1.11
> > 
> > But I had to add "#:use-module (gnu packages)" to the
> > gnu/packages/gnupg.scm before it would build, otherwise "could not
> > find symbol search-path".
> 
> Weird, that did not happen to me when building from 3a7261bf96b2 on
> x86_64 with a recent guix-daemon.

I do have a different output hash:
/gnu/store/bky2i5n7wvcnbzpxpnb4y5r5p795sc7v-gnupg-2.1.11

bug#22558: gnupg-2.1.11 on x86_64 failed its tests many times on Hydra

[Mark H Weaver]

Leo Famulari <leo@famulari.name> writes:

> On Fri, Feb 12, 2016 at 10:02:32PM -0600, Eric Bavier wrote:
>> But I had to add "#:use-module (gnu packages)" to the
>> gnu/packages/gnupg.scm before it would build, otherwise "could not
>> find symbol search-path".
>
> Weird, that did not happen to me when building from 3a7261bf96b2 on
> x86_64 with a recent guix-daemon.

Eric presumably applied the patch to an older git checkout.  It turns
out that #:use-module (gnu packages) was only added to gnupg.scm about a
week ago in commit a05d1d82c0.

      Mark