Re: [PATCH] gnu: Add laby.

[Andreas Enge <andreas@enge.fr>]

Hello,

On Thu, Feb 11, 2016 at 11:21:30PM +0100, Jan Nieuwenhuizen wrote:
> Ah... And also, ocaml-findlib was missing and lablgtk did not compile
> cmxa files, which laby needs.  So, three patches to get a running Laby.

> +   (native-search-paths
> +    (list (search-path-specification
> +           (variable "OCAMLPATH")
> +           (files (list (string-append "lib/ocaml"))))))

I have doubts about this search path. Normally, a search path is registered
with the program that needs it; for instance, gcc declares a LIBRARY_PATH,
and then whenever a program is installed that provides libraries, these are
added to the environment variable.

So I suppose the search path declaration should really be in the ocaml
package, and if lablgtk provides files matching the pattern, they will be
added and available for laby.

What do you think? If yes, this should be split into two patches.

(There are still minor things, like a missing copyright line, indentation
and so on; if you modify your patches anyway, you might widh to have a
second look.)

Andreas