From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH] gnu: Add tcllib. Date: Thu, 11 Feb 2016 22:42:21 +0200 Message-ID: <20160211224221.50b9af1b@debian-netbook> References: <87vb5xeiw8.fsf@gnu.org> <20160211215347.0aac83dd@debian-netbook> <20160211202833.GA11508@thebird.nl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/izSG7uZAUpRmaTI8At1yk+k"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTy4R-0003YX-P5 for guix-devel@gnu.org; Thu, 11 Feb 2016 15:42:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTy4N-0000cW-OF for guix-devel@gnu.org; Thu, 11 Feb 2016 15:42:35 -0500 In-Reply-To: <20160211202833.GA11508@thebird.nl> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Pjotr Prins Cc: guix-devel@gnu.org --Sig_/izSG7uZAUpRmaTI8At1yk+k Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 11 Feb 2016 21:28:33 +0100 Pjotr Prins wrote: > To all.=20 >=20 > Again, I think we have to be more careful with new committers. All > comments below are in the trivial category (in my opinion). >=20 > I appreciate the work reviewers are doing (thank you!), but we should > take care to be nice and welcoming so as not to lose people. I > personally think that the focus on spacing and indentation is way over > the top. Especially when you realise many packages in the tree are > not up to current standards. Anyone looked at python.scm? >=20 > Can we concentrate on functionality first. And when a package is > pretty much up to scratch just do the final editing by the actual > committer? >=20 > Ricardo give a great example here, he corrects and tells us. That way > we learn in a nice way. Submitting packages and abiding by all the > rules is not trivial. Not to mention that lint is sometimes broken and > there are many packages in the tree that do *not* abide by current > rules. I go wrong when I copy something already there. It is not that > easy. >=20 > We need to find a balance between being nice and being correct. >=20 > And don't forget: thank you Jan for the contributions :). Please > continue! We welcome you. >=20 > Pj. >=20 > On Thu, Feb 11, 2016 at 09:53:47PM +0200, Efraim Flashner wrote: >=20 Pjotr- thanks for the reminder :). I know we've been a bit behind on patch review and I jumped in a bit too much. Jan- I hope I haven't scared you off or discouraged you. Indeed, thank you for the patches. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Sig_/izSG7uZAUpRmaTI8At1yk+k Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJWvPItAAoJEPTB05F+rO6TD9EP/i+Fc3Znt3hGhkQ2Qcpc2yQ8 saTkuqrhy1qni+ZLmB0WzyXF3kIS7Ox/nVw+eLaD2FWvjiqRymSh0e4MvERPq21n JKPyz75BAa654lPF7/SXOa1E52Nvlk48vTvpqkpwXwucrJZmSxeegwu+3uOvix+e JWfwFT8fJE+HtHfaq79tYRbMudKkMRmBvUqb9Z6ffuk3pu+hbiaK+TSnzIdcbd07 hhslm2I5auTxRePG5HciUWN1quM9YTh1z/fniQTB6COfMe+YLKUntxbxU9RiMB+h Sh4xVZZ5quHgiwpoSMoS+LpIAAcfGusfL9V+FrFPI5rARIBNxVRAyp1r44ojK6Iz 1YCNaFo/p9HgVwUhXVSIT9Xn1Uw8Z1qD7qqCMtzxgF5LBgFrctLidQ+TlJm0pdAM SKTnvYsZ5u2nOLgK6PMDeMuuilwwUBpeLdvkwervOBqsCO54LnUHHSbbSmvsCgYF WO6HJeIKCA9vV2eq/tlGeluhTzdA9YFyKc4nk7UerHvrqwm9k6IPxtOMGfUBa2J9 kAkNU452niWZlZLQ7tuFqIUKcCrK332DLah4RweCvCvCB6t55nBSOBX/OC/eSUkA E59e/FvIo6PKRpkdbc5MLyxXBDKms3c77tgc/Rg7lHoduYfDPEIELMnbapxy54iN 07TR/hHztWVdlOWWOhdD =JINa -----END PGP SIGNATURE----- --Sig_/izSG7uZAUpRmaTI8At1yk+k--