From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH] gnu: Add tclxml. Date: Thu, 11 Feb 2016 22:10:06 +0200 Message-ID: <20160211221006.40c77212@debian-netbook> References: <87r3gleiu1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/N5XqGg9yexG25gaiRay/IyN"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTxZE-0002J3-SW for guix-devel@gnu.org; Thu, 11 Feb 2016 15:10:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTxZ9-0000sG-MO for guix-devel@gnu.org; Thu, 11 Feb 2016 15:10:20 -0500 In-Reply-To: <87r3gleiu1.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Jan Nieuwenhuizen Cc: guix-devel@gnu.org --Sig_/N5XqGg9yexG25gaiRay/IyN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 09 Feb 2016 21:20:54 +0100 Jan Nieuwenhuizen wrote: > From: Jan Nieuwenhuizen > To: guix-devel@gnu.org > Subject: [PATCH] gnu: Add tclxml. > Date: Tue, 09 Feb 2016 21:20:54 +0100 > Sender: guix-devel-bounces+efraim=3Dflashner.co.il@gnu.org > User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) > Organization: AvatarAcademy.nl >=20 > Hi, >=20 > Another tcl library package. >=20 > Greetings, Jan >=20 You also have to add the patch file to gnu-system.am so it gets picked up. >=20 > From 79f56d9c3f21e624ba9a3bfda00d2fc264796494 Mon Sep 17 00:00:00 2001 > From: Jan Nieuwenhuizen > Date: Tue, 9 Feb 2016 20:45:51 +0100 > Subject: [PATCH] gnu: Add tclxml. >=20 > * gnu/packages/tcl.scm (tclxml): New variable. > * gnu/packages/patches/tclxml-3.2-install.patch: New file. > --- > gnu/packages/patches/tclxml-3.2-install.patch | 23 +++++++++++++ > gnu/packages/tcl.scm | 47 +++++++++++++++++++++= ++++-- > 2 files changed, 68 insertions(+), 2 deletions(-) > create mode 100644 gnu/packages/patches/tclxml-3.2-install.patch >=20 > diff --git a/gnu/packages/patches/tclxml-3.2-install.patch b/gnu/packages= /patches/tclxml-3.2-install.patch > new file mode 100644 > index 0000000..63542aa > --- /dev/null > +++ b/gnu/packages/patches/tclxml-3.2-install.patch > @@ -0,0 +1,23 @@ > +--- ./Makefile.in~ 2016-02-06 01:29:16.595090365 +0100 > ++++ ./Makefile.in 2016-02-06 09:29:04.286008931 +0100 > +@@ -76,7 +76,7 @@ > +=20 > + srcdir =3D @srcdir@ > + prefix =3D @prefix@ > +-exec_prefix =3D @exec_prefix@ > ++exec_prefix =3D @prefix@ > +=20 > + bindir =3D @bindir@ > + libdir =3D @libdir@ > +@@ -133,9 +133,9 @@ > + # require for testing here (like TCLX_LIBRARY). > + #=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +=20 > +-EXTRA_PATH =3D $(top_builddir):$(TCL_BIN_DIR) > ++EXTRA_PATH =3D $(top_builddir):$(TCL_BIN_DIR):$(libdir) > + #EXTRA_PATH =3D $(top_builddir):$(TCL_BIN_DIR):$(TK_BIN_DIR) > +-TCLLIBPATH =3D $(top_builddir) > ++TCLLIBPATH =3D $(pkglibdir) > + TCLSH_ENV =3D TCL_LIBRARY=3D`@CYGPATH@ $(TCL_SRC_DIR)/library` \ > + @LD_LIBRARY_PATH_VAR@=3D"$(EXTRA_PATH):$(@LD_LIBRARY_PATH_VAR@)" \ > + PATH=3D"$(EXTRA_PATH):$(PATH)" \ > diff --git a/gnu/packages/tcl.scm b/gnu/packages/tcl.scm > index 8d6059d..101b8f8 100644 > --- a/gnu/packages/tcl.scm > +++ b/gnu/packages/tcl.scm > @@ -30,6 +30,7 @@ > #:use-module (gnu packages fontutils) > #:use-module (gnu packages perl) > #:use-module (gnu packages pkg-config) > + #:use-module (gnu packages xml) > #:use-module (gnu packages xorg) > #:use-module (guix licenses)) > =20 > @@ -248,5 +249,47 @@ interfaces (GUIs) in the Tcl language.") > (license (non-copyleft "http://www.tcl.tk/software/tcltk/license.htm= l" > "Tcl/Tk license")))) > =20 > - > - > +(define-public tclxml > + (package > + (name "tclxml") > + (version "3.2") > + (source (origin > + (method url-fetch) > + (uri (string-append "mirror://sourceforge/" name "/" > + name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "0ffb4aw63inig3aql33g4pk0kjk14dv238anp1scwjdjh1k6n4gl")) > + (patches (list (search-patch (string-append (getenv "HOME") "/dev= elopment.git/tclxml-3.2-install.patch")))))) this line should be (patches (search-path "tclxml-3.2-install.patch")))) (I think, check other packages with patches) > + (build-system gnu-build-system) > + (native-inputs > + `(("tcl" ,tcl) > + ("tcllib" ,tcllib) > + ("libxml2" ,libxml2) > + ("libxslt" ,libxslt))) > + (native-search-paths this line should line up with the others like (native-inputs. It looks like it also threw off (arguments > + (list (search-path-specification > + (variable "TCLLIBPATH") > + (separator " ") > + (files (list (string-append "lib/Tclxml" version)))))) I don't think this needs to be a list. Also, (variable, (separator and (file should line up with the "e" in (search > + (arguments > + `(#:configure-flags > + (list (string-append "--with-tclconfig=3D" > + (assoc-ref %build-inputs "tcl") > + "/lib") line these two lines up with the "-- the two following string-appends should line up with the above string-append > + (string-append "--with-xml2-config=3D" > + (assoc-ref %build-inputs "libxml2") > + "/bin/xml2-config") > + (string-append "--with-xslt-config=3D" > + (assoc-ref %build-inputs "libxslt") > + "/bin/xslt-config")) > + #:phases (modify-phases %standard-phases > + (delete 'check)))) normally we put #:tests? #f, with a reason why. Are there no tests? Do they fail unexpectedly? > + (home-page "http://tclxml.sourceforge.net/") > + (synopsis " Tcl library for XML parsing") ^ extra space > + (description " TclXML provides event-based parsing of XML documents.= The ^ extra space > + application may register callback scripts for certain document > + features, and when the parser encounters those features while parsing > + the document the callback is evaluated.") > + (license (non-copyleft "http://sourcesdev.debian.net/copyright/licen= se/tclxml/3.2-1/" this line is too long. Also, is there a spot on their website that lists the license? If not, it'd be better to point to a file in the tarball. > + "")))) make sure you run guix lint, there are several spaces where you use tabs an= d we only use spaces --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Sig_/N5XqGg9yexG25gaiRay/IyN Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJWvOqfAAoJEPTB05F+rO6Tr1YP/A+1zYrDYACXX1/iDIYVXX+H iu3nzH+eRLAJxUYu4aeTAnjjM6abaaazito8rLlMcDxG4ddtfOKVNFxxRhQjwZ35 6ip4aXIV0nIezTm52U1LxUPoDao/6qW+sxgO1pZL6s3ShLCJkxrZS+YPDbbRijY5 Ggju9S6hcEgSp/m+7F5z+JSIhjMZj6u640dvssqWe0EvWf6BzOaI59txabjD7z+z X3GWthW28EwxdMliotKJhOsD3fPfVCVrPc7krLvCqnk9zI/p0Naypwl2YsTNJhns P0Yp/vKoiXuorFymyp4dFkg1aXIXh3xUbBLBsYa2+q9BSu0xw2VZJrQ3idDWTkd5 6ZriZ67dPAla2Yxvbr/eb6507kt4krbVDn72p7ltW2dtDR37aslA3PuOw7Im2cPF 2GBlIEuAna9ZZO3o8KBd0peFtxuD5bwVJfWW9hUxZx5TLvHHW/GlRdS69MrQiDBq 2GDpCIzG9HVCblLFauXn8voBur7NNLgLWkQ0F5eHap3ybV8pg8dqI0EyfWXGioGJ qes1xNEjLEFUKgKEi3ciVY/L7yq4BWtJ8K5naU7F88Qkh4/k0CSSWXOfK5hws1YP SQ9XSApEnmVEPCG5nOJI2U0059aX3eI/6A5Am16mAj8pDnB1DMFsFlIGL6Jy19sw K3g6WBIjFzzeuP5QHnXL =pci5 -----END PGP SIGNATURE----- --Sig_/N5XqGg9yexG25gaiRay/IyN--