Re: [PATCH 1/5] gnu: Add mate-icon-theme.

[Fabian Harfert <fhmgufs@web.de>]

On Thu, 11 Feb 2016 22:43:56 +0200
Efraim Flashner <efraim@flashner.co.il>wrote :

> On Wed, 10 Feb 2016 00:00:20 +0100
> Fabian Harfert <fhmgufs@web.de> wrote:
> 
> > * gnu/packages/mate.scm: New file.
> > * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> > * gnu/packages/mate.scm (mate-icon-theme): New variable.
> > ---
> >  gnu-system.am         |  1 +
> >  gnu/packages/mate.scm | 53
> > +++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files
> > changed, 54 insertions(+) create mode 100644 gnu/packages/mate.scm
> > 
> > diff --git a/gnu-system.am b/gnu-system.am
> > index 4d32e59..5083206 100644
> > --- a/gnu-system.am
> > +++ b/gnu-system.am
> > @@ -215,6 +215,7 @@ GNU_SYSTEM_MODULES
> > =				\
> > gnu/packages/mail.scm				\
> > gnu/packages/make-bootstrap.scm		\
> > gnu/packages/markdown.scm			\
> > +  gnu/packages/mate.scm       \
> >    gnu/packages/maths.scm			\
> >    gnu/packages/mc.scm				\
> >    gnu/packages/mcrypt.scm			\
> > diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm
> > new file mode 100644
> > index 0000000..d8242d6
> > --- /dev/null
> > +++ b/gnu/packages/mate.scm
> > @@ -0,0 +1,53 @@
> > +;;; GNU Guix --- Functional package management for GNU
> > +;;; Copyright © 2016 Fabian Harfert <fhmgufs@web.de>
> > +;;;
> > +;;; This file is part of GNU Guix.
> > +;;;
> > +;;; GNU Guix is free software; you can redistribute it and/or
> > modify it +;;; under the terms of the GNU General Public License as
> > published by +;;; the Free Software Foundation; either version 3 of
> > the License, or (at +;;; your option) any later version.
> > +;;;
> > +;;; GNU Guix is distributed in the hope that it will be useful, but
> > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > +;;; GNU General Public License for more details.
> > +;;;
> > +;;; You should have received a copy of the GNU General Public
> > License +;;; along with GNU Guix.  If not, see
> > <http://www.gnu.org/licenses/>. +
> > +(define-module (gnu packages mate)
> > +  #:use-module ((guix licenses) #:prefix license:)
> > +  #:use-module (guix packages)
> > +  #:use-module (guix download)
> > +  #:use-module (guix utils)
> > +  #:use-module (guix build-system gnu)
> > +  #:use-module (gnu packages)
> > +  #:use-module (gnu packages pkg-config)
> > +  #:use-module (gnu packages glib)
> > +  #:use-module (gnu packages gtk)
> > +  #:use-module (gnu packages gnome))
> > +
> > +(define-public mate-icon-theme
> > +  (package
> > +    (name "mate-icon-theme")
> > +    (version "1.12.0")
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append
> > "http://pub.mate-desktop.org/releases/"
> > +                                  (version-major+minor version) "/"
> > +                                  name "-" version ".tar.xz"))
> > +              (sha256
> > +               (base32
> > +
> > "0d91rvl9rw3xl8hmdcbb6xvi880kfmh2ra5chhrjimrjqgl57qkp"))))
> > +    (build-system gnu-build-system)
> > +    (native-inputs
> > +     `(("pkg-config" ,pkg-config)
> > +       ("intltool" ,intltool)
> > +       ("gtk+" ,gtk+)
> > +       ("icon-naming-utils" ,icon-naming-utils)))  
> 
> Do the last 3 native-inputs need to be native-inputs or are regular
> inputs sufficient?

Yes, they are needed at build time.

> 
> > +    (home-page "http://mate-desktop.org/")
> > +    (synopsis "The MATE desktop environment icon theme")
> > +    (description
> > +     "This package contains the default icon theme used by the
> > MATE desktop.")
> > +    (license license:lgpl3+)))  
> 
> Otherwise it looks good.
>