Re: [PATCH 1/3] gnu: iproute: Use 'modify-phases'.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 1971 bytes --]

On Thu, 11 Feb 2016 14:03:17 +0300
Alex Kost <alezost@gmail.com> wrote:

> * gnu/packages/linux.scm (iproute)[arguments]: Use 'modify-phases'.
> ---
>  gnu/packages/linux.scm | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index e7f7bcd..a6e3ec9 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -7,6 +7,7 @@
>  ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
>  ;;; Copyright © 2015, 2016 Efraim Flashner <efraim@flashner.co.il>
>  ;;; Copyright © 2016 Christopher Allan Webber <cwebber@dustycloud.org>
> +;;; Copyright © 2016 Alex Kost <alezost@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -887,13 +888,12 @@ packet filter.")
>                              (string-append "DOCDIR=" out "/share/doc/"
>                                             ,name "-" ,version)
>                              (string-append "MANDIR=" out "/share/man")))
> -       #:phases (alist-cons-before
> -                 'install 'pre-install
> -                 (lambda _
> -                   ;; Don't attempt to create /var/lib/arpd.
> -                   (substitute* "Makefile"
> -                     (("^.*ARPDDIR.*$") "")))
> -                 %standard-phases)))
> +       #:phases (modify-phases %standard-phases
> +                  (add-before 'install 'pre-install
> +                    (lambda _
> +                      ;; Don't attempt to create /var/lib/arpd.
> +                      (substitute* "Makefile"
> +                        (("^.*ARPDDIR.*$") "")))))))
>      (inputs
>       `(("iptables" ,iptables)
>         ("db4" ,bdb)))

LGTM!

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]