Re: [PATCH] gnu: Add pass.

[Andreas Enge <andreas@enge.fr>]

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

Hello!

On Mon, Feb 08, 2016 at 11:27:44PM +0100, Jessica Tallon wrote:
> I've finally got around to packaging the pass password manager.

That sounds interesting. Now I just wonder which password manager I would
prefer to use...

A few comments in addition to those already made.
As to the name, this is unclear; upstream uses "pass" a lot, so it could be
argued that it should be "pass". If in doubt, we go with the upstream tarball
name, and that is what I would do here.

I tried to build with gnupg-2.0 to make the tests pass, but this is not
enough.

I added a copyright line for you.

I would suggest a slightly modified description.

Adding util-linux to the native-inputs as suggested by Ludovic gets the
tests further: something happens at least, but they fail.

Since I tried out a few things, I realised I might as well send you my
modified version of the patch. Maybe you could continue from there and
examine the tests. If you are not happy with some of my modifications,
please feel free to discuss them.

Andreas


[-- Attachment #2: 0001-gnu-Add-password-store.patch --]
[-- Type: text/plain, Size: 3351 bytes --]

From f18ee39a7a486d472886de700e090b1313939173 Mon Sep 17 00:00:00 2001
From: Jessica Tallon <tsyesika@tsyesika.se>
Date: Mon, 8 Feb 2016 22:12:50 +0100
Subject: [PATCH] gnu: Add password-store.

* gnu/packages/password-utils.scm (password-store): New variable.

Co-authored-by: Andreas Enge <andreas@enge.fr>
---
 gnu/packages/password-utils.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index 7c128a3..b8b5663 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -3,6 +3,8 @@
 ;;; Copyright © 2015, 2016 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2015 Aljosha Papsch <misc@rpapsch.de>
 ;;; Copyright © 2016 Christopher Allan Webber <cwebber@dustycloud.org>
+;;; Copyright © 2016 Jessica Tallon <tsyesika@tsyesika.se>
+;;; Copyright © 2016 Andreas Enge <andreas@enge.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -25,16 +27,19 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix download)
   #:use-module (guix packages)
+  #:use-module (gnu packages admin)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages guile)
+  #:use-module (gnu packages linux)
   #:use-module (gnu packages man)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages qt)
+  #:use-module (gnu packages version-control)
   #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xorg)
   #:use-module (guix build-system python))
@@ -241,3 +246,37 @@ JSON files.  It has a command line interface as well as a very simple
 graphical interface, which can even \"type\" your passwords into
 any X11 window.")
     (license license:gpl3+)))
+
+(define-public password-store
+  (package
+    (name "password-store")
+    (version "1.6.5")
+    (source (origin
+              (method url-fetch)
+              (uri
+               (string-append "https://git.zx2c4.com/password-store/snapshot/"
+                              name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "05bk3lrp5jwg0v338lvylp7glpliydzz4jf5pjr6k3kagrv3jyik"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:phases
+       (alist-delete 'configure %standard-phases)
+       #:make-flags (list "CC=gcc" (string-append "PREFIX=" %output))
+       #:test-target "test"))
+    (native-inputs `(("util-linux" ,util-linux))) ; getopt for the tests
+    (inputs `(("gnupg" ,gnupg)
+              ("pwgen" ,pwgen)
+              ("xclip" ,xclip)
+              ("git" ,git)
+              ("tree" ,tree)))
+    (home-page "http://www.passwordstore.org/")
+    (synopsis "Encrypted password manager")
+    (description "Password-store is a password manager which uses GnuPG to
+store and retrieve passwords.  The tool stores each password in its own
+GnuPG-encrypted file, allowing the program to be simple yet
+secure.  Synchronization is possible using the integrated git support, which
+commits changes to your password database to a git repository that can be
+managed through the pass command.")
+    (license license:gpl2+)))
-- 
2.6.3