Re: [PATCH] gnu: Add pass.

[Leo Famulari <leo@famulari.name>]

On Mon, Feb 08, 2016 at 11:27:44PM +0100, Jessica Tallon wrote:
> * gnu/packages/password-utils.scm (pass): New variable.

Thanks!

[...]

> +    (arguments
> +     '(#:phases
> +       (alist-delete 'configure %standard-phases)
> +       #:make-flags (list "CC=gcc" (string-append "PREFIX=" %output))
> +       ;; The tests mysteriously hang, I've tired it outside of guix and
> +       ;; they run perfectly fine. Not sure why so for now I've disabled
> +       ;; them.
> +       #:tests? #f

It may be worth taking the time to figure out why the test suite fails.
My understanding of this password manager is that you can always use
gnupg to decrypt the files without the password manager, but I still
think it would be best for a password manager to be able to pass its
test suite. I'd hate for some user who was not proficient with gnupg to
get locked out of their accounts because our pass package was somehow
broken.

> +       #:test-target "test"))
> +    (inputs `(("gnupg" ,gnupg)

Does it matter which version of gnupg is used? We package the 3 branches
of it described here: https://gnupg.org/

> +              ("pwgen" ,pwgen)
> +              ("xclip" ,xclip)
> +              ("git" ,git)
> +              ("tree" ,tree)))
> +    (home-page "http://www.passwordstore.org/")
> +    (synopsis "Encrypted password manager")
> +    (description "Pass is a password manager which uses gnupg to store, retrieve
> +generated passwords.  The tool stores each password in its own file gpg
> +encrypted allowing the program to be simple yet secure.  Synchronization is
> +possible with inbuild git support which commits changes to your password database

This line should be ≤ 80 characters.

> +to a git repository that can be managed through the pass command.")
> +    (license license:gpl2+)))
> -- 
> 2.6.3
>