* [PATCH 04/04] gnu: Add assword
@ 2016-02-06 3:49 Christopher Allan Webber
2016-02-06 5:08 ` Eric Bavier
2016-02-07 16:48 ` Mathieu Lirzin
0 siblings, 2 replies; 6+ messages in thread
From: Christopher Allan Webber @ 2016-02-06 3:49 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 10 bytes --]
Finally!
[-- Attachment #2: 0004-gnu-Add-assword.patch --]
[-- Type: text/x-patch, Size: 3405 bytes --]
From ae7427c9863b12281e4b23297f4c241548aa0d40 Mon Sep 17 00:00:00 2001
From: Christopher Allan Webber <cwebber@dustycloud.org>
Date: Fri, 5 Feb 2016 19:18:41 -0800
Subject: [PATCH 4/4] gnu: Add assword
* gnu/packages/password-utils (assword): New variable.
---
gnu/packages/password-utils.scm | 48 ++++++++++++++++++++++++++++++++++++++++-
1 file changed, 47 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index 9cd4846..41f32ef 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -2,6 +2,7 @@
;;; Copyright © 2015 Steve Sprang <scs@stevesprang.com>
;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2015 Aljosha Papsch <misc@rpapsch.de>
+;;; Copyright © 2016 Christopher Allan Webber <cwebber@dustycloud.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -26,13 +27,17 @@
#:use-module (guix packages)
#:use-module (gnu packages compression)
#:use-module (gnu packages gnupg)
+ #:use-module (gnu packages gtk)
#:use-module (gnu packages guile)
+ #:use-module (gnu packages man)
#:use-module (gnu packages ncurses)
#:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages python)
#:use-module (gnu packages tls)
#:use-module (gnu packages qt)
#:use-module (gnu packages xdisorg)
- #:use-module (gnu packages xorg))
+ #:use-module (gnu packages xorg)
+ #:use-module (guix build-system python))
(define-public pwgen
(package
@@ -185,3 +190,44 @@ passwords that could be guessed by crack by filtering them out, at source.")
"Libpwquality is a library for password quality checking and generation of
random passwords that pass the checks.")
(license license:gpl2+)))
+
+(define-public assword
+ (package
+ (name "assword")
+ (version "0.8")
+ (source (origin
+ (method url-fetch)
+ (uri (list
+ (string-append
+ "http://http.debian.net/debian/pool/main/a/assword/"
+ "assword_" version ".orig.tar.gz")))
+ (sha256
+ (base32
+ "0dl4wizbi0r21wxzykm8s445xbvqim5nabi799dmpkdnnh8i546i"))))
+ (arguments
+ `(#:python ,python-2
+ #:tests? #f
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'install 'manpage
+ (lambda* (#:key outputs #:allow-other-keys)
+ (zero? (system* "make" "assword.1"))
+ (install-file
+ "assword.1"
+ (string-append (assoc-ref outputs "out") "/share/man/man1")))))))
+ (build-system python-build-system)
+ (inputs
+ `(("python-setuptools" ,python2-setuptools)
+ ("python2-xdo" ,python2-xdo)
+ ("python2-pygpgme" ,python2-pygpgme)
+ ("python2-pygtk" ,python2-pygtk)
+ ("help2man" ,help2man)))
+ (propagated-inputs
+ `(("xclip" ,xclip)))
+ (home-page "https://finestructure.net/assword/")
+ (synopsis "Simple and secure password management system")
+ (description "assword is a simple password manager using GPG-wrapped
+json files. It has a command line interface as well as a very simple
+graphical interface, which can even \"type\" your passwords into
+any x11 window.")
+ (license license:gpl3+)))
--
2.6.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 04/04] gnu: Add assword
2016-02-06 3:49 [PATCH 04/04] gnu: Add assword Christopher Allan Webber
@ 2016-02-06 5:08 ` Eric Bavier
2016-02-06 23:28 ` Christopher Allan Webber
2016-02-07 16:48 ` Mathieu Lirzin
1 sibling, 1 reply; 6+ messages in thread
From: Eric Bavier @ 2016-02-06 5:08 UTC (permalink / raw)
To: Christopher Allan Webber; +Cc: guix-devel
On Fri, 05 Feb 2016 19:49:30 -0800
Christopher Allan Webber <cwebber@dustycloud.org> wrote:
> * gnu/packages/password-utils (assword): New variable.
> ---
> gnu/packages/password-utils.scm | 48 ++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 47 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
[...]
> +(define-public assword
> + (package
> + (name "assword")
> + (version "0.8")
> + (source (origin
> + (method url-fetch)
> + (uri (list
> + (string-append
> + "http://http.debian.net/debian/pool/main/a/assword/"
> + "assword_" version ".orig.tar.gz")))
> + (sha256
> + (base32
> + "0dl4wizbi0r21wxzykm8s445xbvqim5nabi799dmpkdnnh8i546i"))))
> + (arguments
> + `(#:python ,python-2
> + #:tests? #f
Could you add a comment saying why the tests are disabled, even if
just "no tests"?
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'install 'manpage
> + (lambda* (#:key outputs #:allow-other-keys)
> + (zero? (system* "make" "assword.1"))
> + (install-file
> + "assword.1"
> + (string-append (assoc-ref outputs "out") "/share/man/man1")))))))
You might need to wrap the two steps of this procedure in an "and" so
that the value of the "(zero? (system* ...))" isn't lost.
> + (build-system python-build-system)
> + (inputs
> + `(("python-setuptools" ,python2-setuptools)
> + ("python2-xdo" ,python2-xdo)
> + ("python2-pygpgme" ,python2-pygpgme)
> + ("python2-pygtk" ,python2-pygtk)
> + ("help2man" ,help2man)))
If help2man is only needed for manpage generation it would be best in
native-inputs.
> + (propagated-inputs
> + `(("xclip" ,xclip)))
> + (home-page "https://finestructure.net/assword/")
> + (synopsis "Simple and secure password management system")
Perhaps just "Password manager"?
> + (description "assword is a simple password manager using GPG-wrapped
> +json files. It has a command line interface as well as a very simple
> +graphical interface, which can even \"type\" your passwords into
> +any x11 window.")
s/json/JSON/;s/x11/X11/
Otherwise LGTM!
Thanks,
`~Eric
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 04/04] gnu: Add assword
2016-02-06 5:08 ` Eric Bavier
@ 2016-02-06 23:28 ` Christopher Allan Webber
0 siblings, 0 replies; 6+ messages in thread
From: Christopher Allan Webber @ 2016-02-06 23:28 UTC (permalink / raw)
To: Eric Bavier; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 1303 bytes --]
Eric Bavier writes:
>> +(define-public assword
>> + (package
>> + (name "assword")
>> + (version "0.8")
>> + (source (origin
>> + (method url-fetch)
>> + (uri (list
>> + (string-append
>> + "http://http.debian.net/debian/pool/main/a/assword/"
>> + "assword_" version ".orig.tar.gz")))
>> + (sha256
>> + (base32
>> + "0dl4wizbi0r21wxzykm8s445xbvqim5nabi799dmpkdnnh8i546i"))))
>> + (arguments
>> + `(#:python ,python-2
>> + #:tests? #f
>
> Could you add a comment saying why the tests are disabled, even if
> just "no tests"?
I left a comment. It's kind of an embarassing admission: the tests fail
because of an environment variable issue where the "gtk" module isn't
found. I find this even as a user of assword: I've had to log out and
back in again in order for the gtk module to be found after installing
Guix, even though this makes no sense.
Not sure what to say about that... or if anyone has an ideas! But
anyway, with that caveat above, assword is now working for me in GuixSD
and is a delight (and has allowed me to finally make GuixSD my host
distro).
Anyway, everything else is done, new patch attached, etc. Good to
merge?
- Chris
[-- Attachment #2: 0004-gnu-Add-assword.patch --]
[-- Type: text/x-patch, Size: 3986 bytes --]
From 990ae891e76e04b6b93b73a1698933ea5cc3afca Mon Sep 17 00:00:00 2001
From: Christopher Allan Webber <cwebber@dustycloud.org>
Date: Fri, 5 Feb 2016 19:18:41 -0800
Subject: [PATCH 3/3] gnu: Add assword
* gnu/packages/password-utils (assword): New variable.
---
gnu/packages/password-utils.scm | 58 ++++++++++++++++++++++++++++++++++++++++-
1 file changed, 57 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index 9cd4846..12bd027 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -2,6 +2,7 @@
;;; Copyright © 2015 Steve Sprang <scs@stevesprang.com>
;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2015 Aljosha Papsch <misc@rpapsch.de>
+;;; Copyright © 2016 Christopher Allan Webber <cwebber@dustycloud.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -26,13 +27,17 @@
#:use-module (guix packages)
#:use-module (gnu packages compression)
#:use-module (gnu packages gnupg)
+ #:use-module (gnu packages gtk)
#:use-module (gnu packages guile)
+ #:use-module (gnu packages man)
#:use-module (gnu packages ncurses)
#:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages python)
#:use-module (gnu packages tls)
#:use-module (gnu packages qt)
#:use-module (gnu packages xdisorg)
- #:use-module (gnu packages xorg))
+ #:use-module (gnu packages xorg)
+ #:use-module (guix build-system python))
(define-public pwgen
(package
@@ -185,3 +190,54 @@ passwords that could be guessed by crack by filtering them out, at source.")
"Libpwquality is a library for password quality checking and generation of
random passwords that pass the checks.")
(license license:gpl2+)))
+
+(define-public assword
+ (package
+ (name "assword")
+ (version "0.8")
+ (source (origin
+ (method url-fetch)
+ (uri (list
+ (string-append
+ "http://http.debian.net/debian/pool/main/a/assword/"
+ "assword_" version ".orig.tar.gz")))
+ (sha256
+ (base32
+ "0dl4wizbi0r21wxzykm8s445xbvqim5nabi799dmpkdnnh8i546i"))))
+ (arguments
+ `(#:python ,python-2
+ ;; irritatingly, tests do run but not there are two problems:
+ ;; - "import gtk" fails for unknown reasons here despite it the
+ ;; program working (indeed, I've found I have to do a logout and log
+ ;; back in in after an install order for some mumbo jumbo environment
+ ;; variable mess to work with pygtk and assword... what's up with
+ ;; that?)
+ ;; - even when the tests fail, they don't return a nonzero status,
+ ;; so I'm not sure how to programmatically get that information
+ #:tests? #f
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'install 'manpage
+ (lambda* (#:key outputs #:allow-other-keys)
+ (and
+ (zero? (system* "make" "assword.1"))
+ (install-file
+ "assword.1"
+ (string-append (assoc-ref outputs "out") "/share/man/man1"))))))))
+ (build-system python-build-system)
+ (native-inputs
+ `(("help2man" ,help2man)))
+ (inputs
+ `(("python-setuptools" ,python2-setuptools)
+ ("python2-xdo" ,python2-xdo)
+ ("python2-pygpgme" ,python2-pygpgme)
+ ("python2-pygtk" ,python2-pygtk)))
+ (propagated-inputs
+ `(("xclip" ,xclip)))
+ (home-page "https://finestructure.net/assword/")
+ (synopsis "Password manager")
+ (description "assword is a simple password manager using GPG-wrapped
+JSON files. It has a command line interface as well as a very simple
+graphical interface, which can even \"type\" your passwords into
+any X11 window.")
+ (license license:gpl3+)))
--
2.6.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 04/04] gnu: Add assword
2016-02-06 3:49 [PATCH 04/04] gnu: Add assword Christopher Allan Webber
2016-02-06 5:08 ` Eric Bavier
@ 2016-02-07 16:48 ` Mathieu Lirzin
2016-02-07 17:04 ` Christopher Allan Webber
1 sibling, 1 reply; 6+ messages in thread
From: Mathieu Lirzin @ 2016-02-07 16:48 UTC (permalink / raw)
To: Christopher Allan Webber; +Cc: guix-devel
Christopher Allan Webber <cwebber@dustycloud.org> writes:
>From ae7427c9863b12281e4b23297f4c241548aa0d40 Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Fri, 5 Feb 2016 19:18:41 -0800
> Subject: [PATCH 4/4] gnu: Add assword
^^^
with a dot.
>
> * gnu/packages/password-utils (assword): New variable.
^^^
“.scm”
:)
--
Mathieu Lirzin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 04/04] gnu: Add assword
2016-02-07 16:48 ` Mathieu Lirzin
@ 2016-02-07 17:04 ` Christopher Allan Webber
2016-02-07 23:01 ` Christopher Allan Webber
0 siblings, 1 reply; 6+ messages in thread
From: Christopher Allan Webber @ 2016-02-07 17:04 UTC (permalink / raw)
To: Mathieu Lirzin; +Cc: guix-devel
Mathieu Lirzin writes:
> Christopher Allan Webber <cwebber@dustycloud.org> writes:
>
>>From ae7427c9863b12281e4b23297f4c241548aa0d40 Mon Sep 17 00:00:00 2001
>> From: Christopher Allan Webber <cwebber@dustycloud.org>
>> Date: Fri, 5 Feb 2016 19:18:41 -0800
>> Subject: [PATCH 4/4] gnu: Add assword
> ^^^
> with a dot.
>
>>
>> * gnu/packages/password-utils (assword): New variable.
> ^^^
> “.scm”
>
> :)
Ah right, I've fixed this locally.
Anything else on this or python2-xdo, or should I push?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 04/04] gnu: Add assword
2016-02-07 17:04 ` Christopher Allan Webber
@ 2016-02-07 23:01 ` Christopher Allan Webber
0 siblings, 0 replies; 6+ messages in thread
From: Christopher Allan Webber @ 2016-02-07 23:01 UTC (permalink / raw)
To: Mathieu Lirzin; +Cc: guix-devel
Christopher Allan Webber writes:
> Mathieu Lirzin writes:
>
>> Christopher Allan Webber <cwebber@dustycloud.org> writes:
>>
>>>From ae7427c9863b12281e4b23297f4c241548aa0d40 Mon Sep 17 00:00:00 2001
>>> From: Christopher Allan Webber <cwebber@dustycloud.org>
>>> Date: Fri, 5 Feb 2016 19:18:41 -0800
>>> Subject: [PATCH 4/4] gnu: Add assword
>> ^^^
>> with a dot.
>>
>>>
>>> * gnu/packages/password-utils (assword): New variable.
>> ^^^
>> “.scm”
>>
>> :)
>
> Ah right, I've fixed this locally.
>
> Anything else on this or python2-xdo, or should I push?
I didn't hear any further objections, and I got feedback on python2-xdo,
so, pushed both! Have fun using assword!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-07 23:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-06 3:49 [PATCH 04/04] gnu: Add assword Christopher Allan Webber
2016-02-06 5:08 ` Eric Bavier
2016-02-06 23:28 ` Christopher Allan Webber
2016-02-07 16:48 ` Mathieu Lirzin
2016-02-07 17:04 ` Christopher Allan Webber
2016-02-07 23:01 ` Christopher Allan Webber
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.