* [PATCH] gnu: Add sdparm.
2016-02-02 0:20 Add sdparm SCSI command utility tobias.geerinckx.rice
@ 2016-02-02 0:20 ` tobias.geerinckx.rice
0 siblings, 0 replies; 10+ messages in thread
From: tobias.geerinckx.rice @ 2016-02-02 0:20 UTC (permalink / raw
To: guix-devel
From: Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
* gnu/packages/disk.scm (sdparm): New variable.
---
gnu/packages/disk.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index d806e0c..6e824d2 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -2,6 +2,7 @@
;;; Copyright © 2012, 2013 Nikita Karetnikov <nikita@karetnikov.org>
;;; Copyright © 2015 Mathieu Lirzin <mthl@gnu.org>
;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2016 Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -144,3 +145,29 @@ to recover data more efficiently by only reading the necessary blocks.")
"The dosfstools package includes the mkfs.fat and fsck.fat utilities,
which respectively make and check MS-DOS FAT filesystems.")
(license gpl3+)))
+
+(define-public sdparm
+ (package
+ (name "sdparm")
+ (version "1.09")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "http://sg.danny.cz/sg/p/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0jakqyjwi72zqjzss04bally0xl0lc4710mx8da08vpmir1hfphg"))))
+ (build-system gnu-build-system)
+ (home-page "http://sg.danny.cz/sg/sdparm.html")
+ (synopsis "Access to SCSI device parameters")
+ (description "Sdparm reads and modifies SCSI device parameters.
+These devices can be SCSI disks, in which case @command{sdparm}'s role is
+similar to its namesake: the Linux @command{hdparm} utility originally
+designed for ATA disks. However, @command{sdparm} can be used to access
+parameters on any device that uses a SCSI command set. Such devices
+include CD/DVD drives (irrespective of transport), SCSI and ATAPI tape
+drives, and SCSI enclosures. A small set of commands associated with
+starting and stopping the media, loading and unloading removable media
+and some other housekeeping functions can also be sent with this utility.")
+ (license bsd-3)))
--
2.7.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Adding a first package
@ 2016-02-02 7:04 tobias.geerinckx.rice
2016-02-02 7:04 ` [PATCH] gnu: Add sdparm tobias.geerinckx.rice
0 siblings, 1 reply; 10+ messages in thread
From: tobias.geerinckx.rice @ 2016-02-02 7:04 UTC (permalink / raw
To: guix-devel
Hullo all,
Behold my first patch submission to Guix. \o/ Much complex; very wow.
I've tried to follow the manual 's best I can, ran ‘guix lint’ and
confirmed that everything works. I'm guessing that expanding terms
like ‘SCSI’ and ‘IDE’ would add little value. (?)
Kind regards,
T G-R
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] gnu: Add sdparm.
2016-02-02 7:04 Adding a first package tobias.geerinckx.rice
@ 2016-02-02 7:04 ` tobias.geerinckx.rice
2016-02-02 8:52 ` Tobias Geerinckx-Rice
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: tobias.geerinckx.rice @ 2016-02-02 7:04 UTC (permalink / raw
To: guix-devel
From: Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
* gnu/packages/disk.scm (sdparm): New variable.
---
gnu/packages/disk.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index d806e0c..6e824d2 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -2,6 +2,7 @@
;;; Copyright © 2012, 2013 Nikita Karetnikov <nikita@karetnikov.org>
;;; Copyright © 2015 Mathieu Lirzin <mthl@gnu.org>
;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2016 Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -144,3 +145,29 @@ to recover data more efficiently by only reading the necessary blocks.")
"The dosfstools package includes the mkfs.fat and fsck.fat utilities,
which respectively make and check MS-DOS FAT filesystems.")
(license gpl3+)))
+
+(define-public sdparm
+ (package
+ (name "sdparm")
+ (version "1.09")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "http://sg.danny.cz/sg/p/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0jakqyjwi72zqjzss04bally0xl0lc4710mx8da08vpmir1hfphg"))))
+ (build-system gnu-build-system)
+ (home-page "http://sg.danny.cz/sg/sdparm.html")
+ (synopsis "Provide access to SCSI device parameters")
+ (description "Sdparm reads and modifies SCSI device parameters.
+These devices can be SCSI disks, in which case @command{sdparm}'s role is
+similar to its namesake: the Linux @command{hdparm} utility originally
+designed for ATA disks. However, @command{sdparm} can be used to access
+parameters on any device that uses a SCSI command set. Such devices
+include CD/DVD drives (irrespective of transport), SCSI and ATAPI tape
+drives, and SCSI enclosures. A small set of commands associated with
+starting and stopping the media, loading and unloading removable media
+and some other housekeeping functions can also be sent with this utility.")
+ (license bsd-3)))
--
2.7.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: Add sdparm.
2016-02-02 7:04 ` [PATCH] gnu: Add sdparm tobias.geerinckx.rice
@ 2016-02-02 8:52 ` Tobias Geerinckx-Rice
2016-02-02 10:36 ` Ricardo Wurmus
2016-02-05 8:31 ` Ricardo Wurmus
2 siblings, 0 replies; 10+ messages in thread
From: Tobias Geerinckx-Rice @ 2016-02-02 8:52 UTC (permalink / raw
To: guix-devel
Ugh,
Sorry about the spam. I was having trouble with git send-email +
Gmail, and saw a few other replies make it into the archives a few
hours ago, while mine didn't^H^H^H^Happeared not to.
Apologies, and please disregard the other almost-duplicate thread: I
got bored waiting and changed the description slightly.
Kind regards,
T G-R
On 2 February 2016 at 08:04, <tobias.geerinckx.rice@gmail.com> wrote:
> From: Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
>
> * gnu/packages/disk.scm (sdparm): New variable.
> ---
> gnu/packages/disk.scm | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
> index d806e0c..6e824d2 100644
> --- a/gnu/packages/disk.scm
> +++ b/gnu/packages/disk.scm
> @@ -2,6 +2,7 @@
> ;;; Copyright © 2012, 2013 Nikita Karetnikov <nikita@karetnikov.org>
> ;;; Copyright © 2015 Mathieu Lirzin <mthl@gnu.org>
> ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
> +;;; Copyright © 2016 Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -144,3 +145,29 @@ to recover data more efficiently by only reading the necessary blocks.")
> "The dosfstools package includes the mkfs.fat and fsck.fat utilities,
> which respectively make and check MS-DOS FAT filesystems.")
> (license gpl3+)))
> +
> +(define-public sdparm
> + (package
> + (name "sdparm")
> + (version "1.09")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "http://sg.danny.cz/sg/p/"
> + name "-" version ".tar.xz"))
> + (sha256
> + (base32
> + "0jakqyjwi72zqjzss04bally0xl0lc4710mx8da08vpmir1hfphg"))))
> + (build-system gnu-build-system)
> + (home-page "http://sg.danny.cz/sg/sdparm.html")
> + (synopsis "Provide access to SCSI device parameters")
> + (description "Sdparm reads and modifies SCSI device parameters.
> +These devices can be SCSI disks, in which case @command{sdparm}'s role is
> +similar to its namesake: the Linux @command{hdparm} utility originally
> +designed for ATA disks. However, @command{sdparm} can be used to access
> +parameters on any device that uses a SCSI command set. Such devices
> +include CD/DVD drives (irrespective of transport), SCSI and ATAPI tape
> +drives, and SCSI enclosures. A small set of commands associated with
> +starting and stopping the media, loading and unloading removable media
> +and some other housekeeping functions can also be sent with this utility.")
> + (license bsd-3)))
> --
> 2.7.0
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: Add sdparm.
2016-02-02 7:04 ` [PATCH] gnu: Add sdparm tobias.geerinckx.rice
2016-02-02 8:52 ` Tobias Geerinckx-Rice
@ 2016-02-02 10:36 ` Ricardo Wurmus
2016-02-02 16:30 ` Tobias Geerinckx-Rice
2016-02-05 8:31 ` Ricardo Wurmus
2 siblings, 1 reply; 10+ messages in thread
From: Ricardo Wurmus @ 2016-02-02 10:36 UTC (permalink / raw
To: tobias.geerinckx.rice; +Cc: guix-devel
tobias.geerinckx.rice@gmail.com writes:
> From: Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
>
> * gnu/packages/disk.scm (sdparm): New variable.
> ---
> gnu/packages/disk.scm | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
This patch looks very good! Thank you!
> + (description "Sdparm reads and modifies SCSI device parameters.
> +These devices can be SCSI disks, in which case @command{sdparm}'s role is
> +similar to its namesake: the Linux @command{hdparm} utility originally
> +designed for ATA disks. However, @command{sdparm} can be used to access
> +parameters on any device that uses a SCSI command set. Such devices
> +include CD/DVD drives (irrespective of transport), SCSI and ATAPI tape
> +drives, and SCSI enclosures. A small set of commands associated with
> +starting and stopping the media, loading and unloading removable media
> +and some other housekeeping functions can also be sent with this utility.")
I would remove “Linux” from the description as neither “sdparm” nor
“hdparm” seem to have anything to do with the kernel.
“[...] functions can [...] be sent” sounds odd to me. It probably is
meant to be understood as “commands associated with [...] housekeeping
functions”, but that’s not how I parsed it at first. Maybe it would be
clearer to reorder the sentence as “This utility can also send commands
associated with [this, that, and] some other housekeeping functions”.
If you’re okay with these changes I’ll push it after these slight
modifications.
Thanks again and welcome!
~~ Ricardo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: Add sdparm.
2016-02-02 10:36 ` Ricardo Wurmus
@ 2016-02-02 16:30 ` Tobias Geerinckx-Rice
2016-02-02 16:39 ` Andreas Enge
0 siblings, 1 reply; 10+ messages in thread
From: Tobias Geerinckx-Rice @ 2016-02-02 16:30 UTC (permalink / raw
To: Ricardo Wurmus; +Cc: guix-devel
On 2 February 2016 at 11:36, Ricardo Wurmus
<ricardo.wurmus@mdc-berlin.de> wrote:
>
> tobias.geerinckx.rice@gmail.com writes:
>
>> From: Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
>>
>> * gnu/packages/disk.scm (sdparm): New variable.
>> ---
>> gnu/packages/disk.scm | 27 +++++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>
> This patch looks very good! Thank you!
>
>> + (description "Sdparm reads and modifies SCSI device parameters.
>> +These devices can be SCSI disks, in which case @command{sdparm}'s role is
>> +similar to its namesake: the Linux @command{hdparm} utility originally
>> +designed for ATA disks. However, @command{sdparm} can be used to access
>> +parameters on any device that uses a SCSI command set. Such devices
>> +include CD/DVD drives (irrespective of transport), SCSI and ATAPI tape
>> +drives, and SCSI enclosures. A small set of commands associated with
>> +starting and stopping the media, loading and unloading removable media
>> +and some other housekeeping functions can also be sent with this utility.")
>
> I would remove “Linux” from the description as neither “sdparm” nor
> “hdparm” seem to have anything to do with the kernel.
This caught my suspicion as well, but then hdparm turned out to be in
linux.scm and I dwelt no further on the matter. Go ahead!
>
> “[...] functions can [...] be sent” sounds odd to me. It probably is
> meant to be understood as “commands associated with [...] housekeeping
> functions”, but that’s not how I parsed it at first. Maybe it would be
> clearer to reorder the sentence as “This utility can also send commands
> associated with [this, that, and] some other housekeeping functions”.
>
> If you’re okay with these changes I’ll push it after these slight
> modifications.
Both are certainly improvements. Thank you for your help!
> Thanks again and welcome!
I'm going to have to use Emacs, aren't I...
> ~~ Ricardo
T G-R
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: Add sdparm.
2016-02-02 16:30 ` Tobias Geerinckx-Rice
@ 2016-02-02 16:39 ` Andreas Enge
2016-02-02 16:50 ` Tobias Geerinckx-Rice
0 siblings, 1 reply; 10+ messages in thread
From: Andreas Enge @ 2016-02-02 16:39 UTC (permalink / raw
To: Tobias Geerinckx-Rice; +Cc: guix-devel
One minor point:
On Tue, Feb 02, 2016 at 05:30:07PM +0100, Tobias Geerinckx-Rice wrote:
> >> +These devices can be SCSI disks, in which case @command{sdparm}'s role is
"the role of @command{sdparm}", since the command is not a person and
thus does not take a genitive "s".
Andreas
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: Add sdparm.
2016-02-02 16:39 ` Andreas Enge
@ 2016-02-02 16:50 ` Tobias Geerinckx-Rice
2016-02-02 17:01 ` Andreas Enge
0 siblings, 1 reply; 10+ messages in thread
From: Tobias Geerinckx-Rice @ 2016-02-02 16:50 UTC (permalink / raw
To: Andreas Enge; +Cc: guix-devel
On 2 February 2016 at 17:39, Andreas Enge <andreas@enge.fr> wrote:
> One minor point:
> [...]
A good one. So, for (my) future reference: re-writing upstream's
descriptions for Guix is no problem?
Glad to hear that.
T G-R
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: Add sdparm.
2016-02-02 16:50 ` Tobias Geerinckx-Rice
@ 2016-02-02 17:01 ` Andreas Enge
0 siblings, 0 replies; 10+ messages in thread
From: Andreas Enge @ 2016-02-02 17:01 UTC (permalink / raw
To: Tobias Geerinckx-Rice; +Cc: guix-devel
On Tue, Feb 02, 2016 at 05:50:48PM +0100, Tobias Geerinckx-Rice wrote:
> A good one. So, for (my) future reference: re-writing upstream's
> descriptions for Guix is no problem?
No, we do it all the time, to remove advertisements for non-freeness,
to drop superfluous references to freeness, to shorten, and so on.
The upstream description is just often a very convenient starting point.
I let Ricardo push then.
Congratulations for your first contribution, and welcome aboard!
Andreas
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: Add sdparm.
2016-02-02 7:04 ` [PATCH] gnu: Add sdparm tobias.geerinckx.rice
2016-02-02 8:52 ` Tobias Geerinckx-Rice
2016-02-02 10:36 ` Ricardo Wurmus
@ 2016-02-05 8:31 ` Ricardo Wurmus
2 siblings, 0 replies; 10+ messages in thread
From: Ricardo Wurmus @ 2016-02-05 8:31 UTC (permalink / raw
To: tobias.geerinckx.rice; +Cc: guix-devel
Hi Tobias,
> From: Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
>
> * gnu/packages/disk.scm (sdparm): New variable.
I just pushed your patch with the suggested modifications from Andreas
and myself.
Thanks again!
~~ Ricardo
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-02-05 8:31 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-02 7:04 Adding a first package tobias.geerinckx.rice
2016-02-02 7:04 ` [PATCH] gnu: Add sdparm tobias.geerinckx.rice
2016-02-02 8:52 ` Tobias Geerinckx-Rice
2016-02-02 10:36 ` Ricardo Wurmus
2016-02-02 16:30 ` Tobias Geerinckx-Rice
2016-02-02 16:39 ` Andreas Enge
2016-02-02 16:50 ` Tobias Geerinckx-Rice
2016-02-02 17:01 ` Andreas Enge
2016-02-05 8:31 ` Ricardo Wurmus
-- strict thread matches above, loose matches on Subject: below --
2016-02-02 0:20 Add sdparm SCSI command utility tobias.geerinckx.rice
2016-02-02 0:20 ` [PATCH] gnu: Add sdparm tobias.geerinckx.rice
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.