all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] gnu/packages/linux iptables: include firewall in description
@ 2016-01-25 18:48 Ni* Gillmann
  2016-01-31 21:24 ` Leo Famulari
  0 siblings, 1 reply; 2+ messages in thread
From: Ni* Gillmann @ 2016-01-25 18:48 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 1779 bytes --]

This is a patch to include "firewall" in the description of iptables, as
it does not turn up with a search for "firewall" which might not be so
intuitive for GNU beginners.
I did not want to change the complete description (yet), I am open to
suggestions if this short addition is not accurate. The important thing
is to include "firewall" so it will turn up without knowing "ip
filtering" "iptables" or similar concepts.


From 0fbccf724e62eea2874428dbc115a2095718fb66 Mon Sep 17 00:00:00 2001
From: Ni* Gillmann <niasterisk@grrlz.net>
Date: Mon, 25 Jan 2016 19:08:52 +0100
Subject: [PATCH] gnu: linux.scm: iptables: include firewall in description

---
 gnu/packages/linux.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 579df02..0d86c78 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
 ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016 Christopher Allan Webber <cwebber@dustycloud.org>
+;;; Copyright © 2016 Nils Gillmann <niasterisk@grrlz.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -881,7 +882,8 @@ Linux 2.4.x and later IPv4 packet filtering ruleset.  It is targeted towards
 system administrators.  Since Network Address Translation is also configured
 from the packet filter ruleset, iptables is used for this, too.  The iptables
 package also includes ip6tables.  ip6tables is used for configuring the IPv6
-packet filter.")
+packet filter. In the broader sense it can be seen as a firewall tool for the
+GNU System.")
     (license license:gpl2+)))

 (define-public iproute
--
2.6.3



[-- Attachment #2: iptables description patch --]
[-- Type: text/x-patch, Size: 1342 bytes --]

From 0fbccf724e62eea2874428dbc115a2095718fb66 Mon Sep 17 00:00:00 2001
From: Ni* Gillmann <niasterisk@grrlz.net>
Date: Mon, 25 Jan 2016 19:08:52 +0100
Subject: [PATCH] gnu: linux.scm: iptables: include firewall in description

---
 gnu/packages/linux.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 579df02..0d86c78 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
 ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016 Christopher Allan Webber <cwebber@dustycloud.org>
+;;; Copyright © 2016 Nils Gillmann <niasterisk@grrlz.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -881,7 +882,8 @@ Linux 2.4.x and later IPv4 packet filtering ruleset.  It is targeted towards
 system administrators.  Since Network Address Translation is also configured
 from the packet filter ruleset, iptables is used for this, too.  The iptables
 package also includes ip6tables.  ip6tables is used for configuring the IPv6
-packet filter.")
+packet filter. In the broader sense it can be seen as a firewall tool for the
+GNU System.")
     (license license:gpl2+)))

 (define-public iproute
--
2.6.3

[-- Attachment #3: Type: text/plain, Size: 40 bytes --]


--
ng/ni*
vcard: http://krosos.sdf.org

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gnu/packages/linux iptables: include firewall in description
  2016-01-25 18:48 [PATCH] gnu/packages/linux iptables: include firewall in description Ni* Gillmann
@ 2016-01-31 21:24 ` Leo Famulari
  0 siblings, 0 replies; 2+ messages in thread
From: Leo Famulari @ 2016-01-31 21:24 UTC (permalink / raw)
  To: Ni* Gillmann; +Cc: guix-devel

On Mon, Jan 25, 2016 at 07:48:25PM +0100, Ni* Gillmann wrote:
> This is a patch to include "firewall" in the description of iptables, as
> it does not turn up with a search for "firewall" which might not be so
> intuitive for GNU beginners.
> I did not want to change the complete description (yet), I am open to
> suggestions if this short addition is not accurate. The important thing
> is to include "firewall" so it will turn up without knowing "ip
> filtering" "iptables" or similar concepts.

It's a good idea.

Typically, the kernel's packet filter is described as the "firewall" and
iptables is used to configure it [0]. Can you change it to communicate
that more clearly?

Also, can you be sure to make the commit message match the GNU changelog
[1] format? You can look at Guix's git log for examples.

Thanks!

[0]
https://en.wikipedia.org/wiki/Iptables

[1] 
http://www.gnu.org/prep/standards/standards.html#Change-Logs
https://www.gnu.org/software/guix/manual/guix.html#Submitting-Patches

> 
> 
> From 0fbccf724e62eea2874428dbc115a2095718fb66 Mon Sep 17 00:00:00 2001
> From: Ni* Gillmann <niasterisk@grrlz.net>
> Date: Mon, 25 Jan 2016 19:08:52 +0100
> Subject: [PATCH] gnu: linux.scm: iptables: include firewall in description
> 
> ---
>  gnu/packages/linux.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 579df02..0d86c78 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -7,6 +7,7 @@
>  ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
>  ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
>  ;;; Copyright © 2016 Christopher Allan Webber <cwebber@dustycloud.org>
> +;;; Copyright © 2016 Nils Gillmann <niasterisk@grrlz.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -881,7 +882,8 @@ Linux 2.4.x and later IPv4 packet filtering ruleset.  It is targeted towards
>  system administrators.  Since Network Address Translation is also configured
>  from the packet filter ruleset, iptables is used for this, too.  The iptables
>  package also includes ip6tables.  ip6tables is used for configuring the IPv6
> -packet filter.")
> +packet filter. In the broader sense it can be seen as a firewall tool for the
> +GNU System.")
>      (license license:gpl2+)))
> 
>  (define-public iproute
> --
> 2.6.3
> 
> 

> From 0fbccf724e62eea2874428dbc115a2095718fb66 Mon Sep 17 00:00:00 2001
> From: Ni* Gillmann <niasterisk@grrlz.net>
> Date: Mon, 25 Jan 2016 19:08:52 +0100
> Subject: [PATCH] gnu: linux.scm: iptables: include firewall in description
> 
> ---
>  gnu/packages/linux.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 579df02..0d86c78 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -7,6 +7,7 @@
>  ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
>  ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
>  ;;; Copyright © 2016 Christopher Allan Webber <cwebber@dustycloud.org>
> +;;; Copyright © 2016 Nils Gillmann <niasterisk@grrlz.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -881,7 +882,8 @@ Linux 2.4.x and later IPv4 packet filtering ruleset.  It is targeted towards
>  system administrators.  Since Network Address Translation is also configured
>  from the packet filter ruleset, iptables is used for this, too.  The iptables
>  package also includes ip6tables.  ip6tables is used for configuring the IPv6
> -packet filter.")
> +packet filter. In the broader sense it can be seen as a firewall tool for the
> +GNU System.")
>      (license license:gpl2+)))
> 
>  (define-public iproute
> --
> 2.6.3

> 
> --
> ng/ni*
> vcard: http://krosos.sdf.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-01-31 21:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-25 18:48 [PATCH] gnu/packages/linux iptables: include firewall in description Ni* Gillmann
2016-01-31 21:24 ` Leo Famulari

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.