[PATCH] gnu: Add gtk-vnc.

[PATCH] gnu: Add gtk-vnc.

[rennes]

[-- Attachment #1: Type: text/plain, Size: 57 bytes --]

Hi again,

i attach the patch for your revision.

regards

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-gtk-vnc.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-gtk-vnc.patch, Size: 2796 bytes --]

From b9043158a88983daff7b4f9309654edf642b1f87 Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Wed, 27 Jan 2016 20:07:12 +0100
Subject: [PATCH] gnu: Add gtk-vnc.

---
 gnu-system.am            |  1 +
 gnu/packages/gtk-vnc.scm | 55 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 56 insertions(+)
 create mode 100644 gnu/packages/gtk-vnc.scm

diff --git a/gnu-system.am b/gnu-system.am
index ad59241..9277375 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -149,6 +149,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/gsasl.scm			\
   gnu/packages/gstreamer.scm			\
   gnu/packages/gtk.scm				\
+  gnu/packages/gtk-vnc.scm			\
   gnu/packages/guile.scm			\
   gnu/packages/guile-wm.scm			\
   gnu/packages/gv.scm				\
diff --git a/gnu/packages/gtk-vnc.scm b/gnu/packages/gtk-vnc.scm
new file mode 100644
index 0000000..449f2f9
--- /dev/null
+++ b/gnu/packages/gtk-vnc.scm
@@ -0,1 +1,55 @@
+2016-01-27  Rene Saavedra  <rennes@openmailbox.org>
+
+	* gnu/packages/gtk-vnc.scm: New file
+
+	* gnu-system (GNU_SYSTEM_MODULES): Add it.
+
+(define-module (gnu packages gtk-vnc)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix utils)  
+  #:use-module (guix build-system gnu)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages tls)
+  #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages pulseaudio))
+(define-public gtk-vnc
+  (package
+    (name "gtk-vnc")
+    (version "0.5.4")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "mirror://gnome/sources/" name "/"
+                          (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+      (sha256
+       (base32
+        "1rwwdh7lb16xdmy76ca6mpqfc3zfl3a4bkcr0qb6hs6ffrxak2j8"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "--with-gtk=3.0" "--enable-vala" "--without-sasl")))
+    (inputs
+     `(("gtk+" ,gtk+)
+       ("gjs" ,gjs)
+       ("libgcrypt" ,libgcrypt)
+       ("gnutls" ,gnutls)
+       ("pulseaudio" ,pulseaudio)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("intltool" ,intltool)
+       ("glib" ,glib "bin")
+       ("vala" ,vala)))
+    (home-page "https://wiki.gnome.org/Projects/gtk-vnc")
+    (synopsis "VNC viewer widget for GTK")
+    (description
+     "GTK-VNC is an API used by Vinagre client application,
+Boxes and virt-viewer.  GTK-VNC supports authentication extensions
+as SASL, TLS, VeNCrypt.  Additionally supports encoding extensions.")
+    (license license:lgpl2.1+)))
+gtk-vnc
-- 
2.6.3

Re: [PATCH] gnu: Add gtk-vnc.

[宋文武]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

rennes@openmailbox.org writes:

> Hi again,
>
> i attach the patch for your revision.
Hi, this patch doesn't apply cleanly.
I made follow adjustments with it:

- Move it to gnome.scm, it's a gnome project after all :-)
- Enable SASL support.
- Remove "--enable-vala", it's auto-detected.
- Replace gjs with gobject-introspection, I don't see any use of
  gjs from it.


[-- Attachment #2: 0001-gnu-Add-gtk-vnc.patch --]
[-- Type: text/x-patch, Size: 2552 bytes --]

From db436ed87cb94b82c230962b5e454b8a440475ee Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Wed, 27 Jan 2016 20:07:12 +0100
Subject: [PATCH] gnu: Add gtk-vnc.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* gnu/packages/gnome.scm (gtk-vnc): New variable.

Co-authored-by: 宋文武 <iyzsong@gmail.com>
---
 gnu/packages/gnome.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 9ce750d..7656f38 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -45,6 +45,7 @@
   #:use-module (gnu packages check)
   #:use-module (gnu packages cups)
   #:use-module (gnu packages curl)
+  #:use-module (gnu packages cyrus-sasl)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages djvu)
   #:use-module (gnu packages dns)
@@ -4567,3 +4568,40 @@ properties, screen resolution, and other GNOME parameters.")
      "GNOME Shell provides core user interface functions for the GNOME desktop,
 like switching to windows and launching applications.")
     (license license:gpl2+)))
+
+(define-public gtk-vnc
+  (package
+    (name "gtk-vnc")
+    (version "0.5.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://gnome/sources/" name "/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1rwwdh7lb16xdmy76ca6mpqfc3zfl3a4bkcr0qb6hs6ffrxak2j8"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:configure-flags '("--with-gtk=3.0")))
+    (propagated-inputs
+     `(("gtk+" ,gtk+))) ; required by gtk-vnc-2.0.pc.
+    (inputs
+     `(("cyrus-sasl" ,cyrus-sasl)
+       ("gnutls" ,gnutls)
+       ("libgcrypt" ,libgcrypt)
+       ("pulseaudio" ,pulseaudio)))
+    (native-inputs
+     `(("glib:bin" ,glib "bin")
+       ("gobject-introspection" ,gobject-introspection)
+       ("intltool" ,intltool)
+       ("pkg-config" ,pkg-config)
+       ("vala" ,vala)))
+    (home-page "https://wiki.gnome.org/Projects/gtk-vnc")
+    (synopsis "VNC viewer widget for GTK+")
+    (description
+     "GTK-VNC is an API used by Vinagre client application,
+Boxes and virt-viewer.  GTK-VNC supports authentication extensions
+as SASL, TLS, VeNCrypt.  Additionally supports encoding extensions.")
+    (license license:lgpl2.1+)))
-- 
2.5.0


[-- Attachment #3: Type: text/plain, Size: 259 bytes --]


And the description still needs more love. I think saying it's "an API"
for some applications doesn't show much about what it does. Maybe
"remote desktop" should be mentioned.

Well, I'm surely not the right person to review descriptions, just my
two coins.

Re: [PATCH] gnu: Add gtk-vnc.

[rennes]

thanks,

i need to submit again or i consider the patch attached as approved?

regards


On 2016-01-28 04:34, iyzsong@member.fsf.org wrote:
> rennes@openmailbox.org writes:
> 
>> Hi again,
>> 
>> i attach the patch for your revision.
> Hi, this patch doesn't apply cleanly.
> I made follow adjustments with it:
> 
> - Move it to gnome.scm, it's a gnome project after all :-)
> - Enable SASL support.
> - Remove "--enable-vala", it's auto-detected.
> - Replace gjs with gobject-introspection, I don't see any use of
>   gjs from it.
> 
> 
> 
> And the description still needs more love. I think saying it's "an API"
> for some applications doesn't show much about what it does. Maybe
> "remote desktop" should be mentioned.
> 
> Well, I'm surely not the right person to review descriptions, just my
> two coins.

Re: [PATCH] gnu: Add gtk-vnc.

[Andreas Enge]

Hello,

the patch looks good for me except for a few details in the description:

On Thu, Jan 28, 2016 at 11:34:30AM +0800, 宋文武 wrote:
> +     "GTK-VNC is an API used by Vinagre client application,
> +Boxes and virt-viewer.  GTK-VNC supports authentication extensions
> +as SASL, TLS, VeNCrypt.  Additionally supports encoding extensions.")
> +    (license license:lgpl2.1+)))

"GTK-VNC is an API used by the Vinagre client application,
Boxes and virt-viewer.  GTK-VNC supports authentication extensions
such as SASL, TLS, VeNCrypt.  Additionally it supports encoding extensions."

Hm, it is not quite clear what the API is for, actually; so maybe:

"GTK-VNC is an API used by remote desktop viewing applications for
GNOME, for instance the Vinagre client, Boxes and virt-viewer.  GTK-VNC
supports authentication extensions such as SASL, TLS, and
VeNCrypt.  Additionally it supports encoding extensions."

Andreas

Re: [PATCH] gnu: Add gtk-vnc.

[Leo Famulari]

On Thu, Jan 28, 2016 at 09:15:03PM +0100, Andreas Enge wrote:
> Hello,
> 
> the patch looks good for me except for a few details in the description:

Is this a GNOME project? In that case, I think it would be best applied
in gnome.scm.

> 
> On Thu, Jan 28, 2016 at 11:34:30AM +0800, 宋文武 wrote:
> > +     "GTK-VNC is an API used by Vinagre client application,
> > +Boxes and virt-viewer.  GTK-VNC supports authentication extensions
> > +as SASL, TLS, VeNCrypt.  Additionally supports encoding extensions.")
> > +    (license license:lgpl2.1+)))
> 
> "GTK-VNC is an API used by the Vinagre client application,
> Boxes and virt-viewer.  GTK-VNC supports authentication extensions
> such as SASL, TLS, VeNCrypt.  Additionally it supports encoding extensions."
> 
> Hm, it is not quite clear what the API is for, actually; so maybe:
> 
> "GTK-VNC is an API used by remote desktop viewing applications for
> GNOME, for instance the Vinagre client, Boxes and virt-viewer.  GTK-VNC
> supports authentication extensions such as SASL, TLS, and
> VeNCrypt.  Additionally it supports encoding extensions."
> 
> Andreas
> 
> 

Re: [PATCH] gnu: Add gtk-vnc.

[宋文武]

I update the description, and push it.

Thanks for the patch and reviews!

Re: [PATCH] gnu: Add gtk-vnc.

[Ludovic Courtès]

iyzsong@member.fsf.org (宋文武) skribis:

> I update the description, and push it.
>
> Thanks for the patch and reviews!

And thanks 宋文武.  :-)

To everyone: When commenting on a patch, please make sure to make it
clear in your message whether you are asking for some concrete action
from the submitter, or whether your are fixing it yourself and pushing
it.

Ludo’, happy to see more and more reviewers.  :-)