[PATCH 0/1] Add transmission-remote-cli

[PATCH 0/1] Add transmission-remote-cli

[Leo Famulari]

Transmission-remote-cli is a curses-interface client for the
Transmission bittorrent daemon.

The package is one python script, a man page, and a Bash shell
completion script. So, I deleted the build phase and replaced the
install phase. Is that okay?

Also, do we have a standard way to install Zsh shell completions? This
software provides them, but this package does not.

Leo Famulari (1):
  gnu: Add transmission-remote-cli.

 gnu/packages/bittorrent.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

-- 
2.6.4

[PATCH 1/1] gnu: Add transmission-remote-cli.

[Leo Famulari]

* gnu/packages/bittorrent.scm (transmission-remote-cli): New variable.
---
 gnu/packages/bittorrent.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
index 967580d..7719db0 100644
--- a/gnu/packages/bittorrent.scm
+++ b/gnu/packages/bittorrent.scm
@@ -21,6 +21,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module ((guix licenses) #:prefix l:)
   #:use-module (gnu packages libevent)
@@ -33,6 +34,7 @@
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages check)
   #:use-module (gnu packages ncurses)
+  #:use-module (gnu packages python)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages cyrus-sasl)
   #:use-module (gnu packages tls))
@@ -148,3 +150,44 @@ full encryption, DHT, PEX, and Magnet Links.  It can also be controlled via
 XML-RPC over SCGI.")
     (home-page "https://github.com/rakshasa/rtorrent")
     (license l:gpl2+)))
+
+(define-public transmission-remote-cli
+  (package
+    (name "transmission-remote-cli")
+    (version "1.7.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/fagga/"
+                                  "transmission-remote-cli/archive/v"
+                                  version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1y0hkpcjf6jw9xig8yf484hbhy63nip0pkchx401yxj81m25l4z9"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2 ; only supports Python 2
+       #:tests? #f ; no test suite
+       #:phases (modify-phases %standard-phases
+                  ;; The software is just a Python script that must be
+                  ;; copied into place.
+                  (delete 'build)
+                  (replace 'install
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (bin (string-append out "/bin"))
+                             (man (string-append out "/share/man/man1"))
+                             ;; FIXME install zsh completions
+                             (completions (string-append out "/etc/bash_completion.d")))
+                        (install-file "transmission-remote-cli" bin)
+                        (install-file "transmission-remote-cli.1" man)
+                        (install-file
+                          (string-append
+                            "completion/bash/"
+                            "transmission-remote-cli-bash-completion.sh")
+                          completions)))))))
+    (synopsis "Console client for the Transmission BitTorrent daemon")
+    (description "Transmission-remote-cli is a console client, with a curses
+interface, for the Transmission BitTorrent daemon.")
+    (home-page "https://github.com/fagga/transmission-remote-cli")
+    (license l:gpl3+)))
-- 
2.6.4

Re: [PATCH 0/1] Add transmission-remote-cli

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> Transmission-remote-cli is a curses-interface client for the
> Transmission bittorrent daemon.
>
> The package is one python script, a man page, and a Bash shell
> completion script. So, I deleted the build phase and replaced the
> install phase. Is that okay?

Sure.

In some cases, it’s also possible to use the dumb
‘trivial-build-system’, but sometimes its dumbness makes it
inconvenient.

> Also, do we have a standard way to install Zsh shell completions? This
> software provides them, but this package does not.

I don’t know, we should install them wherever Zsh will look for them.
For Bash, we have bash-completion-directories.patch.

> * gnu/packages/bittorrent.scm (transmission-remote-cli): New variable.

Please add a copyright line for yourself.

Otherwise LGTM.

Thanks!

Ludo’.

Re: [PATCH 0/1] Add transmission-remote-cli

[Leo Famulari]

On Wed, Jan 20, 2016 at 11:42:08PM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > Transmission-remote-cli is a curses-interface client for the
> > Transmission bittorrent daemon.
> >
> > The package is one python script, a man page, and a Bash shell
> > completion script. So, I deleted the build phase and replaced the
> > install phase. Is that okay?
> 
> Sure.
> 
> In some cases, it’s also possible to use the dumb
> ‘trivial-build-system’, but sometimes its dumbness makes it
> inconvenient.
> 
> > Also, do we have a standard way to install Zsh shell completions? This
> > software provides them, but this package does not.
> 
> I don’t know, we should install them wherever Zsh will look for them.
> For Bash, we have bash-completion-directories.patch.

Looking into it...

> 
> > * gnu/packages/bittorrent.scm (transmission-remote-cli): New variable.
> 
> Please add a copyright line for yourself.
> 
> Otherwise LGTM.

Pushed!

> 
> Thanks!
> 
> Ludo’.