Re: [PATCH] gnu: Add fdm

[Leo Famulari <leo@famulari.name>]

On Mon, Jan 18, 2016 at 11:30:29AM -0800, Christopher Allan Webber wrote:
> Hello all,
> 
> I've packaged fdm, a mail distribution tool.  Look okay to merge?
> 

> From c0d0fde9785680a3642e2cd54f46c3b447cfbb1b Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Mon, 18 Jan 2016 11:25:16 -0800
> Subject: [PATCH] gnu: Add fdm.
> 
> * gnu/packages/mail.scm (fdm): New variable.
> ---
>  gnu/packages/mail.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index f765728..01a791f 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -9,6 +9,7 @@
>  ;;; Copyright © 2015 Eric Bavier <bavier@member.fsf.org>
>  ;;; Copyright © 2015 Andreas Enge <andreas@enge.fr>
>  ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
> +;;; Copyright © 2016 Christopher Allan Webber <cwebber@dustycloud.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1013,4 +1014,39 @@ compatibility shims for the @command{sendmail}, @command{mailq}, and
>  @command{newaliases} commands.")
>      (license gpl2+)))
>  
> +(define-public fdm
> +  (package
> +    (name "fdm")
> +    (version "1.9")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append "https://github.com/nicm/fdm/releases/download/"
> +                                 version "/fdm-"
> +                                 version ".tar.gz"))
> +             (file-name (string-append name "-" version ".tar.gz"))
> +             (sha256
> +               (base32 "054rscijahiza5f9qha79rg3siji3bk5mk10f8c2vqx7m4w6qh8n"))))
> +    (build-system gnu-build-system)
> +    (native-inputs `(("autoconf" ,(autoconf-wrapper))
> +                     ("automake" ,automake)
> +                     ("libtool" ,libtool)))

Depending on the project, it might be worth it to ask upstream to do the
bootstrapping themselves so these inputs could be removed in a future
release. I have seen that work a few times.

Either way I think it's good to insert a comment that says "Required for 
bootstrapping" or something like that.

> +    (inputs
> +     `(("tdb" ,tdb)
> +       ("openssl" ,openssl)
> +       ("zlib" ,zlib)))
> +    (home-page "https://github.com/nicm/fdm")
> +    (synopsis "Mail fetching and delivery tool")

Is it useful to categorize the tool here? I.E., is it an MTA, MRA, etc?
If it fits one of these well-known categories, a label could help some
users quickly evaluate whether or not it fits their needs.

https://en.wikipedia.org/wiki/Email_agent_%28infrastructure%29

> +    (description "fdm is a program designed to fetch mail from POP3
> +or IMAP servers, or receive local mail from stdin, and
> +deliver it in various ways.")
> +    (license
> +     ;; Why point to Debian's copy?  Well, all the individual files have a
> +     ;; copy of this license in their headers, but there's no seprate file
> +     ;; with that information.  Debian already provided us with a nice URI
> +     ;; to point to...
> +     (non-copyleft
> +      (string-append
> +       "http://metadata.ftp-master.debian.org/"
> +       "changelogs/main/f/fdm/fdm_1.7+cvs20140912-1_copyright")))))

How about a patch upstream to add COPYING?

LGTM even without these changes since they are all minor "nice-to-have".

> +
>  ;;; mail.scm ends here
> -- 
> 2.6.3
>