From: Andreas Enge <andreas@enge.fr>
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH] Upgrade bedtools to 0.25.0.
Date: Sat, 9 Jan 2016 17:37:15 +0100 [thread overview]
Message-ID: <20160109163715.GA12060@debian> (raw)
In-Reply-To: <20160109134419.GA19838@thebird.nl>
On Sat, Jan 09, 2016 at 02:44:19PM +0100, Pjotr Prins wrote:
> Sometimes I wonder if we are not being too prissy. Not exactly taxing
> to read it in one commit and we can trust the committer to test it. I
> see the point of agreed layouts and putting things in a *single*
> commit. Now, for a change, we need two.
I do not have very strong feelings about the matter, but I do see the point
of separating stylistic and syntactic changes on one hand from functional
changes on the other hand. Then one can simply accept the former without
further checking; and the latter does not require any checking since only
the version and the hash line have changed. Probably it would then be okay to
push these two commits directly without posting the patches to the list first.
Andreas
next prev parent reply other threads:[~2016-01-09 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 6:47 [PATCH] Upgrade bedtools to 0.25.0 Ben Woodcroft
2016-01-09 9:54 ` Andreas Enge
2016-01-09 13:44 ` Pjotr Prins
2016-01-09 16:37 ` Andreas Enge [this message]
2016-01-09 17:48 ` Ludovic Courtès
2016-01-09 18:07 ` Ricardo Wurmus
2016-01-09 20:32 ` Leo Famulari
2016-01-10 14:39 ` Ben Woodcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160109163715.GA12060@debian \
--to=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=pjotr.public12@thebird.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.