From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [v3 2/2] gnu: w3m: Enable SSL, disable broken protocols and
	ciphers.
Date: Thu, 7 Jan 2016 02:37:52 -0500
Message-ID: <20160107073752.GC31830@jasmine>
References: <9d18197ecca4fe8509e9fa7588f93b9f41ad56e1.1452045889.git.leo@famulari.name>
	<9d18197ecca4fe8509e9fa7588f93b9f41ad56e1.1452045889.git.leo@famulari.name>
	<5ea735685b49a166c74b756cb311e8a6142e132c.1452045889.git.leo@famulari.name>
	<87si2bgeug.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44795)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aH58u-000385-Ts
	for guix-devel@gnu.org; Thu, 07 Jan 2016 02:37:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aH58r-0002Ya-J1
	for guix-devel@gnu.org; Thu, 07 Jan 2016 02:37:56 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:54157)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aH58r-0002YT-Ep
	for guix-devel@gnu.org; Thu, 07 Jan 2016 02:37:53 -0500
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
	by mailout.nyi.internal (Postfix) with ESMTP id 4950020531
	for <guix-devel@gnu.org>; Thu,  7 Jan 2016 02:37:53 -0500 (EST)
Content-Disposition: inline
In-Reply-To: <87si2bgeug.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On Wed, Jan 06, 2016 at 11:52:07AM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > * gnu/packages/patches/w3m-force-ssl_verify_server-on.patch: New file.
> > * gnu/packages/patches/w3m-disable-sslv2-and-sslv3.patch: New file.
> > * gnu/packages/patches/w3m-disable-weak-ciphers.patch: New file.
> > * gnu/packages/w3m.scm (w3m)[source]: Add patches.
> > * gnu-system.am (dist_patch_DATA): Add the new files.
> 
> Please add:
> 
>   Fixes <http://bugs.gnu.org/16791>.

Done.

> 
> > +From 7b8d2dbc41b6bdab09e2e632e8481f6e8b585a42 Mon Sep 17 00:00:00 2001
> > +From: Leo Famulari <leo@famulari.name>
> > +Date: Tue, 5 Jan 2016 17:15:33 -0500
> > +Subject: [PATCH 3/4] Disable SSLv2 and SSLv3.
> 
> I would remove the Git header from the patches (since they are from a
> local repository I guess?) and keep only the subject line and
> description.

Done.

> 
> Otherwise LGTM!

Pushed with the requested changes as e6352001c4 and 62339e2d49.

> 
> Thanks for working on one of the oldest bug reports.  :-)
> 
> Ludo’.