Re: Trying to fix an error in the pypi-importer

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 2176 bytes --]

On Wed, 30 Dec 2015 20:53:47 +0100
swedebugia@riseup.net wrote:

> Hi :)
> 
> I am trying to fix this error in the pypi-importer:
> 
> ~/src/guix$ ./pre-inst-env guix lint python-twisted
> gnu/packages/python.scm:6628:0: python-twisted-15.5.0: all the source 
> URIs are unreachable:
> gnu/packages/python.scm:6628:0: python-twisted-15.5.0: URI 
> https://pypi.python.org/packages/source/T/Twisted/Twisted-15.5.0.tar.gz 
> not reachable: 404 ("Not Found")
>  [...]  
> guix/build-system/python.scm:
> 
> (define (pypi-uri name version)
>    "Return a URI string for the Python package hosted on the Python 
> Package
> Index (PyPI) corresponding to NAME and VERSION."
>    (string-append "https://pypi.python.org/packages/source/"
>                   (string-take name 1) "/" name "/"
>                   name "-" version ".tar.gz"))
> 
> I read up on if-else with Guile and changed it to:
> (define (pypi-uri name version ending)
>    "Return a URI string for the Python package hosted on the Python 
> Package
> Index (PyPI) corresponding to NAME and VERSION."
>    (if (zero? ending)
>        (string-append "https://pypi.python.org/packages/source/"
>                   (string-take name 1) "/" name "/"
>                   name "-" version ".tar.gz"))
>    (else
>        (string-append "https://pypi.python.org/packages/source/"
>                   (string-take name 1) "/" name "/"
>                   name "-" version "." ending )))
> 
> Will this work?
> I did a make and got:
>    GUILEC guix/build-system/python.go
> guix/build-system/python.scm:51:2: warning: possibly unbound variable 
> `else'
> wrote `guix/build-system/python.go'
> 
> The goal was to change in a way that would not break all other calls to 
> the procedure pypi-uri.
> 
> Any thoughts?
> 
> * see https://pypi.python.org/pypi/Twisted/json
> 


does this also take care of the ones that are stored as name "-" version ".zip"?

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]