From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/2] gnu: Add cuetools.
Date: Tue, 29 Dec 2015 19:55:47 -0500
Message-ID: <20151230005547.GA5737@jasmine>
References: <cover.1451280624.git.leo@famulari.name>
	<cover.1451280624.git.leo@famulari.name>
	<0266be5311e6f02cb2dd73e87a7cdd05a7a59f69.1451280624.git.leo@famulari.name>
	<87io3gzvj8.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57353)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aE53P-00042o-Tr
	for guix-devel@gnu.org; Tue, 29 Dec 2015 19:55:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aE53M-0001Hm-Na
	for guix-devel@gnu.org; Tue, 29 Dec 2015 19:55:51 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:56302)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aE53M-0001Hb-K1
	for guix-devel@gnu.org; Tue, 29 Dec 2015 19:55:48 -0500
Content-Disposition: inline
In-Reply-To: <87io3gzvj8.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On Wed, Dec 30, 2015 at 12:26:19AM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > * gnu/packages/audio.scm (cuetools): New variable.
> 
> [...]
> 
> > +        (modify-phases %standard-phases
> > +          (add-after 'unpack 'bootstrap
> > +                     (lambda _ (zero? (system* "autoreconf" "-vfi")))))))
> 
> Note that, as per a recent rule, the “(lambda” should be aligned with
> the ‘d’ of ‘add-after’.

Done.

> 
> > +    (home-page "https://github.com/svend/cuetools")
> > +    (license license:gpl2)))
> 
> AFAICS, source file headers do not mention a specific GPL version; thus,
> it should be ‘gpl2+’.

Done.

> 
> Otherwise LGTM, thanks!

Pushed as 6da16993eb.

> 
> Ludo’.