From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/1] doc: Explain significance of partition labels.
Date: Sun, 20 Dec 2015 23:29:16 -0500
Message-ID: <20151221042916.GA17705@jasmine>
References: <cover.1450580065.git.leo@famulari.name>
	<cover.1450580065.git.leo@famulari.name>
	<cdfaa2c4f29b1ecc061af6c4e10049188766eb9d.1450580065.git.leo@famulari.name>
	<87y4cosr4r.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35721)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aAs67-0004IJ-1j
	for guix-devel@gnu.org; Sun, 20 Dec 2015 23:29:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aAs61-00057w-Mw
	for guix-devel@gnu.org; Sun, 20 Dec 2015 23:29:22 -0500
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:34560)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aAs61-00057d-K1
	for guix-devel@gnu.org; Sun, 20 Dec 2015 23:29:17 -0500
Content-Disposition: inline
In-Reply-To: <87y4cosr4r.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On Sun, Dec 20, 2015 at 11:16:04PM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > * doc/guix.texi (Preparing for Installation): Point out relationship
> > between partition labels and the file-system configuration.
> 
> [...]
> 
> > +Be sure that your partition labels match the value of their respective
> > +@code{device} fields in your @code{file-system} configuration, if your
> > +@code{file-system} configuration sets the value of @code{title} to
> > +"label", as do the example configurations found on the USB installation
> 
> @code{'label}
> 
> > +image under @code{/etc/configuration} (@pxref{Using the Configuration
> 
> @file{/etc/configuration}
> 
> Otherwise LGTM!

I fixed those.

> I’ve noticed a number of people who had overlooked the comment in the
> configuration examples, so this is a worthy addition.
> 
> I wonder if changing the label in the examples from “root” to
> “my-root-partition” or similar wouldn’t make it less easily overlooked?

Done in the updated patch.

> 
> Thanks,
> Ludo’.